From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D38E936D9F9 for ; Mon, 15 Jun 2026 10:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781520904; cv=none; b=M4b1fKWDzVIhzj8eow1VZxm/h1A6FDiJAC0PEhxJ1Ef4arZsaZYEXycfgyLgTf6DQDbkbHTCJSblzd9bTolaUAq1Az9OYfd1+KizaIBW9d8vzK2lvRIIEq1y/FkBmVXt0nTNI1wXsz53tLuWykDAIz4DbYmJl3iq0Sy9JSuxMm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781520904; c=relaxed/simple; bh=aOobQK20yua6U1wDe4oqjNjdHc04iURP9CqK2Qxb0s8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PcR3SH+BwtFlfsDhCHS4dMGh5rKLzyqy5nQPkwmxBfjcdtPblrns7k+/NuuWiIbkd/RXSkAGnLZuoyPkCxeYDokpJz0r0UcAD1xVFIeGmcc8hwtCWnFR7AJ7qbOeZGAq2jgh7L0cumFcaCoCOehnO1nVhoGk1O+3RiOrNNHKVrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IlzXNYWl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kmKg3/zR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IlzXNYWl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kmKg3/zR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FApdWH151820 for ; Mon, 15 Jun 2026 10:55:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Io1gymftJRX223MXNKXCnss6iPbXrMIBvInvnj4sz+w=; b=IlzXNYWlmbirizL8 vVPYMvIoUdW72ETny3pXNfGEc7zj6xdkb5DCEkvsrAeAnJJBXJUxh2pe3gemm9XU ksRqae1fgMncGsxBILgRbgkUpaluRddEPreM7VrewaZ03/dNKZBCXMORXH0JYYyB Bkk910+CDlIYzmuE8aLH/LN6qhNicKTr9LcZHkncyjjmCuWlwjyqnlJYSGWO3WOU x8/3yzT9azu3ADyL5DVubnJyO3CiTuExseQy2oebu63uBIs2yVGsMD7mAML7hZcm tjeP7qXrntgckCOsm4otD1ZwcicWhKjKJPS3BgpxJ99EU4rALYLQxo7NWG/uOZH2 ICB/Jw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetf0aey-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 10:55:01 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36d98b76d12so2218047a91.2 for ; Mon, 15 Jun 2026 03:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781520901; x=1782125701; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Io1gymftJRX223MXNKXCnss6iPbXrMIBvInvnj4sz+w=; b=kmKg3/zRHh8qcNX92rt+XDvicKlN6GnG4doPa/kTzFWfmSwA6ws2Bjp8UTcLaohehs D5pjFGtux2p8Re0FyC8AoDnnQv2W7baiMsh2rrZnfWqbyHGpINucSHeGXXCP5X4uxR5v 7xsEwdN8NZHmChcd91dDYlbGIhGa82/dNbG+u1KuCv06WxQeit8xXSgO7psxpFkZCO4p KRR9i5Hbst1McvBerUSQiCAo19b8x/tXgtcKPxKYB0LAfqPhaOrL/DGI9WS+oL5j+ZCH j+57/EKJIYW4b82rZO1Nk0JD3ay8upy/KdZRfynxdK0rAaICKz4JNdIIzvKkZV7j0h3U vNzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781520901; x=1782125701; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Io1gymftJRX223MXNKXCnss6iPbXrMIBvInvnj4sz+w=; b=aR/80oonaXOzAFWKzWAoJKyMtRZNw6uUbnqoKamT4bGT1E3vaYnSbQZKbYBXkngwyT ni7u+s5IN3lJ5Fryft3KGuQAHI1A6ruVTfoGccSQ+yQHaJ+Xe5a/vyhQkQxzaQ2Ex290 uH2+s04CzCEjdTqHJE9GRwAnM43PwDGhIOSEybI5KvmICDJJGYmzXOtiBLebv7aYIcSM FtVU8Nty9+c5ChZ9bfTVHX8CmIkcyK5yfpOM7plVaicc672M8Ke0wAsg5Wk56WrgQsty +1Y4jK5XAKipLU7s6hF2pKURnLDxj5ctzNytYm9jofjx235HpucQ7UGpUXsYRBTSrA0p CsEQ== X-Forwarded-Encrypted: i=1; AFNElJ9pxJ9vysGldQSi37wpoay/22iMTp6e1YsmC6hJx3fH8aKF/F3Xrq5A/2pY5M3Eggfd+LbANGrx/vP++fs=@vger.kernel.org X-Gm-Message-State: AOJu0YwXX72tYUjYWYmtXzMv5UqgS4kzHYGCfiA5W+E7/1eZ/hPG/TiP hm324NeXOHOG94KquRcSICZHb+aub4vaRE6viTMVXcpkBjK9X1C2arsLs6IJbcbXjhqongZJwL8 CzanjY1l0n0nB2yUUIUQOxk/vKTzW7AtyvEioCqNTiNXQWd5phqhoeacNF8yFgiIJgKA= X-Gm-Gg: Acq92OF/P1HY221gLR3gYERBgVih5OvAps1JeF8VdoZykI6pW+NKQJGOq6QelLIfg/V fhh9rFbApPuBO/evd4fJa6k6PD6FDs+bnCES8N/anVpW77UijpS3aUuQfw34CeXmbowi0EcVOyt VBeQfmTHt+RHsLsWFAQqlEPbQx7Hg7h6ChNeHs5SoUWbVHGEUiKKW1f5TSUAWaBkb05mTjVGK+C yNKRJp+xSF8gcVAFOma7T2yDDwI0AFOYkfg57BUu0c+XHx27fSk0dvm6cGXXn48Iq7UKie87IxV XJ2yDhtyUvFO3ma58xHctBNbvkwfD1EyuLGaIL8bzAmE4J0K7OpIw2cbzIBK6NnOFEDOCrr/vRD Eu/KYy/w7EcnHSL2uSpPaDfkihOzGc41aAJzCcSGyztyVWlQyO7ybG2k= X-Received: by 2002:a17:90b:48cd:b0:368:9da3:c496 with SMTP id 98e67ed59e1d1-37a0497dc45mr14457447a91.24.1781520900641; Mon, 15 Jun 2026 03:55:00 -0700 (PDT) X-Received: by 2002:a17:90b:48cd:b0:368:9da3:c496 with SMTP id 98e67ed59e1d1-37a0497dc45mr14457432a91.24.1781520900191; Mon, 15 Jun 2026 03:55:00 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37a212ab3d0sm12470200a91.16.2026.06.15.03.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 03:54:59 -0700 (PDT) Message-ID: <4d8d8c44-6611-4333-9906-580b70235a51@oss.qualcomm.com> Date: Mon, 15 Jun 2026 16:24:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/4] soc: qcom: geni-se: Keep pinctrl active for multi-owner controllers From: Mukesh Savaliya To: Bjorn Andersson Cc: viken.dadhaniya@oss.qualcomm.com, andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, Frank.Li@kernel.org, konradybcio@kernel.org, dmitry.baryshkov@oss.qualcomm.com, linmq006@gmail.com, quic_jseerapu@quicinc.com, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, krzysztof.kozlowski@oss.qualcomm.com, bartosz.golaszewski@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com References: <20260423145705.545552-1-mukesh.savaliya@oss.qualcomm.com> <20260423145705.545552-4-mukesh.savaliya@oss.qualcomm.com> <9a0a2ba2-4f1b-425d-979b-fe59192bb2cd@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <9a0a2ba2-4f1b-425d-979b-fe59192bb2cd@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=adxRWxot c=1 sm=1 tr=0 ts=6a2fda05 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=LqfbpYqSe3J_4supPSgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: RrLP7jfYCL1jDS5gJfFlK0lb36ptaZzC X-Proofpoint-ORIG-GUID: RrLP7jfYCL1jDS5gJfFlK0lb36ptaZzC X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDExNCBTYWx0ZWRfX9KzR+Iv0vpfb WREghW5IbDxjp/Sm6mfFijpFJNURrneY6Jt6guPlczWNS1XTqFtogZnamssp+eoEu0qH2x+jFtF sc2t2RB6jB5FtK2oWvAnUW6hMpA9HXo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDExNCBTYWx0ZWRfX+HGXIdZtJB1B KuL7Cm7zSjCLU1muzD8+enIUpH60nOptbcx8rwdIXMVUhBIrjeOVgSiE7VO445wMvT2JAgq1Usf bLri648COrlr5xmFUGOUQioxTk06fO4ngXLYOs3zjd5BhV5uxGKUsHAesPQd7suMDyZBZJY66KJ 5M5fN0oCZIcfzbnoMUtYVKbke+XnEcvwymwPDxNNWdCVvaLlOB/uw5zFJkekbPnDrg6SkqIRCdV PevcJCWKQAyL3cI9oHCttsYujhV/dw+YfB2clr184+jaZ+AoSnoJXdIsLPaJLHvrAUMoOrLF2V0 rtXW9UAWLKfLEeNqvSZPrScFQuPxGJX50hti2G8WTKovajVGA+HC8KFt7DiDFKth8vBpCGLaFMz JdNvFe5EXK/lYMWMSVEk/g4B1EemIE6CyKRPCGsSu93mGstLj5mtodFwaJL29OXWYU+a/XdaDGC oHOD4FwdskpY4qQhaeQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150114 Hi Bjorn, Please help next with the approach, accordingly i shall update next patch. On 5/25/2026 12:46 PM, Mukesh Savaliya wrote: > Hi Bjorn, Thanks for the detailed review. > > On 5/22/2026 8:36 AM, Bjorn Andersson wrote: >> On Thu, Apr 23, 2026 at 08:25:50PM +0530, Mukesh Kumar Savaliya wrote: >>> On platforms where a GENI Serial Engine is shared with another system >>> processor, selecting the "sleep" pinctrl state can disrupt ongoing >>> transfers initiated by the other processor. >>> >> >> Isn't it strange that the DeviceTree will define a sleep state for the >> OS to select, but when this other property is set the OS should never >> select this state? >> > > The intent here is that for multi-owner configurations the > “sleep” pinctrl state is not safe to use, since the pins may > still be actively driven by another execution environment. > Selecting the sleep state in such cases can disrupt transfers > initiated by the other owner. > > You're right that this constraint is currently not described > in the binding, which makes the behavior non-obvious. > > shall i update the DT binding to clarify that when > "qcom,qup-multi-owner" is present ? The OS must not transition > the pins to the "sleep" state, as the hardware is shared and > may be active outside of Linux control. > > Alternatively, we can also consider relaxing the requirement > to define a sleep state for such nodes if that aligns better > with DT expectations. > >>> Teach geni_se_resources_off() to skip selecting the pinctrl sleep state >>> when the Serial Engine is marked as shared, while still allowing the >>> rest of the resource shutdown sequence to proceed. >>> >>> This is required for multi-owner configurations (described via >>> DeviceTree >>> with qcom,qup-multi-owner on the protocol controller node). >>> >> >> The requirement as such is reasonable, but you don't define in the >> binding that when this property is set, the sleep state must not be >> selected by the OS... >> > > Please let me know if you prefer second approach over the first, i shall > update accordingly. > >> Regards, >> Bjorn >> >>> Reviewed-by: Konrad Dybcio >>> Signed-off-by: Mukesh Kumar Savaliya >>> --- > [...] >