From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbdECOlB (ORCPT ); Wed, 3 May 2017 10:41:01 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:32781 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbdECOkz (ORCPT ); Wed, 3 May 2017 10:40:55 -0400 Subject: Re: [PATCHv3 2/3] drm/prime: Introduce drm_gem_prime_import_platform To: Chris Wilson , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sumit Semwal , intel-gfx@lists.freedesktop.org, Joonas Lahtinen References: <1493744528-25768-1-git-send-email-labbott@redhat.com> <1493744528-25768-3-git-send-email-labbott@redhat.com> <20170502202213.GI19680@nuc-i3427.alporthouse.com> <20170503073945.44j65kon3f4xatll@phenom.ffwll.local> From: Laura Abbott Message-ID: <4d8dc485-2688-d46b-270c-fcb71833e893@redhat.com> Date: Wed, 3 May 2017 07:40:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170503073945.44j65kon3f4xatll@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2017 12:39 AM, Daniel Vetter wrote: > On Tue, May 02, 2017 at 09:22:13PM +0100, Chris Wilson wrote: >> On Tue, May 02, 2017 at 10:02:07AM -0700, Laura Abbott wrote: >>> /** >>> + * drm_gem_prime_import_platform - alternate implementation of the import callback >>> + * @dev: drm_device to import into >>> + * @dma_buf: dma-buf object to import >>> + * >>> + * This is identical to drm_gem_prime_import except the device used for dma_buf >>> + * attachment is an internal platform device instead of the standard device >>> + * structure. The use of this function should be limited to drivers that do not >>> + * set up an underlying device structure. >>> + */ >>> +struct drm_gem_object *drm_gem_prime_import_platform(struct drm_device *dev, >> >> Simpler soluation will be for the caller to provide the platformdev? >> >> That works nicely for the vgem case, I think. > > Yeah looking at this again, do we really need this patch? Couldn't we > instead change patch 1 to first allocate the fake platform device, then > pass that to drm_dev_alloc (instead of NULL like we do now)? > That was what I proposed in the first version and it was rejected. It's useful to have at least one driver with a NULL device for testing edge cases. > That way no resurrection of drm_device.platform_dev is needed (and I'd > really like this zombie to stay dead on 2nd thought). > I had a hunch this would be unpopular but I figured it was worth a shot. I think an even cleaner solution is to allow passing of any struct device. I'll see about reworking this. > Sry about this yet-another-round review :-/ > -Daniel > Thanks for your patience. Laura