Re: [PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl

["Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>]

On Jan 4, 2008 2:23 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:
>
> > > i.e. take the implicit assignment out of the condition. (it's easy
> > > to mistake it for '==' while reviewing the code and forgetting about
> > > the assignment's side-effect)
> >
> > OK, thanks.
> >
> > Is the following correct?
> >
> > Before:
> >  if (!(entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)))
> >
> > After:
> > entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)
> > if (!entry)
> >
> > BTW, how can i compile only the profile.c file?
>
> make kernel/profile.o

Thanks.

> > I would like to verify that my changes (now I'm at total: 2 errors, 1
> > warnings, 599 lines checked) doesn't impact on the compiled code?
>
> check out:
>
>  http://people.redhat.com/mingo/misc/q-size-obj-compare
>
> which does a size and md5 comparison. (assuming your patch is in a quilt
> queue) But if you reorder symbols (due to the EXPORT_SYMBOL moving) the
> md5 might differ. (but size should still be the same)

I'm not using quilt but git.

Unfortunatelly size changed:
paolo@paolo-desktop:/tmp$ size profile.o
   text    data     bss     dec     hex filename
   3718     144      12    3874     f22 profile.o
paolo@paolo-desktop:/tmp$ size profile.o.after
   text    data     bss     dec     hex filename
   3693     144      12    3849     f09 profile.o.after

I'll post the patch for review in a minute.

Thanks.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/