From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: mingo@helte.hu, "Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] profile: further Codying Style fixes
Date: Fri, 4 Jan 2008 20:48:59 +0330 [thread overview]
Message-ID: <4d8e3fd30801040918m4b928eebmb37e2bce5425715@mail.gmail.com> (raw)
In-Reply-To: <20080104171326.GA31382@uranus.ravnborg.org>
On 1/4/08, Sam Ravnborg <sam@ravnborg.org> wrote:
> > @@ -408,9 +406,8 @@ void profile_hits(int type, void *__pc, unsigned int
> nr_hits)
> > pc = ((unsigned long)__pc - (unsigned long)_stext) >> prof_shift;
> > atomic_add(nr_hits, &prof_buffer[min(pc, prof_len - 1)]);
> > }
> > -#endif /* !CONFIG_SMP */
> > -
> > EXPORT_SYMBOL_GPL(profile_hits);
> > +#endif /* !CONFIG_SMP */
>
> The symbol is now not exported for non-SMP builds which is a change in
> functionality.
> And thats not acceptable for pure clean-up patches.
Right, i'll update the patch.
Thanks Sam.
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
next prev parent reply other threads:[~2008-01-04 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 14:25 Paolo Ciarrocchi
2008-01-04 17:13 ` Sam Ravnborg
2008-01-04 17:18 ` Paolo Ciarrocchi [this message]
2008-01-04 14:28 Paolo Ciarrocchi
2008-01-06 10:25 ` Ingo Molnar
2008-01-06 10:58 ` Paolo Ciarrocchi
2008-01-06 13:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8e3fd30801040918m4b928eebmb37e2bce5425715@mail.gmail.com \
--to=paolo.ciarrocchi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@helte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®