mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Alexey Dobriyan" <adobriyan@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	"Ingo Molnar" <mingo@elte.hu>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: [PATCH 4/5] x86: coding style fixes in arch/x86/ia32/ia32_binfmt.c
Date: Tue, 8 Jan 2008 21:14:22 +0100	[thread overview]
Message-ID: <4d8e3fd30801081214v43294520h36e2da6df2bb3fe2@mail.gmail.com> (raw)
In-Reply-To: <20080108200250.GC4627@martell.zuzino.mipt.ru>

On Jan 8, 2008 9:02 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >  static void elf32_init(struct pt_regs *regs)
> >  {
> > -     struct task_struct *me = current;
> > +     struct task_struct *me = current;
> >       regs->rdi = 0;
> >       regs->rsi = 0;
> >       regs->rdx = 0;
> >       regs->rcx = 0;
> >       regs->rax = 0;
> > -     regs->rbx = 0;
> > -     regs->rbp = 0;
> > +     regs->rbx = 0;
> > +     regs->rbp = 0;
> >       regs->r8 = regs->r9 = regs->r10 = regs->r11 = regs->r12 =
> > -             regs->r13 = regs->r14 = regs->r15 = 0;
> > -    me->thread.fs = 0;
> > +             regs->r13 = regs->r14 = regs->r15 = 0;
> > +    me->thread.fs = 0;
> >       me->thread.gs = 0;
> > -     me->thread.fsindex = 0;
> > +     me->thread.fsindex = 0;
> >       me->thread.gsindex = 0;
> > -    me->thread.ds = __USER_DS;
> > +    me->thread.ds = __USER_DS;
>
> No re-indenting those 4-spaced lines? I mean if you're in CodindStyle
> compliance business driving from 99 to 99.9 percents please do it well
> at least.

Neither checkpatch.pl nor my .vimrc triggered those lines :-/

If Ingo wants to apply the patch I'll update it.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/

      reply	other threads:[~2008-01-08 20:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 19:32 Paolo Ciarrocchi
2008-01-08 20:02 ` Alexey Dobriyan
2008-01-08 20:14   ` Paolo Ciarrocchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d8e3fd30801081214v43294520h36e2da6df2bb3fe2@mail.gmail.com \
    --to=paolo.ciarrocchi@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®