mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Dmitri Vorobiev" <dmitri.vorobiev@gmail.com>
Cc: "Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Ingo Molnar" <mingo@elte.hu>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2
Date: Sun, 27 Jan 2008 23:38:59 +0100	[thread overview]
Message-ID: <4d8e3fd30801271438k1a71f2f3j3d0a2969f1c834be@mail.gmail.com> (raw)
In-Reply-To: <479D067E.3010100@gmail.com>

On Jan 27, 2008 11:32 PM, Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:
[..]
>
> Is there any point in changing code inside the #if 0/#endif block?

Just to avoid checkpatch complaints :-)

> > @@ -76,10 +74,10 @@ void Un_impl(void)
> >  /*
> >     Called for opcodes which are illegal and which are known to result in a
> >     SIGILL with a real 80486.
> > -   */
> > +*/
> >  void FPU_illegal(void)
> >  {
> > -  math_abort(FPU_info,SIGILL);
> > +  math_abort(FPU_info, SIGILL);
> >  }
> >
> >
> > @@ -88,61 +86,69 @@ void FPU_printall(void)
> >  {
> >    int i;
> >    static const char *tag_desc[] = { "Valid", "Zero", "ERROR", "Empty",
> > -                              "DeNorm", "Inf", "NaN" };
> > +                                     "DeNorm", "Inf", "NaN" };
>
> Umm... Why?

I'll remove it.

Thanks.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/

  reply	other threads:[~2008-01-27 22:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 22:15 Paolo Ciarrocchi
2008-01-27 22:32 ` Dmitri Vorobiev
2008-01-27 22:38   ` Paolo Ciarrocchi [this message]
2008-01-27 22:42   ` Ingo Molnar
2008-01-27 22:48     ` Paolo Ciarrocchi
2008-01-27 23:57       ` Paolo Ciarrocchi
2008-01-28  0:20         ` Dmitri Vorobiev
2008-01-28 10:44           ` Ingo Molnar
2008-01-28 11:00             ` Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d8e3fd30801271438k1a71f2f3j3d0a2969f1c834be@mail.gmail.com \
    --to=paolo.ciarrocchi@gmail.com \
    --cc=dmitri.vorobiev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®