From: "Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com>
To: "Benny Halevy" <bhalevy@panasas.com>
Cc: "Andy Whitcroft" <apw@shadowen.org>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Change a WARN message in checkpatch
Date: Sun, 24 Feb 2008 19:14:13 +0100 [thread overview]
Message-ID: <4d8e3fd30802241014g503c78a2wc08bd1939657802b@mail.gmail.com> (raw)
In-Reply-To: <47C18AAB.7050503@panasas.com>
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote:
[...]
> How about:
> - WARN("no space between function name and open parenthesis '('\n" . $herecurr);
> + WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
I originally suggested:
+ WARN("don't put a space between
function name and open parenthesis '('\n" . $herecurr);
but I really prefer your version.
> The original phrasing can be interpreted like "there is no space between ..." and the correct
> interpretation should be "there should be no space between ..."
Indeed.
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
next prev parent reply other threads:[~2008-02-24 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 22:29 Paolo Ciarrocchi
2008-01-28 14:56 ` Andy Whitcroft
2008-01-28 15:13 ` Paolo Ciarrocchi
2008-02-23 13:38 ` Paolo Ciarrocchi
2008-02-24 15:18 ` Benny Halevy
2008-02-24 18:14 ` Paolo Ciarrocchi [this message]
2008-02-25 3:29 ` Andy Whitcroft
2008-02-25 5:47 ` Benny Halevy
2008-02-25 6:51 ` Paolo Ciarrocchi
2008-02-25 10:53 ` Andy Whitcroft
-- strict thread matches above, loose matches on Subject: below --
2008-01-04 12:45 Paolo Ciarrocchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8e3fd30802241014g503c78a2wc08bd1939657802b@mail.gmail.com \
--to=paolo.ciarrocchi@gmail.com \
--cc=apw@shadowen.org \
--cc=bhalevy@panasas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®