From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757471AbZBPO21 (ORCPT ); Mon, 16 Feb 2009 09:28:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755112AbZBPO2R (ORCPT ); Mon, 16 Feb 2009 09:28:17 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:29163 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754568AbZBPO2P (ORCPT ); Mon, 16 Feb 2009 09:28:15 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=rYnsWRa7Shm7QrRjah7aI8IJMPekI3HjM3tLbQl6fgX5LfR2Ymf3a8f0kuzlH/oMkc V5HhUiD5dHnCLlpEnXzYRZJCaTR8Dku47r9cYYcxVF7O9RcO/bpWpDzRsvpH7kPKXrIE Lzr2p6omZHD/9XSOuN1zmFVs3DWkh7bqQdwuU= MIME-Version: 1.0 In-Reply-To: <20090216132822.GC17996@elte.hu> References: <20090215184752.GA4970@uranus.ravnborg.org> <4999650C.6030700@s5r6.in-berlin.de> <20090216132822.GC17996@elte.hu> Date: Mon, 16 Feb 2009 15:28:13 +0100 Message-ID: <4d8e3fd30902160628r353ba4d5wbe540afcd91c0c83@mail.gmail.com> Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c From: Paolo Ciarrocchi To: Ingo Molnar Cc: Stefan Richter , Sam Ravnborg , Manish Katiyar , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 16, 2009 at 2:28 PM, Ingo Molnar wrote: > > * Stefan Richter wrote: > >> On 2/15/2009 7:47 PM, Sam Ravnborg wrote: >> > On Mon, Feb 16, 2009 at 12:04:36AM +0530, Manish Katiyar wrote: >> >> Hi Ingo, >> >> >> >> I used your code-quality script to do cleanup in kernel/kallsyms.c. >> >> Below patch removes errors generated by checkpatch.pl. >> > When doing so use checkpatch only as a hint generator and do >> > not concentrate only on the warnings/errors generated by checkpatch. >> > >> > Your patch is an improvement but please fix the remaining issues. >> >> Furthermore, the changelog is bad (non-exiting in fact). >> >> The fact that the issues where discovered using checkpatch is absolutely >> uninteresting. The changelog should describe /what/ is fixed, e.g. >> whitespace, maybe other things. (In case of nontrivial changes the log >> may also need to explain not only the /what but also the /how/, but this >> does not apply to patches like this one.) > > The commit log definitely needs enhancements but it's not uninteresting > at all what tools were used to arrive to a change. It shouldnt be in the > title, but can be mentioned in the changelog itself. (and should be > mentioned if the cleanup ever gets as far as the mainline kernel - if a > good and acceptable commit results out of a tool's usage then that tool > needs to be advertised some more.) I think it's a good idea to add some information to the changelog explaining that the patch is not going to modify the gcc binary output. Something like: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=20211e4d344729f4d4c93da37a590fc1c3a1fd9b Ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/ http://mypage.vodafone.it/