From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 16/19] ASoC: tlv320aic31xx: Add short circuit detection support
Date: Fri, 1 Dec 2017 09:32:12 -0600 [thread overview]
Message-ID: <4d956cbc-829c-0d81-2980-aa2a79f36660@ti.com> (raw)
In-Reply-To: <20171201133930.xzfjjj6wzkbtk6c4@sirena.org.uk>
On 12/01/2017 07:39 AM, Mark Brown wrote:
> On Wed, Nov 29, 2017 at 03:32:57PM -0600, Andrew F. Davis wrote:
>
>> +static irqreturn_t aic31xx_irq(int irq, void *data)
>> +{
>> + struct aic31xx_priv *aic31xx = (struct aic31xx_priv *)data;
>
> There is no need to cast away from void, doing so can only mask bugs.
>
>> + ret = regmap_read(aic31xx->regmap, AIC31XX_INTRDACFLAG, &value);
>> + if (ret) {
>> + dev_err(dev, "Failed to read interrupt mask: %d\n", ret);
>> + return IRQ_NONE;
>> + }
>> +
>> + if (value & AIC31XX_HPLSCDETECT)
>> + dev_err(dev, "Short circuit on Left output is detected\n");
>> + if (value & AIC31XX_HPRSCDETECT)
>> + dev_err(dev, "Short circuit on Right output is detected\n");
>> +
>> + return IRQ_HANDLED;
>
> This will report the interrupt as handled even if we didn't see an
> interrupt we understand which will break shared interrupt lines. At the
> very least we should log other interrupt sources numerically.
>
Okay, I think I can make that work by checking if no bits are set in the
interrupt regs and returning early if not, IRQ_NONE.
>> + if (aic31xx->irq > 0) {
>> + regmap_update_bits(aic31xx->regmap, AIC31XX_GPIO1,
>> + AIC31XX_GPIO1_FUNC_MASK,
>> + AIC31XX_GPIO1_INT1 <<
>> + AIC31XX_GPIO1_FUNC_SHIFT);
>
> Is the interrupt only available on GPIO1?
>
Some devices can route this to GPIO2 IIRC.
I'm not sure how that would be supported, I think we would need to add
interrupt names to DT so users could specify which gpio they wired their
IRQ lines to.
interrupt = <&host 23>;
interrupt-name = "gpio2";
or similar?
next prev parent reply other threads:[~2017-12-01 15:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 21:32 [PATCH v2 00/19] Add Headphone Detection to TLV320AIC31xx Driver Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 01/19] ASoC: tlv320aic31xx: File header and copyright cleanup Andrew F. Davis
2017-11-30 12:29 ` Mark Brown
2017-11-29 21:32 ` [PATCH v2 02/19] ASoC: tlv320aic31xx: Change aic31xx_power_off return type to void Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 03/19] ASoC: tlv320aic31xx: Move ACPI table next to OF table Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 04/19] ASoC: tlv320aic31xx: General source formatting cleanup Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 05/19] ASoC: tlv320aic31xx: Fix GPIO1 register definition Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 06/19] ASoC: tlv320aic31xx: Reformat header file using GENMASK and BIT macros Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 07/19] ASoC: tlv320aic31xx: Merge init function into probe Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 08/19] ASoC: tlv320aic31xx: Switch GPIO handling to use gpiod_* API Andrew F. Davis
2017-12-04 16:47 ` Andrew F. Davis
2017-12-05 21:23 ` Andrew F. Davis
2017-12-06 12:46 ` Mark Brown
2017-11-29 21:32 ` [PATCH v2 09/19] ASoC: tlv320aic31xx: Remove platform data Andrew F. Davis
2017-12-01 13:26 ` Mark Brown
2017-12-05 21:20 ` Andrew F. Davis
2017-12-06 12:45 ` Mark Brown
2017-12-06 16:19 ` Andrew F. Davis
2017-12-06 17:30 ` Mark Brown
2017-12-06 17:48 ` Andrew F. Davis
2017-12-06 18:15 ` Mark Brown
2017-12-06 18:40 ` Andrew F. Davis
2017-12-06 19:11 ` Mark Brown
2017-12-06 19:15 ` Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 10/19] ASoC: tlv320aic31xx: Add MICBIAS off setting Andrew F. Davis
2017-12-01 13:30 ` Mark Brown
2017-12-01 14:56 ` Andrew F. Davis
2017-12-01 17:43 ` Mark Brown
2017-11-29 21:32 ` [PATCH v2 11/19] ASoC: tlv320aic31xx: Check clock and divider before division Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 12/19] ASoC: tlv320aic31xx: Add CODEC clock slave support Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 13/19] ASoC: tlv320aic31xx: Fix inverted BCLK handling Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 14/19] ASoC: tlv320aic31xx: Remove regulator notification handling Andrew F. Davis
2017-12-01 13:36 ` Mark Brown
2017-12-01 15:01 ` Andrew F. Davis
2017-12-01 15:55 ` Mark Brown
2017-11-29 21:32 ` [PATCH v2 15/19] ASoC: tlv320aic31xx: Reset registers during power up Andrew F. Davis
2017-12-01 13:37 ` Mark Brown
2017-12-01 15:04 ` Andrew F. Davis
2017-12-01 15:55 ` Mark Brown
2017-11-29 21:32 ` [PATCH v2 16/19] ASoC: tlv320aic31xx: Add short circuit detection support Andrew F. Davis
2017-12-01 13:39 ` Mark Brown
2017-12-01 15:32 ` Andrew F. Davis [this message]
2017-12-01 15:57 ` Mark Brown
2017-12-06 17:15 ` Andrew F. Davis
2017-12-06 20:22 ` Andrew F. Davis
2017-12-07 12:03 ` Mark Brown
2017-12-07 15:37 ` Andrew F. Davis
2017-12-07 17:23 ` Mark Brown
2017-11-29 21:32 ` [PATCH v2 17/19] ASoC: tlv320aic31xx: Add overflow " Andrew F. Davis
2017-11-29 21:32 ` [PATCH v2 18/19] ASoC: tlv320aic31xx: Add headphone/headset detection Andrew F. Davis
2017-12-01 13:41 ` Mark Brown
2017-12-06 17:25 ` Andrew F. Davis
2017-12-06 17:32 ` Mark Brown
2017-12-06 17:47 ` Andrew F. Davis
2017-12-06 17:52 ` Mark Brown
2017-11-29 21:33 ` [PATCH v2 19/19] ASoC: tlv320aic31xx: Add button press detection Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d956cbc-829c-0d81-2980-aa2a79f36660@ti.com \
--to=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®