From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751305AbdBWUsS (ORCPT ); Thu, 23 Feb 2017 15:48:18 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33220 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbdBWUsP (ORCPT ); Thu, 23 Feb 2017 15:48:15 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B913B60715 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH v2] arm64: Fix the kernel panic() on QDF2400 platform To: Shanker Donthineni , Catalin Marinas Cc: Will Deacon , linux-kernel , linux-arm-kernel , Mark Rutland , James Morse , Vikram Sethi References: <1487880125-1371-1-git-send-email-shankerd@codeaurora.org> From: Timur Tabi Message-ID: <4d97310a-4b91-07ac-1ce0-faacb8da03b0@codeaurora.org> Date: Thu, 23 Feb 2017 14:46:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: <1487880125-1371-1-git-send-email-shankerd@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2017 02:02 PM, Shanker Donthineni wrote: > The commit 38fd94b0275c 'arm64: Work around Falkor erratum 1003' has > been added to fix the hardware bug but causing a system crash. The "causes" > value of the register x1 which contains 'struct mm_struct *' should > be preserved inside macro pre_ttbr0_update_workaround. The subject line seems a bit vague and alarmist to me. In my opinion, this is more descriptive: arm64: qcom: pre_ttbr0_update_workaround should not clobber register x1 -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.