From: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Arnd Bergmann <arnd@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] gcov: shut up missing prototype warnings for internal stubs
Date: Fri, 28 Jul 2023 10:45:44 +0200 [thread overview]
Message-ID: <4d9a0771-6331-c25b-333e-320879a826ea@linux.ibm.com> (raw)
In-Reply-To: <20230725123042.2269077-1-arnd@kernel.org>
On 25.07.2023 14:23, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcov uses global functions that are called from generated code,
> but these have no prototype in a header, which causes a W=1
> build warning:
>
> kernel/gcov/gcc_base.c:12:6: error: no previous prototype for '__gcov_init' [-Werror=missing-prototypes]
> kernel/gcov/gcc_base.c:40:6: error: no previous prototype for '__gcov_flush' [-Werror=missing-prototypes]
> kernel/gcov/gcc_base.c:46:6: error: no previous prototype for '__gcov_merge_add' [-Werror=missing-prototypes]
> kernel/gcov/gcc_base.c:52:6: error: no previous prototype for '__gcov_merge_single' [-Werror=missing-prototypes]
>
> Just turn off these warnings unconditionally for the two files
> that contain them.
>
> Link: https://lore.kernel.org/all/0820010f-e9dc-779d-7924-49c7df446bce@linux.ibm.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested successfully with GCC 13.1 and Clang 18. Thanks for the fix!
Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Andrew, could you add this patch via your tree?
> ---
> kernel/gcov/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/gcov/Makefile b/kernel/gcov/Makefile
> index 16f8ecc7d8821..ccd02afaeffb4 100644
> --- a/kernel/gcov/Makefile
> +++ b/kernel/gcov/Makefile
> @@ -3,4 +3,6 @@ ccflags-y := -DSRCTREE='"$(srctree)"' -DOBJTREE='"$(objtree)"'
>
> obj-y := base.o fs.o
> obj-$(CONFIG_CC_IS_GCC) += gcc_base.o gcc_4_7.o
> +CFLAGS_gcc_base.o += -Wno-missing-prototypes -Wno-missing-declarations
> obj-$(CONFIG_CC_IS_CLANG) += clang.o
> +CFLAGS_clang.o += -Wno-missing-prototypes -Wno-missing-declarations
--
Peter Oberparleiter
Linux on IBM Z Development - IBM Germany R&D
prev parent reply other threads:[~2023-07-28 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 12:23 Arnd Bergmann
2023-07-28 8:45 ` Peter Oberparleiter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9a0771-6331-c25b-333e-320879a826ea@linux.ibm.com \
--to=oberpar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®