mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Farber, Eliav" <farbere@amazon.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Rahul Tanwar <rtanwar@maxlinear.com>,
	<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <farbere@amazon.com>
Subject: Re: [PATCH] dt-bindings: hwmon: moortec, mr75203: fix multipleOf for coefficients
Date: Wed, 12 Jul 2023 14:58:14 +0300	[thread overview]
Message-ID: <4d9a0899-145e-3223-41da-b91b81afaaa2@amazon.com> (raw)
In-Reply-To: <20230712081124.110345-1-krzysztof.kozlowski@linaro.org>

On 7/12/2023 11:11 AM, Krzysztof Kozlowski wrote:
> Few coefficients use default values multiple of 100, not 1000 (in the
> example DTS and in the Linux driver):
>
>  moortec,mr75203.example.dtb: pvt@e0680000: moortec,ts-coeff-g:0:0: 
> 61400 is not a multiple of 1000

Why isn't multiple of 1000 correct?
According to the Moortec datasheet for the series 6 of the temperature 
sensor
the coefficients are:
G = 57.4 (57.4 * 1000 = 57400)
H = 249.4
For series 5 coefficients are:
G = 60 (60 * 1000 = 60000)
H = 200
J = -0.1

> Fixes: bf1fdafdbc61 ("dt-bindings: hwmon: (mr75203) add coefficient 
> properties for the thermal equation")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/hwmon/moortec,mr75203.yaml          | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git 
> a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml 
> b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index ae4f68d4e696..bd67cfee6d19 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -105,7 +105,7 @@ properties:
>       G coefficient for temperature equation.
>       Default for series 5 = 60000
>       Default for series 6 = 57400
> -    multipleOf: 1000
> +    multipleOf: 100
>     minimum: 1000
>     $ref: /schemas/types.yaml#/definitions/uint32
>
> @@ -114,7 +114,7 @@ properties:
>       H coefficient for temperature equation.
>       Default for series 5 = 200000
>       Default for series 6 = 249400
> -    multipleOf: 1000
> +    multipleOf: 100
>     minimum: 1000
>     $ref: /schemas/types.yaml#/definitions/uint32
>
> @@ -131,7 +131,7 @@ properties:
>       J coefficient for temperature equation.
>       Default for series 5 = -100
>       Default for series 6 = 0
> -    multipleOf: 1000
> +    multipleOf: 100
>     maximum: 0
>     $ref: /schemas/types.yaml#/definitions/int32
>
> -- 
> 2.34.1
>

  reply	other threads:[~2023-07-12 11:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12  8:11 [PATCH] dt-bindings: hwmon: moortec,mr75203: " Krzysztof Kozlowski
2023-07-12 11:58 ` Farber, Eliav [this message]
2023-07-12 12:07   ` [PATCH] dt-bindings: hwmon: moortec, mr75203: " Krzysztof Kozlowski
2023-07-14 20:45 ` [PATCH] dt-bindings: hwmon: moortec,mr75203: " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d9a0899-145e-3223-41da-b91b81afaaa2@amazon.com \
    --to=farbere@amazon.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=rtanwar@maxlinear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®