From: Guenter Roeck <linux@roeck-us.net>
To: "Sebastián Peyrott" <speyrott@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/1] hwmon: Add Minisforum UM780 XTX EC monitoring and fan control
Date: Fri, 28 Aug 2026 09:02:29 -0700 [thread overview]
Message-ID: <4da32bd6-5b54-4765-b5ad-82bac2bbaaa2@roeck-us.net> (raw)
In-Reply-To: <20260825184107.355980-1-speyrott@gmail.com>
On 8/25/26 11:41, Sebastián Peyrott wrote:
> Add a DMI-gated hwmon driver for both fans on the Minisforum UM780 XTX. The
> EC is an ITE IT5571E, but its register layout and OEM commands are defined
> by machine-specific firmware, so the driver only binds to the exact board
> revision and BIOS version on which it was tested.
>
> The driver exposes both fan-control temperatures and tachometers, two OEM
> automatic CPU fan profiles, and two writable system-fan transition
> temperatures. It preserves settings selected through its interface across
> s2idle.
>
> Tested on the target system with concurrent RPM reads, OEM profile changes,
> system-fan threshold changes, unload/reload stress, and s2idle resume. The
> settings were correct from the first userspace sample after resume and
> remained stable for 15 seconds.
>
> OpenAI Codex assisted with reverse-engineering review, code editing, test
> orchestration, and patch and email preparation across a long interactive
> session. I reviewed every change, ran the live tests on the target
> hardware, and take responsibility for the submission.
>
> Link: https://lore.kernel.org/r/20260818181345.203295-1-speyrott@gmail.com
>
> Sebastián Peyrott (1):
> hwmon: Add Minisforum UM780 XTX EC monitoring and fan control
>
Note: For a single patch, an introduction patch is unnecessary and just adds
work for the maintainer.
Guenter
> ---
> Changes in v3:
> - return -EIO after bounded RPM coherence retries and -ENODATA for an
> unknown CPU profile;
> - seed saved settings at probe, update them only after successful hwmon
> writes, and restore them at resume without reading the EC at suspend;
> - clarify saved-state naming, live threshold validation, and resume
> documentation.
>
> Documentation/hwmon/index.rst | 1 +
> Documentation/hwmon/minisforum-um780xtx.rst | 68 +++
> MAINTAINERS | 7 +
> drivers/hwmon/Kconfig | 16 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/minisforum-um780xtx.c | 501 ++++++++++++++++++++
> 6 files changed, 594 insertions(+)
> create mode 100644 Documentation/hwmon/minisforum-um780xtx.rst
> create mode 100644 drivers/hwmon/minisforum-um780xtx.c
>
>
> base-commit: 75f2c0b3690702c90863c2e138cb5520670845ea
prev parent reply other threads:[~2026-08-28 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 18:41 Sebastián Peyrott
2026-08-25 18:41 ` [PATCH v3 1/1] " Sebastián Peyrott
2026-08-27 4:15 ` kernel test robot
2026-08-28 16:02 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da32bd6-5b54-4765-b5ad-82bac2bbaaa2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=speyrott@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®