From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m19731113.qiye.163.com (mail-m19731113.qiye.163.com [220.197.31.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508FC197A7D for ; Fri, 24 Jul 2026 01:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.113 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784855976; cv=none; b=S/s6yUb1jWbJPFa0JJdfaRx8Vi20/ygfdmVOREWfDTD/wW2clEOX1qumhX2Ov/ZczsFjF/Dold9fMlQoTAoaK3S4b8/phGuYlmsXH4JGKXEBLjdC8hQpkRdIpf7/3rlhFPfcUEqLn6glXZKTbuAqJtcy5iFxIYjCD0GRzKr88rQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784855976; c=relaxed/simple; bh=3Q7Qyd3lR21mmjz1Xg723hyiZBHD6BpMDlhFqStMRgA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=G9CT6QoxP7YsdzV9z5QpA0voERGNRhx4GKLGQ6ATwjR0RiyZK7eX7ALaMA8C74crtyzkTw8BQ4PqIwVnZaYReBEbYpehtuZ1fMaRDh1dh8m5O0ZtmPzdfVerQWS0A1HGfaWXfVUHR2h1y6NGnx5kx/lXKL9ZPXqmwgv7yVNU7RY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=SQFrAqiF; arc=none smtp.client-ip=220.197.31.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="SQFrAqiF" Received: from [172.16.12.74] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 47615be98; Fri, 24 Jul 2026 09:14:12 +0800 (GMT+08:00) Message-ID: <4da7a328-5293-498c-ac9b-b1a5a80c543b@rock-chips.com> Date: Fri, 24 Jul 2026 09:14:12 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] drm/bridge: analogix_dp: Remove redundant dev_err() To: Pan Chuang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Heiko Stuebner , "open list:DRM DRIVERS" , open list References: <20260723131649.134127-1-panchuang@vivo.com> <20260723131649.134127-2-panchuang@vivo.com> Content-Language: en-US From: Damon Ding In-Reply-To: <20260723131649.134127-2-panchuang@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9f91afe99303a8kunm3116b8eb41f44 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZTk1JVhgfQk4aGU1OGh0ZQ1YVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=SQFrAqiFjWbUn8Yv2MqV8jHKGso8eKSvKPHbmXVQIObg/QuIcAjqDmaHZU7bUEmBoL/C0b+bT2CLLs8qNzyVTsxJ+29NnxHhWGBJuQ/RNh26V09Z0Fgj26cl/i+xA1JPTfAgsLdANLC7w7VYMFKcNNqOozTagwhJJzsFK5Axsf4=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=Q/a0rPbMmtzdFvdHKbeP9Sovpw899SkE2AtTwIfPmro=; h=date:mime-version:subject:message-id:from; Hi Pan, On 7/23/2026 9:16 PM, Pan Chuang wrote: > Since commit > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), > devm_request_threaded_irq() automatically logs detailed error messages on > failure. Remove the now-redundant driver-specific dev_err() call. > > Signed-off-by: Pan Chuang > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 30c0c0b41d5a..566f1e5eb8cd 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1414,10 +1414,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) > analogix_dp_hardirq, > analogix_dp_irq_thread, > irq_flags, "analogix-dp", dp); > - if (ret) { > - dev_err(&pdev->dev, "failed to request irq\n"); > + if (ret) > return ERR_PTR(ret); > - } > > dp->aux.name = "DP-AUX"; > dp->aux.transfer = analogix_dpaux_transfer; Reviewed-by: Damon Ding