From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B01B535A397 for ; Mon, 13 Apr 2026 08:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776070093; cv=none; b=M2ciFm4WWFUEzLjS1eNBMF9TmEKcLR5CX3hkvFRJs1qVLZ5Kip9dQ8CSdoTYGQjoybUQJg5vvBnPG+FAlokBHd+XrszWTQjpgzNZEAh7agxDTDXLwzJ4Ek24LARpSslAVUOi94/OyRMsvfYYFsXTxvu6sM2G0N/BZf8SMht+/rY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776070093; c=relaxed/simple; bh=evRO0PQwMkxKIu649eD/iqI+4CsDeCsGaBZiEEguRB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TMyXNxlwPpT9lAAIuU6iLtwPApilaKvc6Gcy4Mz57dIDP28spkgOrdqBdBL3KYIugKD6miEFWVk7JChqis7Uny2eiKH1QZ1nApxiyvCiPbbRGWwKdaFPVz31dWbHqD4kaeQ1y41bRk73aGHwUf42ywM0GmejfLABxl2EH4eQHII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XX9GWbI3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dNkWFeoi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XX9GWbI3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dNkWFeoi" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63D5CeaJ3560421 for ; Mon, 13 Apr 2026 08:48:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gOH7c8WdaSQxakxnVC67pQDyVDyLKRgH4/csJfymxE0=; b=XX9GWbI3pcPEMwpz 0v5SAxbIi2V8OVpOdQTpzM4MyYw2sgOpLRSV0RPJmFWDcWEybgb94sOQphK3vDe6 iO42Q+tTGO3drt+SPwnPgR5YG5z6g9GM0B/IG+RwHgCUd3CUyMOZoH7+vesl2vuD xbOTPucktEXO8D6jD4tn3ousq5/S3g3q6SizreER/Ctyd2ctLGjC+40JsoZerCmp aXUbL/6sPMmMNl52HUMYGwsrj88B0xM0nbtdFjt5qmPOm0evRTc8cRH0fC+Tqv33 uRotn0iVDGoAjN+O21FV5aUA563pdPNEE2Da+bYUSgWzyck++EaMSFv6CyDhuzWy yevyiw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dffb0mfbk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Apr 2026 08:48:12 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50b33a19837so12721731cf.3 for ; Mon, 13 Apr 2026 01:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776070091; x=1776674891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gOH7c8WdaSQxakxnVC67pQDyVDyLKRgH4/csJfymxE0=; b=dNkWFeoich0LqQ5q/DEXa10nq5JSR5gayOBXNDcYKq8uWiiMevRR0Mu0J7BnQ7Xf8F pblmx45sEex+y3pEMkSl9af9/tovgu2CmcpmkuFr6SWRbwydLNJlmXaiHTHaOBD2+Y9k ZcwfrTLCzN3Y+OOwM2Nr8Mt5uim5ljFOIg1tmP/532vwxYoJW3L15VLmzH5XNt+AgVmf Mk8dZTjYv3sBRUJspGDMjkoFN2Jd8J3KqtIoHk8Gp6agl4UVWG8NijT3Wsf2Riyw5U42 rj/iLVf1fUC6w1hfONZdYqN4kVM4E597gFnwWUdAkROL7dBmlF8hRsSkHpTC71HF67Gh uDuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776070091; x=1776674891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gOH7c8WdaSQxakxnVC67pQDyVDyLKRgH4/csJfymxE0=; b=fRDrsn8Lqta7z4NrRL1e8LHRyKhIAV1+At9VpzYY1i3CHyv0bQt6M03Gn2zskd+G1T 2jVu4ygTcvHxfCE/Zq6stdMqSrv4b5XAiwDZI47PksBHz0x1v2XiAuJj5aT/5GTlPTza A+NhcxFakhC5BcJDL7spqvJJKyAy0Ot6Qoos10I4zwvBc4OWccIqcI1Z0sKd9FtHZVk2 0EKoPx+4BNuTLNa7BUQbgrSMNUoltTth9kpIZ4TIYYWKhR/lUD17u1UoZz3Z9rz9Az1G 13ycz/mv9GEQI1uGPEYrJYbHUwYhzes+YCjAKqVvPm1H+fqtpZ3qa4F4F9R/AsSVafrM asow== X-Forwarded-Encrypted: i=1; AFNElJ8IVTYAKfsB7qYGIsY44OGCFCnqfRBxhmF667TU6Zio6y+G3hSgu9GrYX2ImKL1n1VGnuhvWxEf1M0oAeY=@vger.kernel.org X-Gm-Message-State: AOJu0YzbAqaWhByNhBPLhE1twOX8ysRcJ2oeOQr8aLcMa5aUk+kr5Fy9 wy8vfkPlr8BVBiuLshDyQ3JXztQrCJX2IGS5A3gZOSPcuMfDLcN8Jgi7JEUQ+6mLTNgJrt5g5wL O5fIJjksClaNCumdZE6BXpSkynNoYLiOVAxnwca5tAKOyz+UV45EAEx6mV4HELeGKm7w= X-Gm-Gg: AeBDiev1fIXrXEiGDLB5fBDhMh7pZt20bb3Vri7qJeCUim5pi92ggn0dTfXLFKdUT0k QHqUNxJW0ngpW98ssVKB7vcUDxG2Zp/+xT8u6DW/UvuTQiWO9/IWkQjflSdntWv96vQ/Dk2L6Qp AB0ClUJlhjU00U0GYaPvdQKIWQoAhFXKpj/NaZ7GOX9xKHh2Jiu3HfqGf49zkB4q1pltZcz5QpO zJhMyyGVArDOI5d1XN2qoJ3/hxGvLDMAL9AypF1EDLaHUBDzbGXea8KpSpx6a4cyROixrEtApG3 cD5CslDaPb6KtnHCEqY4Wfywxm1vxsknIvnA7EhgOk7KRfqKdO2LpdcbCvj9G2oT4A7nmVDetQc +opZWSF2gTkIH+XIuJwUhdLso0RJ58tittZg3rUjNBd3KcBhfRTDHE0yNqcvgXEfwQT8YnU1tEF Z7eXU= X-Received: by 2002:a05:622a:34f:b0:50d:aa1f:68be with SMTP id d75a77b69052e-50dd5bf0dabmr134540541cf.4.1776070091018; Mon, 13 Apr 2026 01:48:11 -0700 (PDT) X-Received: by 2002:a05:622a:34f:b0:50d:aa1f:68be with SMTP id d75a77b69052e-50dd5bf0dabmr134540341cf.4.1776070090595; Mon, 13 Apr 2026 01:48:10 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-670702eec4fsm2328099a12.6.2026.04.13.01.48.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 01:48:09 -0700 (PDT) Message-ID: <4dafae66-1ef1-404c-854c-b72d3313f5af@oss.qualcomm.com> Date: Mon, 13 Apr 2026 10:48:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] clk: qcom: clk-rpmh: Make all VRMs optional by default To: Alexander Koskovich , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260412-clk-rpmh-vrm-opt-v1-0-37c890c420ff@pm.me> <20260412-clk-rpmh-vrm-opt-v1-2-37c890c420ff@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260412-clk-rpmh-vrm-opt-v1-2-37c890c420ff@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=YfmNIQRf c=1 sm=1 tr=0 ts=69dcadcc cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=U7PIyejKuas9lMDveZEA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDA4NSBTYWx0ZWRfX+T4G3a4HJbfb DGQLSZxg4DFjzwi/8UV3pWRA6vNYGeHWMw87pg763n6DFMcFRkgbLppsJl16jtJhu9hAoMLyxvE V1nro4FAeEes4yuCeO4GT6qTfCBIcYpAx4MfnVtcSsueQ6/TozBaBdERtuKhGffTabupIqathpQ zkLyl1cKARyzZlDuwGBLdBKjA33fGEK86kaxCLQBOeERX4Rgil3ynqRXRaQN2VvBgRc/eD9lAOl L5GpEd5ZEPicXzbLptMcnngpCjInuAcXJvPhWU0RvJL6dVy9tcJh5JrWIE1K5oI7rHKvitPlx8D /Opw9eICYvdHgMJfLmlloTUk1It12YeEngKxOO7w+vcIS/MGlw3D8yV5swyyaOFqVIJLiWF8su2 18SidiMw3E6f9TH2JFfsRhVHr9cWgIqyWQrpb8Uc+Nh2mgftNPrz4bB/05TsoPZqZVfU1dMyIBw 73CFzOMNUSCn60oIL2A== X-Proofpoint-ORIG-GUID: gkud-jWG7biT8pzwOkj315FHfcfcl5Dt X-Proofpoint-GUID: gkud-jWG7biT8pzwOkj315FHfcfcl5Dt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130085 On 4/12/26 5:30 PM, Alexander Koskovich wrote: > Some VRMs aren't present on all boards, so mark them as optional. This > prevents probe failures on boards where not all VRMs are present. > > This mirrors the downstream approach for this issue. > > Signed-off-by: Alexander Koskovich > --- [...] > @@ -976,6 +982,11 @@ static int clk_rpmh_probe(struct platform_device *pdev) > rpmh_clk = to_clk_rpmh(hw_clks[i]); > res_addr = cmd_db_read_addr(rpmh_clk->res_name); > if (!res_addr) { > + hw_clks[i] = NULL; > + > + if (rpmh_clk->optional) > + continue; if (rpmh_clk->offset == CLK_RPMH_VRM_EN_OFFSET)? That would let you drop the rest of the patch. This also needs some additional background.. I would assume this comes from a slightly different HW (PMIC) configuration Could you please do `grep ^ /sys/kernel/debug/qcom_socinfo/*`, (perhaps censoring your serial number)? Konrad