From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613E82DF68 for ; Tue, 8 Jul 2025 01:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751936707; cv=none; b=ZDHYLBDRUSwJJWN05QGdAExcLVQdYIuc6BVkH5wPnDnej/5y/gsYw0YrhTVvuhDSjZe/OZpdW9Dy8BKR+bikr+2WWLzimceMIRh4V8uol8zaAmgcxll+hXPxIhBtAobDLHV6bNx6rdbMGymxa2ue87NfeijTmX5fMUEiZuUdt10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751936707; c=relaxed/simple; bh=i84yZfnml941z8sD89nX4ooEHdytXw1Osqc2CBQFlo0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S0gcF3C7gAxGoN7U03LppUHkbyaq6jVCvHr07IAAQCJYxnrZ0+NU9xDtdpK51DUz/XwT5PmyvXe9dS7z1BOcfKysjGogI/qQyQry3v9t75oYmYrpJ6B+kU4oA9g8LWIk5THGtD6sx2PgZg2rXf0E54P6UbX0v+ZlinCicu5hedU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rvQs8R1f; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rvQs8R1f" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-b34a6d0c9a3so3807650a12.3 for ; Mon, 07 Jul 2025 18:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751936705; x=1752541505; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fces0U4vBTah/txjkL1uaWJbDbXttpdltEcQXNSodqI=; b=rvQs8R1feLI21gzOEhABwtIdi+FIEix9MCZftO8F/g311g3qjPrGS/1lrZxlSFeXPu qQtWjLHHYnQNqgV7ohcaQCqu+clcmIkhC2I4nFZ2oVtf/UYGiHR7uHKUIVe/MhjQJEVJ 5r028Kl9BNouk+RUYlkELtrY1+y+xY7fGtjD1u01iH0YXvBejzfdg8+mydk+/jBgTqg0 8yRGGltSuTnahWG62ZmrnKnwLr4BQH9NPtmNqgmsu5hhirmX7UhyGlMLIGbCJ+bLKuPx j+d2obkdQoGjW1ojq8/KRBR4eboU3miLeKeoG5xhZKCL7ZHRnSJ4ZvMFRc3PbdEi4ZKs DnWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751936705; x=1752541505; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fces0U4vBTah/txjkL1uaWJbDbXttpdltEcQXNSodqI=; b=XpPZXbkN4O7rNTw3apShwpxrLvjzDW/NOq1dcOt0ixCDrK/MiuApIVwTMWIaYk1dBq daJRTA9U5Pj4ydU7NF+jzIbMh/rQkd6orTwhnLLVC7jD3CTa4DRRRk2j+y5CprGGgeoM +c7ugW47FPzvTKrfc1C1VucsDXWKZLkuzXMHEM7m2+6YmV0i70Z9ba1zkifg/zePcNGs BG1xwzijjPnV+6rAMBUjYBa3UclBPL1Z1jkDVVBX84IvQ9kgQEQlrft9EVUo8Fuqe2yi VYc3Ra3lBmz+SMIxkYzd4wJRx/u9IoRhzmQaeNZe66krx6e3PC/MhfqSFpodITD8C3nV JeuA== X-Forwarded-Encrypted: i=1; AJvYcCVgDHiNE5hd6vmt2NCS6HxCgQfZlaeCqKDgYSudPcIpME5zVy40N3bBt+WoemEvJP0/zm73c6Kll9kbqG8=@vger.kernel.org X-Gm-Message-State: AOJu0YyfmtMEtwe9GwnhO5tE/2zcwTd3rbKmLB6GSKEn2bQkO90UH/+/ siGz/7V4x6aS7jOgE3CAj91HIr7Qf0b3ByLB7m96n0PzoM+CyRha2Xz/P3XjMO+mJQ== X-Gm-Gg: ASbGncsTzB68ZyEU46GW4ccNGEZ6PQ+bmtGTPI0ziCTDw3hD/std9xXyi483/GlR28E TQQuKTFvKgI56ypQTlFJbbYqBWfVUcrZD2iKRI6zYdSaydA+MGL4F0J89niCyvbty4b6dfpNus3 oN6amrNetMEhriB50VaDg4biAla3T7xJl6Z27AM9+NJOQoiI/iMR21LsHRcCYR+ThPhrYqe+IXB ROTi1wbPNd59B7+eyNwiyt0f28sd6Jlh2qfQS1v/209Y4lBgCwUAPNDlhqQWIASGzzshRP0A6G0 iPO4lJkJxlpsSMAhsmf51I2b18EuHyP6b++n0Qur3nnrDvOWHxx4rBaWvS1t1Gjh+t/b8rVqOoB 7XpFDg1Gxu4E3SKoMTH8OANOXrZTZyWCkKKeH9YHJjZ+f2GRFJBu9Gzxy8AP52oEZujMw1Rw= X-Google-Smtp-Source: AGHT+IGLNKYmGe1JyOgmsT56Z5FG9Cik3JHHYN0Bra0/4AUj+wLy8xc/9t+rwkpUYrPvw07PkZPv4w== X-Received: by 2002:a17:90b:57c7:b0:311:ffe8:20e6 with SMTP id 98e67ed59e1d1-31aac432932mr20537013a91.3.1751936705207; Mon, 07 Jul 2025 18:05:05 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e14:7:990d:1c2a:935c:f693? ([2a00:79e0:2e14:7:990d:1c2a:935c:f693]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c220bfbe3sm524860a91.46.2025.07.07.18.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jul 2025 18:05:04 -0700 (PDT) Message-ID: <4dba5e10-9a8d-45bb-b1cb-8b4d563e7f97@google.com> Date: Mon, 7 Jul 2025 18:05:03 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] power: supply: core: add vendor and product id properties To: Sebastian Reichel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Kyle Tso , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org References: <20250507-batt_ops-v2-0-8d06130bffe6@google.com> <20250507-batt_ops-v2-4-8d06130bffe6@google.com> <5zjoseyepm3tnqbwrh77liwuuqgmghn4kcj43urnk7z4yrttlx@yqqpnnlifdk5> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <5zjoseyepm3tnqbwrh77liwuuqgmghn4kcj43urnk7z4yrttlx@yqqpnnlifdk5> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Sebastian, On 6/23/25 2:44 PM, Sebastian Reichel wrote: > Hi, > > On Wed, May 07, 2025 at 06:00:25PM -0700, Amit Sunil Dhamne via B4 Relay wrote: >> From: Amit Sunil Dhamne >> >> Add the following properties: >> * Vendor Identifier (VID): Assigned to the battery manufacturer by USB >> Implementers Forum (USB-IF). >> * Product Identifier (PID) assigned by the manufacturer to the >> battery. >> >> This info is required by USB Type-C PD devices containing batteries. >> This enables the USB Type C devices to respond to a Battery capacity >> request from the port partner by querying for the PID & VID assigned to >> the batteries. Refer to "USB Power Delivery Specification Rev3.1 v1.8" >> Chapter 5.5 Battery_Capabilities Message. >> >> Signed-off-by: Amit Sunil Dhamne >> --- >> Documentation/ABI/testing/sysfs-class-power | 19 +++++++++++++++---- >> Documentation/power/power_supply_class.rst | 11 +++++++++++ >> drivers/power/supply/power_supply_sysfs.c | 2 ++ >> include/linux/power_supply.h | 2 ++ >> 4 files changed, 30 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power >> index 2a5c1a09a28f91beec6b18ca7b4492093026bc81..5495e82885b2294cdfd5ace0e7e5fcbeadfccb5f 100644 >> --- a/Documentation/ABI/testing/sysfs-class-power >> +++ b/Documentation/ABI/testing/sysfs-class-power >> @@ -814,11 +814,22 @@ Description: >> Access: Read >> Valid values: 1-31 >> >> -What: /sys/class/power_supply//extensions/ >> -Date: March 2025 > Why does this remove existing Documentation? Oops. I think that probably happened while resolving merge conflicts  I guess. Will fix. > >> +What: /sys/class/power_supply//usbif_vendor_id > I think we can use USB_VENDOR_ID and USB_PRODUCT_ID for this like > everyone else? Agreed. > >> +Date: May 2025 >> Contact: linux-pm@vger.kernel.org >> Description: >> - Reports the extensions registered to the power supply. >> - Each entry is a link to the device which registered the extension. >> + Reports the vendor id assigned to the battery manufacturer by USB >> + Implementers Forum (USB-IF). >> >> Access: Read >> + Valid values: 0x0-0xffff > If I haven't missed something the formatting will be in decimal. I > think the hex format is more sensible, so this needs some extra > handling in power_supply_format_property() in power_supply_sysfs.c. I see. I will add special handling for these in power_supply_format_property(). > >> + >> +What: /sys/class/power_supply//usbif_product_id >> +Date: May 2025 >> +Contact: linux-pm@vger.kernel.org >> +Description: >> + Reports the product id assigned to the battery by the manufacturer >> + (associated with usbif_vendor_id). >> + >> + Access: Read >> + Valid values: 0x0-0xffff >> diff --git a/Documentation/power/power_supply_class.rst b/Documentation/power/power_supply_class.rst >> index da8e275a14ffb9f84bae9ae1efc4720a55ea3010..6d0a6bcf501e719fa4454845b583a8b38d371bb4 100644 >> --- a/Documentation/power/power_supply_class.rst >> +++ b/Documentation/power/power_supply_class.rst >> @@ -213,6 +213,17 @@ TIME_TO_FULL >> seconds left for battery to be considered full >> (i.e. while battery is charging) >> >> +USBIF_VENDOR_ID >> + Vendor ID (VID) assigned to manufacturer or device vendor associated with the >> + battery by USB Implementers Forum (USB-IF). This property is described in >> + "USB Power Delivery Specification Rev3.1 V1.8" Chapter 6.5.5 Battery >> + Capabilities, Section 6.5.5.1 Vendor ID (VID). >> +USBIF_PRODUCT_ID >> + Product ID (PID) assigned to the battery, such that if the VID belongs to the >> + manufacturer then the PID will be designated by it. Similarly if the VID >> + belongs to the device vendor then the PID will be designated by it. This >> + property is described in "USB Power Delivery Specification Rev3.1 V1.8" >> + Chapter 6.5.5 Battery Capabilities, Section 6.5.5.2 Product ID (PID). >> >> Battery <-> external power supply interaction >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c >> index edb058c19c9c44ad9ad97a626fc8f59e3d3735a6..534ed3cd049866fa747455bb6dae1ec2dc5e2da6 100644 >> --- a/drivers/power/supply/power_supply_sysfs.c >> +++ b/drivers/power/supply/power_supply_sysfs.c >> @@ -211,6 +211,8 @@ static struct power_supply_attr power_supply_attrs[] __ro_after_init = { >> POWER_SUPPLY_ATTR(TIME_TO_EMPTY_AVG), >> POWER_SUPPLY_ATTR(TIME_TO_FULL_NOW), >> POWER_SUPPLY_ATTR(TIME_TO_FULL_AVG), >> + POWER_SUPPLY_ATTR(USBIF_VENDOR_ID), >> + POWER_SUPPLY_ATTR(USBIF_PRODUCT_ID), >> POWER_SUPPLY_ENUM_ATTR(TYPE), >> POWER_SUPPLY_ENUM_ATTR(USB_TYPE), >> POWER_SUPPLY_ENUM_ATTR(SCOPE), >> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h >> index a35b08bd368e9305554e1a608dc8e526983cfa12..100eb559dcede938595ffbf83bc5ef3645a5a172 100644 >> --- a/include/linux/power_supply.h >> +++ b/include/linux/power_supply.h >> @@ -165,6 +165,8 @@ enum power_supply_property { >> POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG, >> POWER_SUPPLY_PROP_TIME_TO_FULL_NOW, >> POWER_SUPPLY_PROP_TIME_TO_FULL_AVG, >> + POWER_SUPPLY_PROP_USBIF_VENDOR_ID, >> + POWER_SUPPLY_PROP_USBIF_PRODUCT_ID, >> POWER_SUPPLY_PROP_TYPE, /* use power_supply.type instead */ >> POWER_SUPPLY_PROP_USB_TYPE, >> POWER_SUPPLY_PROP_SCOPE, > Neither this series, nor the Pixel 6 one seems to have any user for > these new properties? This becomes part of the kernel ABI, so we do > not add new properties without a user. I realize that there's no current driver that supplies these values atm. I plan to add it for https://lore.kernel.org/all/20250523-b4-gs101_max77759_fg-v4-0-b49904e35a34@uclouvain.be/ driver once it gets accepted. Thanks, Amit > > Greetings, > > -- Sebastian