From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A4526F47D for ; Wed, 21 Jan 2026 20:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769028086; cv=none; b=urz7QXdjA7IGKauyX2MczgtnLmeQqf4BWgC9pJ/+r2FDip8vhWOFhATf/4gegQSkPOxZ2gC1lno5u5QNPOvoWQrVpCDt73XKQ5SyNJwKcnv4nMQIF2/wt4z+2R5LSyJZJzlfdZ4wczgqtBfgIX3ERvRZX9oMMQ+ZMaeHDtIGhas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769028086; c=relaxed/simple; bh=G3acNzLE+XKGua3haS9Yxlfx4qhRbVjE8ziDWKoielA=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=DcpV2deMDrS+iPfb06S1iwiVdTJ9OOwnstfpsQYaq8vM6GFG/nqCmf6Fr5zCxoxcEDcZqvLn1dmUnHrHTjIaNM8RSo6Q5QES8ZI8j4Z+URHlOv4p4ubNpNZo80e+tJaQqXdGGiEdNEAwEUylzxaBFxK+UayESY2Fd+sf8zgVlN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CVqSmzm8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ekLJ372V; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CVqSmzm8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ekLJ372V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769028083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=djpJyuMScmlBrHd91p9Wz9+Dh8n8NY06xyptDyrXdV4=; b=CVqSmzm8WOStiAhCT8dS0RYsy8Ajt2FddUQlzRaJ5bgTxia/7YENRindXYQyMZDzgi9aW0 ScNmKm3BFv92QbwcOoRHDzyX43dWP9j63gn2qpp+ezhWt1V0nP8sJvrdolVBP+r/0Dr0kY 7PKrHK/y91iNLiTcr3uYiTL/zL9CVOQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-zNpMWqJ3PQWEzP2vZxP78A-1; Wed, 21 Jan 2026 15:41:22 -0500 X-MC-Unique: zNpMWqJ3PQWEzP2vZxP78A-1 X-Mimecast-MFC-AGG-ID: zNpMWqJ3PQWEzP2vZxP78A_1769028082 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c5329ed28bso59387485a.2 for ; Wed, 21 Jan 2026 12:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769028082; x=1769632882; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=djpJyuMScmlBrHd91p9Wz9+Dh8n8NY06xyptDyrXdV4=; b=ekLJ372VNNMFu8gBLIZLk+carP8LMT+ZnLYij+jTPRIW3gmCrPE2X+ODVNgv6fG3mg tSDBB4LID3ZePbMm5lpiLu8CKnwN6YS1s2P/e6AfGH0HHYxLjsbb6m89aWkK4Bm9hIFn cPTpfZStm5r9BDSvkVNFJ8hp/qllSicPsUTlBma2nVMqbZxE19m6okgj0NH0FSpoEGj1 dlvbohwmBfDQ7l+aRRddDI17P3eaE/QCU7OY3Sv6/xFBbtZ5A4Y5ZZoTzAkdLTW/IMM7 2xPBMkxtwEkxyvSpxg1LVm+B1Cj0OcGG741qxgkHgTBBSAC1oKENfxY2ZFcJt6fb5dQy Bgfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769028082; x=1769632882; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=djpJyuMScmlBrHd91p9Wz9+Dh8n8NY06xyptDyrXdV4=; b=D5x/0q26YlCMzvW0G2vFNnlB/TCj4l01KcIYNLs0A/Ptriwc7gjOspHCB4xHP6GprZ DPtHTFxQ5V8h0vyMvc8sAsX8OqDvfIeM7UlA9p+ZJCtypAByrunJSz2711LX2AQFGJYh t+372oc2bHV3E2AgRD4lSx1BjOReQsXhCuR2jXHWKwBusiCslKMYlv2J1wY0/YZ16ly4 Q8CZBC/DZs4XGTV8IwSXC89INIzCEgQWpUCC49+SyGoADlJEIkyw49QcniRd8f5lu0tE t82yv9ho1GQ5BsWP6SnABuvYorj0mVSQt2jZsQAQbVDZlTZtIe+P+3Y+8W/rrgOL0Ayz gZ6g== X-Forwarded-Encrypted: i=1; AJvYcCUuCHoc9obS4UGeYJ+PmSOtx4OVyKSaXl5Gn0+Xsu8aAau0ZfrDVTbSG2jPxokWGukTHJ4A6M2mt9N+4c4=@vger.kernel.org X-Gm-Message-State: AOJu0YyOMvlJlJ4DLMjfO+8clZdyK41wc2ogCHjGSA3+6jHaW0Cf9pQ4 m2RlyOyT7w7yFUVn7jGq3anKPJZG6gDcZLsxFfZ4P6uH7fTJ66jVMSQGoC9rezD6IAPFXzT1eJI XU84NJfhWvtTeivD971PzSoyFzjRxl7L2RML+oSmn160oc/d9hx1DYSEgVx+Pa3cbKw== X-Gm-Gg: AZuq6aJmQA1cbZQdVL6VWn3KfJUR1/kulrD77XRO6Won06pN0OMCDS2oUKBqEvX4/WF sQ6Gx3GyWIvEYN486plC1DRFtW1G6r4SyoVQDnafACsWPRIWkpV8/yuRzRrhO754TwCvBo5Ylp5 DNpH/zLbT5QOhkKOouV844TJm676w0ZjGTP7bGiUxY/KpmHWISjARdCsw0AiwfMwm1C7PMQ1h+m Xhwlw2/dQf4H3+UhFUas/23FVyxr8jxjxZRnpcfvHNYqC1v4qOJ050quu0HdBIqPIOU/mb+Cxmr oOBTaq1BhzOEZ8TyIB6Xj2odCgpf2E5X5+OJ7pbxhpREcmaMclbEksz7Zp9DlcGbRCBx37Ak3VO M5OEGxdM3hDwcPBsyivmqmIIj9nm12HdBnBJtIoNIifLu0v74fjjHvZcW X-Received: by 2002:a05:620a:4714:b0:8c6:a628:8608 with SMTP id af79cd13be357-8c6a66d1d82mr2524755285a.6.1769028081679; Wed, 21 Jan 2026 12:41:21 -0800 (PST) X-Received: by 2002:a05:620a:4714:b0:8c6:a628:8608 with SMTP id af79cd13be357-8c6a66d1d82mr2524752485a.6.1769028081250; Wed, 21 Jan 2026 12:41:21 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6b22bb7cbsm1036983185a.39.2026.01.21.12.41.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 12:41:20 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <4dc6ab03-b2ad-4411-a49b-4513c5d592ea@redhat.com> Date: Wed, 21 Jan 2026 15:41:19 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip/gic-v3-its: Don't acquire rt_spin_lock in allocate_vpe_l1_table() To: Marc Zyngier , Thomas Gleixner Cc: Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev References: <20260107215353.75612-1-longman@redhat.com> <864iowmrx6.wl-maz@kernel.org> <87ms2nsqju.ffs@tglx> <86wm1qlq7l.wl-maz@kernel.org> <87ecnwij44.ffs@tglx> <86v7h8l9ht.wl-maz@kernel.org> <87pl7gglya.ffs@tglx> <86tswrkrh4.wl-maz@kernel.org> <861pjjcqdi.wl-maz@kernel.org> Content-Language: en-US In-Reply-To: <861pjjcqdi.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/21/26 3:38 AM, Marc Zyngier wrote: > On Mon, 12 Jan 2026 11:20:07 +0000, > Marc Zyngier wrote: >> On Sun, 11 Jan 2026 16:20:45 +0000, >> Thomas Gleixner wrote: >>> On Sun, Jan 11 2026 at 10:38, Marc Zyngier wrote: >>>> On Sun, 11 Jan 2026 09:39:07 +0000, >>>> Thomas Gleixner wrote: >>>>> On Fri, Jan 09 2026 at 16:13, Marc Zyngier wrote: >>>>>> On Thu, 08 Jan 2026 22:11:33 +0000, >>>>>> Thomas Gleixner wrote: >>>>>>> At the point where a CPU is brought up, the topology should be known >>>>>>> already, which means this can be allocated on the control CPU _before_ >>>>>>> the new CPU comes up, no? >>>>>> No. Each CPU finds *itself* in the forest of redistributors, and from >>>>>> there tries to find whether it has some shared resource with a CPU >>>>>> that has booted before it. That's because firmware is absolutely awful >>>>>> and can't present a consistent view of the system. >>>>> Groan.... >>>>> >>>>>> Anyway, I expect it could be solved by moving this part of the init to >>>>>> an ONLINE HP callback. >>>>> Which needs to be before CPUHP_AP_IRQ_AFFINITY_ONLINE, but even that >>>>> might be to late because there are callbacks in the STARTING section, >>>>> i.e. timer, perf, which might rely on interrupts being accessible. >>>> Nah. This stuff is only for direct injection of vLPIs into guests, so >>>> as long as this is done before we can schedule a vcpu on this physical >>>> CPU, we're good. No physical interrupt is concerned with this code. >>> That's fine then. vCPUs are considered "user-space" tasks and can't be >>> scheduled before CPUHP_AP_ACTIVE sets the CPU active for the scheduler. >> Waiman, can you please give the following hack a go on your box? The >> machines I have are thankfully limited to a single ITS group, so I >> can't directly reproduce your issue. > Have you managed to try this hack? I may be able to spend some time > addressing the issue in the next cycle if I have an indication that > I'm on the right track. Yes, I have tried out your hack patch and the 2-socket Grace test system booted up without producing any bug report for a RT debug kernel. I will try out your official patch once it come out. So moving the memory allocation to a later part of the hotplug bringup pipeline where sleeping is allowed should work. Cheers, Longman