From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586DC4BC02E for ; Thu, 2 Jul 2026 14:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783000894; cv=none; b=XQ5cAtxYe77wFd0OV2qpmqL0MJ6EhaCMqtvRXUF4nbD1WPwVrT8uXMdiOUKmdyZ+5SFMgZU7vBtZKP7DF+u4Mqx/X23HsN3jmiRQKUN6wj5zYutSIBUZBrOJiICQwSx8jZOWFBqlIe0ozl7fVLpYzU8QTe8akKgybq1Ahhtdfuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783000894; c=relaxed/simple; bh=8kyNQRirnf2cKiXwYG/vWHQxapmPf4XUteIF+6/Ckms=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=A5xj3Vufq1s/szv2GLYhqSASIzLLu6Mu1/9kP8kQ8DhBUowa14qTarL499ILvsHOVkL/oLNSqWOKttcqCgNVOl3sm0ow1We4y9eqPCTv/3k2mwZTmAIAdQzVhlk4Vbj0632m2QOcVXRb26IhVAckiLqK5lWdLIcRYxET4fh+DHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Co3K6r1k; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZM8qlrYH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Co3K6r1k"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZM8qlrYH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783000892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5/yT65UjojWRzyrirEnnS2FwfXKiYApvhR4+/iODC0c=; b=Co3K6r1kGjunjRElszqX/Qm6he7q29qEKhnuVaKoygFZMBMXXRhG6aP8+fRMIsUSM6E/To dBZJEmC9olQe0F8p2Xfp9kOc7N9qKMBDtoj9pp5ZdY/8PYenOWx6DtXqOOIeKrLXCM0Q28 6TXOzK3+cf6h8HfyZmRRg5ro3y+/FRk= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-5P5jdQPkMg6UtoOZcMBd9w-1; Thu, 02 Jul 2026 10:01:30 -0400 X-MC-Unique: 5P5jdQPkMg6UtoOZcMBd9w-1 X-Mimecast-MFC-AGG-ID: 5P5jdQPkMg6UtoOZcMBd9w_1783000890 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c1273e18eebso195978866b.1 for ; Thu, 02 Jul 2026 07:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783000890; x=1783605690; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=5/yT65UjojWRzyrirEnnS2FwfXKiYApvhR4+/iODC0c=; b=ZM8qlrYHCADb34XSNUTa0KP4oIZui+YYNnuq2+mD7biagyIJ6u62LojEMx+PvCsx5/ s4KOOFNNWkVlrxq3hkSJx/PyC+hL/FcpRXYtuijfTg+0sgwFBfbB88q6tvmuhNkBZCnj LqvnS6KE7l2O2Egytc2XVzfjC27OcjkVnAX7Krm3DirqyxAjdfMXtWrJz5mtztkBpVnS Se6aifRql/Ai4qZjmvuIQB1BkU690hNzpkOvsTX4WFOLNruS8HPM/QXfJoyFaPvcL+gG pNGtIBqN0Mq+ZK+Y7BHYBfshcm1xDe5KZlSkcZ+vgmDJ6jTK9n7cCM6kqAHLWBO1lDSB nbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783000890; x=1783605690; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5/yT65UjojWRzyrirEnnS2FwfXKiYApvhR4+/iODC0c=; b=nieM7tizWE+qKmH+5XZ234+jhdHgctt8VrO9dZhNaSrrMteg2jtCx0HEqxvRppOXU1 GfbGuS2W1alvnuOrZSeTP+z4RKu9cjIo47RWJDhMhm1VKx5lNIzzrmDfiVzF4BFFHNuH cvaHyLEra3mQIoh9ls9ApFFbjHocxlfDTZlB8NSeA03evJAFD6auCjskFXyqWdEB+n6z SCHa2pkcszrresAYHk12Gmuz3QVY5YTRrRRKxsduLtuwkWVbrLaNUDl5S4IR6yckGh3P Y5Gr9ekxyoGp3oIe/R02F7HH4jzXr2u2WXd1L3aWurcf/11NyVCyWOjukt5El29PCUt9 Uwjg== X-Forwarded-Encrypted: i=1; AHgh+RoisOHLwQmc8li4MnQeukJCOsI9Q7hdcl0xm3QSTnTGyY6dsm3Dgi2d71mWvRL4tky8YbaEaCYqUAMVsfA=@vger.kernel.org X-Gm-Message-State: AOJu0YyJxcuMqGef5SoekWlw7iMhW8ac1PqO0BDM+RLpk1ytdBtE8B/l M523jm3T9DqJEMT0EJmZxtQSyp/c94TCYExgmtC+6mgBlCU6yj/LzQZ0Qu1+XleDyUutoSiDhJs jm88d1FaFvIa7K7su1rp7cY1sZlMtT+4cK6Pb/CPxHkg8+bU9kdDr/xjgnLE50tYNuw== X-Gm-Gg: AfdE7cnu6IFmcGcPmOEPYQEBz29LF7fEsOsAobbC7+uTO0PtSC9TzhnphytSP+nqhvy b5oaWmOGXTURqIe7Wjs4gMmMxq1A3FHzJCEiGuqJQUo2IbYIVxzGg9Edj84Wjct0mMaNdRK9Ml4 KYBh4u9V/0T0ctPHTw8Oz5/HJqomb97UtsFRGXr8EG5Ji1oJKz5tW1Rg1c4/HvHdqBXsgM/toeF Nh89b1UNIldCGQh0pQz3qeDNizvfe78+A6TZ5rw+xNZAGQOX1Y3vxY9Uar701xhhqw5RWVF2k8/ Eco7HmmA0AwmiYvylOROY6L8w4fmQbDPC61LTymT8KhQN1tBwhk/omxZJKsBwiaf358bLz30u9J 9Y22nG+kk6XcnUt6Y5KbKEQ7lWb+9be3WfYAMlzGjTSIOp5pKcnheVlHOWz7TGyBgA2q3ldmg91 OlFkub X-Received: by 2002:a17:907:1b1e:b0:c12:b17e:f8c with SMTP id a640c23a62f3a-c12b17e10b1mr184028866b.65.1783000886929; Thu, 02 Jul 2026 07:01:26 -0700 (PDT) X-Received: by 2002:a17:907:1b1e:b0:c12:b17e:f8c with SMTP id a640c23a62f3a-c12b17e10b1mr184007566b.65.1783000883713; Thu, 02 Jul 2026 07:01:23 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477dde19e8dsm9874217f8f.27.2026.07.02.07.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 07:01:23 -0700 (PDT) Message-ID: <4dc81b777bb8daaf4687c0d9db7ce740abd0a825.camel@redhat.com> Subject: Re: [PATCH v3 03/17] verification/rvgen: Improve rv_dir discovery in RVGenerator From: Gabriele Monaco To: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Cc: Thomas Weissschuh , Tomas Glozar , John Kacur , Wen Yang Date: Thu, 02 Jul 2026 16:01:21 +0200 In-Reply-To: <87y0ftijkw.fsf@yellow.woof> References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-4-gmonaco@redhat.com> <87y0ftijkw.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-07-02 at 15:53 +0200, Nam Cao wrote: > Gabriele Monaco writes: > > The RVGenerator class can find the RV directory (kernel/trace/rv) in th= e > > kernel tree to do some auto patching. This works by assuming PWD is > > either the kernel tree or tools/verification, which isn't always the > > case (e.g. when running from selftests). > >=20 > > Make discovery more robust by relying on the absolute path of the > > current script and traversing backwards the right number of times. > > This should work from any location if rvgen is in the kernel tree. >=20 > Agree. >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # find the kernel tree root= relative to this file's location > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 current_dir =3D os.path.dir= name(os.path.abspath(__file__)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kernel_root =3D os.path.abs= path(os.path.join(current_dir, > > "../../../..")) >=20 >=20 > The=C2=A0 "../../../.." makes me sad. >=20 > We can find the git project root instead. For example: >=20 > def getGitRoot(): > =C2=A0=C2=A0=C2=A0 return subprocess.Popen(['git', 'rev-parse', '--show-t= oplevel'], > stdout=3Dsubprocess.PIPE).communicate()[0].rstrip().decode('utf-8') >=20 > (stolen from > https://stackoverflow.com/questions/22081209/find-the-root-of-the-git-rep= ository-where-the-file-lives > ) >=20 > But that's not important, up to you. Mmh good point, but what if we're running from a tarball? I could still fall back to something that uses directory parents (maybe something arguably nicer like os.path.join(current_dir, *([".."] * 4)) But that may not be more readable.. Thanks, Gabriele