From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D22C4363A for ; Sat, 10 Oct 2020 22:58:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF26A2067C for ; Sat, 10 Oct 2020 22:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dbKFu/0x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390594AbgJJW6A (ORCPT ); Sat, 10 Oct 2020 18:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730606AbgJJTvB (ORCPT ); Sat, 10 Oct 2020 15:51:01 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21744C05BD0A for ; Sat, 10 Oct 2020 06:16:54 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id a15so12297946ljk.2 for ; Sat, 10 Oct 2020 06:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I6GLcoUpo4y0TA4rpDhzzmDcBN9KGSF4okvjQ/EzDKw=; b=dbKFu/0xJ40OfYyUCpMPFDakjxp7Gl3QQfRQVZsLYZNvGaWowfCN/6WvlDkeEAmWan jvQt5imfuiC/aVURtOcyCsXiXsq/1kbEwQpScyw2EuhftRmlh8iB2kda1PREabWBc4V2 Hz4d8KO59WUp7xGIIdoJu8CIXq1XoVwfo6KqMCrhOhEuc4go3z30AXBpfHaNTcCcXjiX cPUrkdy3K5IgGSIFp3Os75jomspfFSK3TPBFMOO4oU/6hMz1r+/kMfAuZZtsPcgKqH8F 04i+q5IQFeuNq9CKIq0sLl0nuTY82X1iLKxZmiHw9g3guAcKB663xEleDUrU93OdCBZk szTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I6GLcoUpo4y0TA4rpDhzzmDcBN9KGSF4okvjQ/EzDKw=; b=EqaWUgwT5r9D2TH/6VbygKttNONWmEUz+yY1TEEvqibBRrEdY7qU+q1Yhyc3uDxg3O l0cgHSLNEJ70L3LO9uV3JtNVDjmVMohbhSgAyLA3RREMeQAU5lLFK2fPbU3oIqu4SRql g5f/slLAIR3YU+yx9lHpTJ8tGsmI0j4kW3qzi69vXLj1O0/GfiGWaScbpez+c4RifK/4 VFcuI7LaJPKalFLEMbw96vTk9YwhoPM29SkQRo34TsaK/bPsqdlcYNJceSa3fXRhQH4Z hHPKqsZfNhof7V0fMaFbev1w5gqr6/GN+VOuBL+DHIMcSXLbBv5Gt8eeFqnzt3QmgrQP +oxQ== X-Gm-Message-State: AOAM530cx1PL7lZ9d9tSNU2cWPygQhXfkMvnvl7+JStwb+EGGEEblCFO m8svMok3M+Hhn108lav1hPpVCJ4f0C7YyKZt X-Google-Smtp-Source: ABdhPJwlXMQJxFWBfenbvdcBiEfKPnu9TbzWaGCDysOHjfEB50KaSJXJjYDYWKf6ptVKsw0kUEvQMA== X-Received: by 2002:a2e:9d8d:: with SMTP id c13mr6464279ljj.339.1602335812137; Sat, 10 Oct 2020 06:16:52 -0700 (PDT) Received: from [192.168.1.211] ([188.162.65.231]) by smtp.gmail.com with ESMTPSA id w20sm67086lfl.220.2020.10.10.06.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Oct 2020 06:16:51 -0700 (PDT) Subject: Re: [PATCH 0/3] i2c: i2c-qcom-geni: More properly fix the DMA race To: Douglas Anderson , Bjorn Andersson , Wolfram Sang , Akash Asthana Cc: linux-arm-msm@vger.kernel.org, Stephen Boyd , linux-i2c@vger.kernel.org, Andy Gross , Girish Mahadevan , Karthikeyan Ramasubramanian , Mukesh Kumar Savaliya , linux-kernel@vger.kernel.org References: <20201008225235.2035820-1-dianders@chromium.org> From: Dmitry Baryshkov Message-ID: <4dcdc8b3-94aa-8e68-934d-70542897db6a@linaro.org> Date: Sat, 10 Oct 2020 16:16:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20201008225235.2035820-1-dianders@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2020 01:52, Douglas Anderson wrote: > Previously I landed commit 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA > transfer race") to fix a race we were seeing. While that most > definitely fixed the race we were seeing, it looks like it causes > problems in the TX path, which we didn't stress test until we started > trying to update firmware on devices. > > Let's revert that patch and try another way: fix the original problem > by disabling the interrupts that aren't relevant to DMA transfers. > Now we can stress both TX and RX cases and see no problems. I also > can't find any place to put an msleep() that causes problems anymore. > > Since this problem only affects i2c, I'm hoping for an Ack from Bjorn > and then all these patches can go through the i2c tree. However, if > maintainers want to work a different way out to land that's OK too. These patches fix I2C DMA issues on SM8250 we were observing Tested-by: Dmitry Baryshkov -- With best wishes Dmitry