mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal@dev.mellanox.co.il>
To: Ghazale Hosseinabadi <ghazale.hosseinabadi@oracle.com>
Cc: linux-rdma@vger.kernel.org, tbogendoerfer@suse.de,
	matanb@mellanox.com, leonro@mellanox.com, parav@mellanox.com,
	linux-kernel@vger.kernel.org, dledford@redhat.com
Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module
Date: Fri, 27 Oct 2017 19:19:05 -0400	[thread overview]
Message-ID: <4dcf0ca6-77ff-bfd3-9f79-c114617f536f@dev.mellanox.co.il> (raw)
In-Reply-To: <9be6d049-c3fc-6cf2-8d91-4449f4bcc896@oracle.com>

On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote:
> 
> 
> On 10/27/2017 03:52 PM, Hal Rosenstock wrote:
>> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote:
>>> When running ibstat (if transceiver is not connected in adapter):
>>>
>>> ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid
>>> argument
>> Any output before that ?
> no, It only prints this line.

and setting the width to 1x in the driver so the rate file is properly
populated fixes this ? I must be missing something as to what is going
on in this scenario.

sysfs.c:rate_show is inconsistent as it paves over an invalid speed
setting that to SDR but does not pave over invalid width returning
-EINVAL but this comment is in another "direction".

-- Hal

> 
> -- Ghazale
>>   I'm trying to understand how far it gets. It
>> looks to me that empty rate file would be parsed as 0 and ibstat would
>> show that rate. ibpanic would occur if file was not found but I could be
>> missing something.
>>
> 
> 

  reply	other threads:[~2017-10-27 23:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 21:54 Ghazale Hosseinabadi
2017-10-27 22:52 ` Hal Rosenstock
2017-10-27 23:04   ` Ghazale Hosseinabadi
2017-10-27 23:19     ` Hal Rosenstock [this message]
2017-10-28  0:17       ` Hal Rosenstock
2017-10-28  0:29         ` Ghazale Hosseinabadi
2017-10-28  0:36       ` Ghazale Hosseinabadi
2017-10-28 10:42       ` Thomas Bogendoerfer
2017-10-28 11:59         ` Hal Rosenstock
  -- strict thread matches above, loose matches on Subject: below --
2017-10-27 20:35 Ghazale Hosseinabadi
2017-10-27 12:30 Thomas Bogendoerfer
2017-10-27 18:32 ` Parav Pandit
2017-10-27 20:18   ` Hal Rosenstock
2017-10-27 20:33     ` Parav Pandit
2017-10-27 21:30       ` Hal Rosenstock
2017-10-27 19:35 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dcf0ca6-77ff-bfd3-9f79-c114617f536f@dev.mellanox.co.il \
    --to=hal@dev.mellanox.co.il \
    --cc=dledford@redhat.com \
    --cc=ghazale.hosseinabadi@oracle.com \
    --cc=leonro@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matanb@mellanox.com \
    --cc=parav@mellanox.com \
    --cc=tbogendoerfer@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®