From: <Codrin.Ciubotariu@microchip.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>
Cc: <dannenberg@ti.com>, <m-stecklein@ti.com>, <afd@ti.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR()
Date: Tue, 19 Feb 2019 16:20:41 +0000 [thread overview]
Message-ID: <4de1b52b-70dc-7767-ba16-2d785d36a4c2@microchip.com> (raw)
In-Reply-To: <20190219161518.1331-1-codrin.ciubotariu@microchip.com>
On 19.02.2019 18:15, Codrin Ciubotariu - M19940 wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/codecs/pcm186x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..7947279243f9 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -6,7 +6,6 @@
> * Andreas Dannenberg <dannenberg@ti.com>
> * Andrew F. Davis <afd@ti.com>
> */
> -
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/init.h>
> @@ -42,7 +41,7 @@ struct pcm186x_priv {
> bool is_master_mode;
> };
>
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>
> static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
> SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
>
the title is wrong, there is no DECLARE_TLV_DB_LINEAR()present. Will
send v2.
Best regards,
Codrin
prev parent reply other threads:[~2019-02-19 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:15 Codrin.Ciubotariu
2019-02-19 16:15 ` [PATCH 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit Codrin.Ciubotariu
2019-02-19 16:20 ` Codrin.Ciubotariu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4de1b52b-70dc-7767-ba16-2d785d36a4c2@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannenberg@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-stecklein@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®