From: Paolo Abeni <pabeni@redhat.com>
To: Qingfang Deng <qingfang.deng@linux.dev>, netdev-bot+sashiko@kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, leitao@debian.org, norbert@doyensec.com,
hataegu0826@gmail.com, paulus@ozlabs.org,
Brice.Goglin@ens-lyon.org, akpm@osdl.org, Matt_Domsch@dell.com,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ppp: remove SC_MUST_COMP
Date: Mon, 2 Nov 2026 12:48:37 +0100 [thread overview]
Message-ID: <4de42b50-1f80-418b-94ff-95d656f08bd2@redhat.com> (raw)
In-Reply-To: <84396bab-166b-435f-9663-0aa2939de3fc@linux.dev>
On 10/31/26 02:28, Qingfang Deng wrote:
> On 10/31/2026 5:32 AM, netdev-bot+sashiko@kernel.org wrote:
>> Would it work to keep the define, with a comment that the kernel ignores
>> it and that it aliases SC_DC_ERROR, while still dropping it from
>> SC_FLAG_BITS and SC_MASK and removing the checks?
>
> I found no trace of existing users (searched GitHub). Even _if_ there are any, _and_ SC_MUST_COMP does not alias SC_DC_ERROR, the logic is still flawed - received packets are silently dropped without noticing the userspace.
>
> If the goal is to prevent the removal from backports, I may split out the removal part into a net-next patch.
I'm sorry to disagree with Simon, but I think we should not
change uAPI unless strictly required.
I would just mark `SC_MUST_COMP` as obsoleted since <revision>.
/P
prev parent reply other threads:[~2026-11-02 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 7:49 Qingfang Deng
2026-10-30 21:32 ` netdev-bot+sashiko
2026-10-31 1:28 ` Qingfang Deng
2026-10-31 17:48 ` Simon Horman
2026-11-02 11:48 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4de42b50-1f80-418b-94ff-95d656f08bd2@redhat.com \
--to=pabeni@redhat.com \
--cc=Brice.Goglin@ens-lyon.org \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hataegu0826@gmail.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=norbert@doyensec.com \
--cc=paulus@ozlabs.org \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®