From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Cc: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Mario Limonciello <mario.limonciello@amd.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] ASoC: amd: acp: Unify code style for platform_device_id array
Date: Tue, 21 Jul 2026 09:19:46 +0530 [thread overview]
Message-ID: <4de738e5-4802-4890-89a9-cfa66a15889c@amd.com> (raw)
In-Reply-To: <08137cf5b3cdd0cc2e00da32256664f3cb9b1e4e.1784528081.git.u.kleine-koenig@baylibre.com>
On 20/07/26 11:53, Uwe Kleine-König (The Capable Hub) wrote:
> [You don't often get email from u.kleine-koenig@baylibre.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> - Add a trailing comma for initializers unless the closing brace is on
> the same line and for the list terminator;
> - Use a single space in the list terminator;
>
> Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> sound/soc/amd/acp/acp-sof-mach.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sound/soc/amd/acp/acp-sof-mach.c b/sound/soc/amd/acp/acp-sof-mach.c
> index 36ecef7013b9..8874151e159a 100644
> --- a/sound/soc/amd/acp/acp-sof-mach.c
> +++ b/sound/soc/amd/acp/acp-sof-mach.c
> @@ -128,31 +128,31 @@ static int acp_sof_probe(struct platform_device *pdev)
> static const struct platform_device_id board_ids[] = {
> {
> .name = "rt5682-rt1019",
> - .driver_data = (kernel_ulong_t)&sof_rt5682_rt1019_data
> + .driver_data = (kernel_ulong_t)&sof_rt5682_rt1019_data,
> },
> {
> .name = "rt5682-max",
> - .driver_data = (kernel_ulong_t)&sof_rt5682_max_data
> + .driver_data = (kernel_ulong_t)&sof_rt5682_max_data,
> },
> {
> .name = "rt5682s-max",
> - .driver_data = (kernel_ulong_t)&sof_rt5682s_max_data
> + .driver_data = (kernel_ulong_t)&sof_rt5682s_max_data,
> },
> {
> .name = "rt5682s-rt1019",
> - .driver_data = (kernel_ulong_t)&sof_rt5682s_rt1019_data
> + .driver_data = (kernel_ulong_t)&sof_rt5682s_rt1019_data,
> },
> {
> .name = "nau8825-max",
> - .driver_data = (kernel_ulong_t)&sof_nau8825_data
> + .driver_data = (kernel_ulong_t)&sof_nau8825_data,
> },
> {
> .name = "rt5682s-hs-rt1019",
> - .driver_data = (kernel_ulong_t)&sof_rt5682s_hs_rt1019_data
> + .driver_data = (kernel_ulong_t)&sof_rt5682s_hs_rt1019_data,
> },
> {
> .name = "nau8821-max",
> - .driver_data = (kernel_ulong_t)&sof_nau8821_max98388_data
> + .driver_data = (kernel_ulong_t)&sof_nau8821_max98388_data,
> },
> { }
> };
> --
> 2.55.0.11.g153666a7d9bb
>
next prev parent reply other threads:[~2026-07-21 3:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 6:23 [PATCH v2 0/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-20 6:23 ` [PATCH v2 1/6] ASoC: codecs: mt6357: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-20 6:23 ` [PATCH v2 2/6] ASoC: renesas: fsi: Drop platform probing metadata Uwe Kleine-König (The Capable Hub)
2026-07-20 23:12 ` Kuninori Morimoto
2026-07-20 6:23 ` [PATCH v2 3/6] ASoC: amd: acp: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-21 3:48 ` Mukunda,Vijendar
2026-07-20 6:23 ` [PATCH v2 4/6] ASoC: amd: acp: Unify code style for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-20 7:05 ` Cezary Rojewski
2026-07-20 11:32 ` Uwe Kleine-König (The Capable Hub)
2026-07-21 3:49 ` Mukunda,Vijendar [this message]
2026-07-20 6:23 ` [PATCH v2 5/6] ASoC: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-20 8:23 ` Charles Keepax
2026-07-30 11:14 ` Péter Ujfalusi
2026-07-20 6:23 ` [PATCH v2 6/6] ASOC: Unify code style " Uwe Kleine-König (The Capable Hub)
2026-07-22 17:55 ` Cezary Rojewski
2026-07-23 5:30 ` Uwe Kleine-König (The Capable Hub)
2026-07-23 10:28 ` Cezary Rojewski
2026-07-27 23:12 ` [PATCH v2 0/6] ASoC: Use named initializers " Mark Brown
2026-07-30 10:42 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4de738e5-4802-4890-89a9-cfa66a15889c@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=gpiccoli@igalia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®