mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DAC960: split up ioctl function to reduce stack size
Date: Fri, 5 Jan 2018 09:41:02 -0700	[thread overview]
Message-ID: <4deb8455-a133-5fa5-0219-74323c1fdc28@kernel.dk> (raw)
In-Reply-To: <20171211121131.3921009-1-arnd@arndb.de>

On 12/11/17 5:11 AM, Arnd Bergmann wrote:
> When CONFIG_KASAN is set, all the local variables in this function are
> allocated on the stack together, leading to a warning about possible
> kernel stack overflow:
> 
> drivers/block/DAC960.c: In function 'DAC960_gam_ioctl':
> drivers/block/DAC960.c:7061:1: error: the frame size of 2240 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 
> By splitting up the function into smaller chunks, we can avoid that and
> make the code slightly more readable at the same time. The coding style
> in this file is completely nonstandard, and I chose to not touch that
> at all, leaving the unconventional intendation unchanged to make it
> easier to review the diff.

Applied, thanks Arnd.

-- 
Jens Axboe

      reply	other threads:[~2018-01-05 16:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 12:11 Arnd Bergmann
2018-01-05 16:41 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4deb8455-a133-5fa5-0219-74323c1fdc28@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®