From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C9C4C433DF for ; Thu, 28 May 2020 21:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 048552088E for ; Thu, 28 May 2020 21:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590701994; bh=yi/mRuoypw6iFv+WgE/DZiO2CFYRKIBvUB6rKHm5Urw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=1SxKJrkWhFoxPlzT/3pBbzKiF+otCjou/cGUGX8if9AqXCuWeHK3H95ailUs28BRZ YgeEvQNJsncRL3weSPPtmuEF3dm891APeAzIN/n56E+MPTzIPRXUvtQWm7xeVAcFvY u608nSpWak4SFcXTpG4h9vz3Ab29D0J/q5dmcJfY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436649AbgE1Vjx (ORCPT ); Thu, 28 May 2020 17:39:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436583AbgE1Vjv (ORCPT ); Thu, 28 May 2020 17:39:51 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45DCBC08C5C7 for ; Thu, 28 May 2020 14:39:51 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id j145so596687oib.5 for ; Thu, 28 May 2020 14:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OfpLvfnX8lVDByHQBLU++09A6lqwgIjSdFJ0GhgD8hk=; b=hIVO7OwdAzZtChKnv8phSDuayJ+63ecs/81LzyUetJxvJGcNQl0EKlode3KULfZYA0 WbFCk1e0mN5ekoaToQEaKxEZGUTfEMc2KOLVZVyXU8zETrxdHowGewLMsHqjyA90DtP5 g16TOAaa0Kr64Dyept/QTpXdV0rmAAYO+aw9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OfpLvfnX8lVDByHQBLU++09A6lqwgIjSdFJ0GhgD8hk=; b=CitBp7LfHjOzV2YhL4/yjYTSdpwG7dUF4gS2NHLX/jCc87jn7+xiFV5wq4Wtgia5Xe UAk70NV4IWFYY2Pj1kdHcC8FohCoKKPojxK13SOfBlzGTogqsBWbO+9CYG/ccCH73MV+ GMDk6ZiKUN5wj8XbPET/huWLhaINtRbEsQXlHj3VD1t9d53ajnqg3Y9rGtnkr14hP9bl 6uja0liNAfxhnm3GlbVTumnF05PzKiap4l5RG3Rp43R6QENlUwytzHqDbtZhCHkmusZ1 Wi4Q/CX41JK5JrXoN3KhKRPpSX7B4W5V2+C+yiG11pkJTO01segJyf4GBp4Ic+dDiXRY LAzQ== X-Gm-Message-State: AOAM530jg5uyRShWjz1xm7DKJ7S+U/sJHl8t87v5PQ1r/6Z3fRA7gj/i BKEWV8evGgApeTye1680OlDPH5l2Wow= X-Google-Smtp-Source: ABdhPJx1Ja1TbtJq4hRHGE828SF8s6kg5n3Pc0HsFwOSf1AlxMilKtg9NShPCTujKWJmEAj2a/LTkg== X-Received: by 2002:aca:53ca:: with SMTP id h193mr3676158oib.12.1590701990596; Thu, 28 May 2020 14:39:50 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id g10sm1251573otn.34.2020.05.28.14.39.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 14:39:49 -0700 (PDT) Subject: Re: [RFC, WIP, v6 00/10] media: vidtv: implement a virtual DVB driver To: "Daniel W. S. Almeida" , mchehab+huawei@kernel.org, sean@mess.org, kstewart@linuxfoundation.org, allison@lohutok.net, tglx@linutronix.de Cc: linux-media@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20200520070334.1778751-1-dwlsalmeida@gmail.com> From: Shuah Khan Message-ID: <4df08eaa-7a96-c769-d3ef-9cf4bae77454@linuxfoundation.org> Date: Thu, 28 May 2020 15:39:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200520070334.1778751-1-dwlsalmeida@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/20/20 1:03 AM, Daniel W. S. Almeida wrote: > From: "Daniel W. S. Almeida" > > This series is work in progress. It represents the current work done on a > virtual DVB driver for the Linux media subsystem. I am new to the media > subsystem and to kernel development in general. > > This driver aims to: > - Serve as template for new DVB driver writers > - Help userspace application writers in general > - Push fake audio/video to userspace for testing > purposes > - Push debug information to userspace via debugfs > > This should currently be able to feed PSI and PCM audio data to > userspace. > > I appreciate any feedback! > Run checkpatch --strict on these. There are several warns and an error which could improve the code as well as the improving Kconfig entry as suggested below. WARNING: please write a paragraph that describes the config symbol fully #108: FILE: drivers/media/test-drivers/Kconfig:7: +menuconfig DVB_TEST_DRIVERS I will send review comments on individual patches. thanks, -- Shuah