From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A37171DA31F for ; Mon, 6 Jan 2025 14:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736172489; cv=none; b=jEl2Du4YPz4DjF4cMQYze3vJgo4cPQq1oSgnisVNu8F3nrY4orYxiqifzv6qlf05aviUTor20oKijvcPtyy/XcZRcaYCLoISOKjZRG6EbbqGevj46LQIXS9jMlkWpTT4ZWxJTZ4h/N7MfKI/xFcxYH1JtA7B69ZUfsJikvMoVzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736172489; c=relaxed/simple; bh=mk1DitITBu6wmhsqn2nmojT+Nq4BeNVWOenXUM2lmEw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qM4Hhrzd6FdGUFK0L7WWj4wz0cADLWTp4aOn++hIW5H7EJH2RYiXaF5C00Qw8Sv6+3utokShp6dY0r/1P3pJIHS2om1MuEDYxiHddyGxM9UvKbYyZPV2JTCruQ5MpBwzbmqxHAxzz/6+YOPNCXH1BYOaSmvFT4/xozAhNm6DHnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N0MteEZP; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N0MteEZP" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43618283d48so104246865e9.1 for ; Mon, 06 Jan 2025 06:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736172485; x=1736777285; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EWT9lmpyxnN+ivmg93OmXz9oSbysfzx800Q4Ls4JS4Q=; b=N0MteEZPUuWNDfqEplcQfjSgJOEibnEPodHQGSb9WHW07ih6eXoxx5FvGokqVMchvp AJ2UMAy7TbeOfs5VEvx+peekQZP48gbY1slc48H3R8JaDYTrw4C1cM1C7DvjwW7aR3AB Lc6DMjZtn7CVqFnd+cYzzNsF5NMAq715BAUrtKZLs3Ep6n7SpxYWunSCIWvbDRAl6n2h iIxpTjlVjrx+WuosmlD+7wzBZpi4gFRMBGVBOb7Gh9QAwZy6WjAA0PyWnreqdeTKjPay CZt6wavw9ehskVNGmW70rFzKdv3iV+MJQzsc4+8MfAlWaQtFxGxD+q1zIStzlinGyIwB brGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736172485; x=1736777285; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EWT9lmpyxnN+ivmg93OmXz9oSbysfzx800Q4Ls4JS4Q=; b=nADQygtx1B30XunULjQVTs+bpRJ7qgjme+3b566pkYYAGwG0HTHHii3sJjutL5xal3 FyocHuwaPttrfXTqa7Qkz5AZv41azJdQkCT0v7kpfdXvrdnd43j9bpT8XvILPyFNO7iU +dRS3gOY6M5N/axKI/px4SyLdH7mqubtimzhVk9wvzL3c8rvk1TR276hh/lIV38bw9l/ QQYAdQZPNzRUa5WxXMwIz9kV21HwwUTtgdYI15OfV01a3PYf6NJSPDdBKYo1KFYXwb9L MqVJxUTPcGJRkEA0tgxFwdwCP5lzDX2zfVKHgoj51ldkOnvkDKe943AmkRAxZ32uOxnm RUsQ== X-Forwarded-Encrypted: i=1; AJvYcCWHwOYEM1khkqv9ffpEMuMXmJgFbx/jgDxToxc4nDXy0XlTDWMClhwKQ9U2mNeSTGyOWmbgx0pHWjskOm4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6iOwBXCByX4JG4GY5e3awmKtvRmkpaUp0JFPcVNA9BzTNP1Y6 gVXbIKIqQfYVVseSC/bK07VuYoUL0l1JhMO0SNRO0eq6rX54ARGX9CDZZD9pgaE= X-Gm-Gg: ASbGncslxyQ/USzqY++m3E005BlnJYtXiIel8B8SC4SPbiaov4Li6EsQ95+v8DSgsbT 16h0GB51AINL7phvpLRAopfv5gMpoj7MrHUdur33ivDVC9sXIvJh4kkPvusO2q3pb+gTHeEb/bN eYmPhZToM+mQTvZtAkMUfuWNpRMaNELeP54DiI2QfidFaXnmiRoenuNcWEFzAu7p3FA7r87koTj zdi327V3kfdff25JVd8VJz8hhoFDYmZKx5l6Z2MU0ZS3ZvlQRta3miY7F0jal47p9MWpA== X-Google-Smtp-Source: AGHT+IHXug5yLq0vZe9jWONZUJ9YxeEdyT8/tH+NsyQkfEAG5MJnrSgKUFKRqEqVTgqoOpnTJGzJPQ== X-Received: by 2002:a05:600c:3554:b0:434:9934:575 with SMTP id 5b1f17b1804b1-436686461d6mr509541595e9.16.1736172484915; Mon, 06 Jan 2025 06:08:04 -0800 (PST) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b442dasm600692965e9.42.2025.01.06.06.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 06:08:04 -0800 (PST) Message-ID: <4df2adac-c9d8-46f5-ad92-105b91f8ae4e@linaro.org> Date: Mon, 6 Jan 2025 14:08:03 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] media: venus: vdec: Ignore parm smaller than 1fps To: Ricardo Ribalda , Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Hans Verkuil , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , linux-arm-msm@vger.kernel.org References: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> <20250106-fix-cocci-v4-2-3c8eb97995ba@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250106-fix-cocci-v4-2-3c8eb97995ba@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2025 13:40, Ricardo Ribalda wrote: > The driver uses "whole" fps in all its calculations (e.g. in > load_per_instance()) Return -EINVAL if the user provides a parm that > will result in 0 whole fps. > > Reported-by: Hans Verkuil > Closes: https://lore.kernel.org/linux-media/f11653a7-bc49-48cd-9cdb-1659147453e4@xs4all.nl/T/#m91cd962ac942834654f94c92206e2f85ff7d97f0 > Fixes: 7472c1c69138 ("[media] media: venus: vdec: add video decoder files") > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/qcom/venus/vdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index 98c22b9f9372..25edd77b9cf9 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -481,7 +481,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC; > do_div(us_per_frame, timeperframe->denominator); > > - if (!us_per_frame) > + if (!us_per_frame || us_per_frame > USEC_PER_SEC) > return -EINVAL; > > fps = (u64)USEC_PER_SEC; > Reviewed-by: Bryan O'Donoghue