From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, "Esteban Blanc" <eblanc@baylibre.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Esteban Blanc <eblanc@baylibre.com>
Subject: Re: [PATCH v3 2/6] iio: adc: ad4030: add driver for ad4030-24
Date: Sun, 2 Feb 2025 15:30:54 +0300 [thread overview]
Message-ID: <4e0118d0-0992-4d71-8dfb-8b75c0f51a17@stanley.mountain> (raw)
In-Reply-To: <20250130-eblanc-ad4630_v1-v3-2-052e8c2d897d@baylibre.com>
Hi Esteban,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Esteban-Blanc/dt-bindings-iio-adc-add-ADI-ad4030-ad4630-and-ad4632/20250130-191153
base: ffd294d346d185b70e28b1a28abe367bbfe53c04
patch link: https://lore.kernel.org/r/20250130-eblanc-ad4630_v1-v3-2-052e8c2d897d%40baylibre.com
patch subject: [PATCH v3 2/6] iio: adc: ad4030: add driver for ad4030-24
config: um-randconfig-r071-20250202 (https://download.01.org/0day-ci/archive/20250202/202502021354.T5JOCCcy-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202502021354.T5JOCCcy-lkp@intel.com/
smatch warnings:
drivers/iio/adc/ad4030.c:263 ad4030_spi_read() warn: calling memset(x, y, ARRAY_SIZE());
vim +263 drivers/iio/adc/ad4030.c
8cfce061c9e580 Esteban Blanc 2025-01-30 242 static int ad4030_spi_read(void *context, const void *reg, size_t reg_size,
8cfce061c9e580 Esteban Blanc 2025-01-30 243 void *val, size_t val_size)
8cfce061c9e580 Esteban Blanc 2025-01-30 244 {
8cfce061c9e580 Esteban Blanc 2025-01-30 245 int ret;
8cfce061c9e580 Esteban Blanc 2025-01-30 246 struct ad4030_state *st = context;
8cfce061c9e580 Esteban Blanc 2025-01-30 247 struct spi_transfer xfer = {
8cfce061c9e580 Esteban Blanc 2025-01-30 248 .tx_buf = st->tx_data,
8cfce061c9e580 Esteban Blanc 2025-01-30 249 .rx_buf = st->rx_data.raw,
8cfce061c9e580 Esteban Blanc 2025-01-30 250 .bits_per_word = 8,
8cfce061c9e580 Esteban Blanc 2025-01-30 251 .len = reg_size + val_size,
8cfce061c9e580 Esteban Blanc 2025-01-30 252 .speed_hz = AD4030_SPI_MAX_REG_XFER_SPEED,
8cfce061c9e580 Esteban Blanc 2025-01-30 253 };
8cfce061c9e580 Esteban Blanc 2025-01-30 254
8cfce061c9e580 Esteban Blanc 2025-01-30 255 if (xfer.len > ARRAY_SIZE(st->tx_data) ||
These ARRAY_SIZE() checks work fine before ->tx_data is a u8 but really
is should be sizeof().
8cfce061c9e580 Esteban Blanc 2025-01-30 256 xfer.len > ARRAY_SIZE(st->rx_data.raw))
Same.
8cfce061c9e580 Esteban Blanc 2025-01-30 257 return -EINVAL;
8cfce061c9e580 Esteban Blanc 2025-01-30 258
8cfce061c9e580 Esteban Blanc 2025-01-30 259 ret = ad4030_enter_config_mode(st);
8cfce061c9e580 Esteban Blanc 2025-01-30 260 if (ret)
8cfce061c9e580 Esteban Blanc 2025-01-30 261 return ret;
8cfce061c9e580 Esteban Blanc 2025-01-30 262
8cfce061c9e580 Esteban Blanc 2025-01-30 @263 memset(st->tx_data, 0, ARRAY_SIZE(st->tx_data));
^^^^^^^^^^^^^^^^^^^^^^^
same.
8cfce061c9e580 Esteban Blanc 2025-01-30 264 memcpy(st->tx_data, reg, reg_size);
8cfce061c9e580 Esteban Blanc 2025-01-30 265
8cfce061c9e580 Esteban Blanc 2025-01-30 266 ret = spi_sync_transfer(st->spi, &xfer, 1);
8cfce061c9e580 Esteban Blanc 2025-01-30 267 if (ret)
8cfce061c9e580 Esteban Blanc 2025-01-30 268 return ret;
8cfce061c9e580 Esteban Blanc 2025-01-30 269
8cfce061c9e580 Esteban Blanc 2025-01-30 270 memcpy(val, &st->rx_data.raw[reg_size], val_size);
8cfce061c9e580 Esteban Blanc 2025-01-30 271
8cfce061c9e580 Esteban Blanc 2025-01-30 272 return ad4030_exit_config_mode(st);
8cfce061c9e580 Esteban Blanc 2025-01-30 273 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-02 12:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 11:08 [PATCH v3 0/6] iio: adc: ad4030: new driver for AD4030 and similar ADCs Esteban Blanc
2025-01-30 11:08 ` [PATCH v3 1/6] dt-bindings: iio: adc: add ADI ad4030, ad4630 and ad4632 Esteban Blanc
2025-01-30 11:08 ` [PATCH v3 2/6] iio: adc: ad4030: add driver for ad4030-24 Esteban Blanc
2025-01-31 5:40 ` kernel test robot
2025-01-31 18:14 ` Jonathan Cameron
2025-02-04 12:54 ` Esteban Blanc
2025-02-02 12:30 ` Dan Carpenter [this message]
2025-01-30 11:08 ` [PATCH v3 3/6] iio: adc: ad4030: add averaging support Esteban Blanc
2025-01-31 18:18 ` Jonathan Cameron
2025-02-03 9:54 ` Uwe Kleine-König
2025-01-30 11:08 ` [PATCH v3 4/6] iio: adc: ad4030: add support for ad4630-24 and ad4630-16 Esteban Blanc
2025-01-30 11:08 ` [PATCH v3 5/6] iio: adc: ad4030: add support for ad4632-16 and ad4632-24 Esteban Blanc
2025-01-30 11:08 ` [PATCH v3 6/6] docs: iio: ad4030: add documentation Esteban Blanc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0118d0-0992-4d71-8dfb-8b75c0f51a17@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eblanc@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®