From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <monstr@monstr.eu>,
Josh Cartwright <josh.cartwright@ni.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Rob Herring <robherring2@gmail.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Russell King <linux@arm.linux.org.uk>,
Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Stephen Warren <swarren@nvidia.com>,
James Hogan <james.hogan@imgtec.com>,
Felipe Pena <felipensp@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: zynq: Move of_clk_init from clock driver
Date: Wed, 5 Feb 2014 07:41:28 -0800 [thread overview]
Message-ID: <4e03e3ec-2fc7-40fc-a2cc-4a6c64379559@CO1EHSMHS025.ehs.local> (raw)
In-Reply-To: <572af6e4eaaaa1c74ea62364f8fa7ac5834cc754.1391612175.git.michal.simek@xilinx.com>
On Wed, Feb 05, 2014 at 03:56:37PM +0100, Michal Simek wrote:
> Move of_clk_init() from clock driver to enable
> options not to use zynq clock driver.
> Use for example fixed clock setting.
What is the use-case? Zynq w/o this driver makes no sense, IMHO. And
even if you wanna fake clocks, why would this driver prevent it? Just
replace all the input clocks with different ones and don't care about
what this driver does?
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Based on http://www.spinics.net/lists/arm-kernel/msg298287.html
> series
>
> ---
> arch/arm/mach-zynq/common.c | 1 +
> drivers/clk/zynq/clkc.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c
> index 93ea19b..8df35f3 100644
> --- a/arch/arm/mach-zynq/common.c
> +++ b/arch/arm/mach-zynq/common.c
> @@ -68,6 +68,7 @@ static void __init zynq_timer_init(void)
> zynq_early_slcr_init();
>
> zynq_clock_init();
> + of_clk_init(NULL);
Now you have two clock init functions...
Sören
next prev parent reply other threads:[~2014-02-05 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 14:56 Michal Simek
2014-02-05 15:41 ` Sören Brinkmann [this message]
2014-02-05 15:52 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e03e3ec-2fc7-40fc-a2cc-4a6c64379559@CO1EHSMHS025.ehs.local \
--to=soren.brinkmann@xilinx.com \
--cc=felipensp@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=josh.cartwright@ni.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=mturquette@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=robherring2@gmail.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®