From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Claudiu.Beznea@microchip.com, Jerry.Ray@microchip.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux][PATCH v9 2/2] dts: arm: at91: Add SAMA5D3-EDS Board
Date: Tue, 13 Sep 2022 15:56:54 +0200 [thread overview]
Message-ID: <4e0487de-971c-7bb8-bdd6-7013a48ee4a6@linaro.org> (raw)
In-Reply-To: <eeca0eef-e73e-847f-de54-1511dddff842@microchip.com>
On 13/09/2022 08:37, Claudiu.Beznea@microchip.com wrote:
> On 09.09.2022 19:30, Jerry Ray wrote:
>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for
>> evaluating many Microchip ethernet switch and PHY products. Various
>> daughter cards can connect via an RGMII connector or an RMII connector.
>>
>> The EDS board is not intended for stand-alone use and has no ethernet
>> capabilities when no daughter board is connected. As such, this device
>> tree is intended to be used with a DT overlay defining the add-on board.
>> To better ensure consistency, some items are defined here as a form of
>> documentation so that all add-on overlays will use the same terms.
>>
>> Link: https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVELOPMENT-SYSTEM
>> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
>> ---
>> v8->v9:
>> - Changed node name from gpio to gpio-inputs
>
> Why not gpio-keys as all other DTSes are doing? Anyway, I can change it
> while applying.
+1 even if these are not physical keys. If we ever run sed pattern, it
would make life easier... :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-13 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 16:30 [linux][PATCH v9 1/2] dt-bindings: arm: at91: Add info on SAMA5D3-EDS Jerry Ray
2022-09-09 16:30 ` [linux][PATCH v9 2/2] dts: arm: at91: Add SAMA5D3-EDS Board Jerry Ray
2022-09-13 6:37 ` Claudiu.Beznea
2022-09-13 13:56 ` Krzysztof Kozlowski [this message]
2022-09-14 7:37 ` Claudiu.Beznea
2022-09-13 14:53 ` Jerry.Ray
2022-09-17 17:01 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0487de-971c-7bb8-bdd6-7013a48ee4a6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Jerry.Ray@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®