From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFB6318121 for ; Tue, 17 Feb 2026 09:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771322210; cv=none; b=UrREmkj9J6YZ7Ggqi+JQOEketulfsbw12/GHOED5uM1AoVL0vGrAw2mFBbGrgtgWhJlwOqUC1bj187bYkDjkCO59Ag34ZUwW7usYqYhdvTui4os36yuHNT/o+CAbwzgnKyvvFCd/wpnEIwm3p7qxWUxmkk6vnvzDPEv/K1ShmYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771322210; c=relaxed/simple; bh=eRcblvrd5cLZVFTkwCFagYaJ0w+paGvFCVQFJWoKhUw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PXWD9/e8hALIpq3vInNSmQQX8xhe0WY9WeKY4DM/Js41xgjAODRfhhqAl2SEnGSrh5T/5ivhFiqBIWY1m6Yzf5wLt5w6ynAyEeBLt3EJe7eT9LmbbTgnsHvO4v3agghjVYbxaEmu1qQnyIeIDsOB74klKl+Kbp99NSm53JBQqNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=J7SBYDCB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UU+6UbSo; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J7SBYDCB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UU+6UbSo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771322208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0BlC0sekasDq+Z3G0wuqwsYPHRJUXWfqPUd+DIRuUQ=; b=J7SBYDCBJczid8mVf0PDImVjkNwTs04JqpdpGTFgG0dOXl6cfnl5DTysazerqMXkec6iN3 tjSW/t/Gqudr5HnEr+azWFVLRxHSkBKTRaXp4Un4aO6YPFapQ8VKtCmgVCzaINtzvWPCOX AC8lV/dtReC/19OkLIUAcfsBxf3RucE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-PVOGEsloPCC8gsEEl4ttpA-1; Tue, 17 Feb 2026 04:56:46 -0500 X-MC-Unique: PVOGEsloPCC8gsEEl4ttpA-1 X-Mimecast-MFC-AGG-ID: PVOGEsloPCC8gsEEl4ttpA_1771322206 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4376b624589so3699288f8f.3 for ; Tue, 17 Feb 2026 01:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771322206; x=1771927006; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R0BlC0sekasDq+Z3G0wuqwsYPHRJUXWfqPUd+DIRuUQ=; b=UU+6UbSoTfHgMSolps8gM9sFbTxy321sIajY4MccSH0bXlCNQygwwKKEeq+DvVoDdP MU6IemNLdchTmv+zj/F+xWymKFLT7kEPD62P47kQbMOYVh8yMakvT4LjTpcdFluQ2MrF 1eceLCfZn/yP+fVHIlNOzrXpodo/5rKx4Y9Hx9WWpTEPg7kkmUgYOLaGgvIIkaSaDtZD gD+GtrBzBpMF98ADCHUkcjA3q1t3HKTyN9Cfp9D8oydBlor1W9kU1m2gtC3WkYYTrWd5 1egNzbC/DBA+uS06nJ+V165V48heJWHTPbDl5X3CAGcWsnBal7Q2PqTShhC8y7MXHgv2 wS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771322206; x=1771927006; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R0BlC0sekasDq+Z3G0wuqwsYPHRJUXWfqPUd+DIRuUQ=; b=gLPganPY2vZQz98Dg7WhPwoUiUQ3xLdxWwZFLXNaBRsNoeENuZ+icl8n4AF+YPR/9I gMKJgBQA92dwE/BOvbcurSl9plR3i7dP9Thk/81KQey9/IYhbySWwKEbPy77S5KZf69Y MqgNhJTmwp0ZNxq0jGAFlg6a29V1FyVE6LQCk8h04rQD4O5zEb6v3dqmKXFyYg9ZxqeW +t5RLgWnNPZjgN3I8TXLX5kh+l64hcHY6fKYPlaRP1INJK+LpI/1+b3hssBLSlwAIYeg uCXBJFOBJVYRIWZV9B0qL5eZQNJs/ONyUZy63okjhbXU8//MEJJsOK9FT8mKK56c7a8L u63A== X-Forwarded-Encrypted: i=1; AJvYcCXyWUl70qm1uS2esvp/hsF/LrnimsijugiAKUNZ8QEQd9J/h7CKFX4oJG37T0cT3+ym717hZD96Rlqwf9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6ozVIbKbMeg72HF2W23Kt4a5RJSvAsLUif+V25hHF6/ICJC8N 0r8U1mypP2AGpGsYVAuS47bh5gJxGHvJ2WWOhPQdJ7+gMhYmIC+/cC7Awgs2bP7NY10KOKI9YRY gtm4gf6HWNjs+dNjtSln6rGObCYxEHQedBU/dLmrW80tNOFZkrC7OHstv/2ScWOjENQ== X-Gm-Gg: AZuq6aIg5+rKpJjX9AYwSQh+MUI4ZOkjxJpF8GOfgWObpR7sAFQ7wZLEci3fhpc4x0I y43cQ6GdZOgjFQHfS7a20KcAB2qChiY3Mtl4FHtxKpkzMR+RO+kwKqF0+PCPzum+mdZDT/mjdyS NEkRY8xJra5xd2nUWfRKO0iu8e/eF17hXuvcMwo4jVZdlSSNUpeqlNFwOmvmz7RSECe69K8imlw yZnq80g+a4Gsyc74wHi9uugs7ezNbkecw6dwtw/sotZ/1zDuHhyBeiNC0vMBKfsEC/ha58Ik8VY UwVIp6GNVSWNHJI2aKZinjnuDFaiFLY+j0A95yCQITF3s6/MuOLOS4tkJtINvR7osgphUK0Yq8u GTLaCiA0NhVEOT8h+D6vAWGV0/w== X-Received: by 2002:a05:6000:40ce:b0:437:6758:ce7d with SMTP id ffacd0b85a97d-43796ac213amr24548987f8f.24.1771322205612; Tue, 17 Feb 2026 01:56:45 -0800 (PST) X-Received: by 2002:a05:6000:40ce:b0:437:6758:ce7d with SMTP id ffacd0b85a97d-43796ac213amr24548945f8f.24.1771322205125; Tue, 17 Feb 2026 01:56:45 -0800 (PST) Received: from [192.168.88.32] ([169.155.232.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8075sm32429601f8f.29.2026.02.17.01.56.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 01:56:44 -0800 (PST) Message-ID: <4e07f6b8-5225-46e0-b3ac-d02495392835@redhat.com> Date: Tue, 17 Feb 2026 10:56:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND net v1 1/2] octeon_ep: avoid compiler and IQ/OQ reordering To: Vimlesh Kumar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: sedara@marvell.com, srasheed@marvell.com, hgani@marvell.com, Veerasenareddy Burru , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Satananda Burla , Abhijit Ayarekar References: <20260212121634.360252-1-vimleshk@marvell.com> <20260212121634.360252-2-vimleshk@marvell.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260212121634.360252-2-vimleshk@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/12/26 1:16 PM, Vimlesh Kumar wrote: > Utilize READ_ONCE and WRITE_ONCE APIs for IO queue Tx/Rx > variable access to prevent compiler optimization and reordering. You must include into the commit message a more detalied description of what could possibly go wrong and way. Also why wmb/rmb are not enough? AFAICS this is the only driver requiring such annotations to cooperate with the H/W and/or the firmware. > Additionally, ensure IO queue OUT/IN_CNT registers are flushed > by performing a read-back after writing. > > Relocate IQ/OQ IN/OUT_CNTS updates to occur before NAPI completion, > and replace napi_complete with napi_complete_done. This looks like a separate change, and again requires a more complete explaination of what could possibly go wrong and why. /P