From: Joe Perches <joe@perches.com>
To: Simon Que <sque@chromium.org>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ben Chan <benchan@chromium.org>,
Chun-Ta Lin <itspeter@chromium.org>,
Zhongze Hu <frankhu@chromium.org>,
Rob Springer <rspringer@google.com>,
John Joseph <jnjoseph@google.com>
Subject: Re: [PATCH v5] drivers/staging: Gasket driver framework + Apex driver
Date: Thu, 28 Jun 2018 19:31:41 -0700 [thread overview]
Message-ID: <4e0802ced7c15f9c750bef76256233ee85897392.camel@perches.com> (raw)
In-Reply-To: <20180629002430.59486-1-sque@chromium.org>
On Thu, 2018-06-28 at 20:24 -0400, Simon Que wrote:
> The Gasket (Google ASIC Software, Kernel Extensions, and Tools) kernel
> framework is a generic, flexible system that supports thin kernel
> drivers. Gasket kernel drivers are expected to handle opening and
> closing devices, mmap'ing BAR space as requested, a small selection of
> ioctls, and handling page table translation (covered below). Any other
> functions should be handled by userspace code.
As this is not likely to be added to v4.18,
it likely would be better to target v4.19
and allow this to be compiled against -next.
This currently does not compile correctly
against next-20180628
---
$ make drivers/staging/gasket/
CALL scripts/checksyscalls.sh
DESCEND objtool
CC drivers/staging/gasket/gasket_core.o
drivers/staging/gasket/gasket_core.c: In function ‘gasket_mm_unmap_region’:
drivers/staging/gasket/gasket_core.c:1433:9: error: void value not ignored as it ought to be
return zap_vma_ptes(
^~~~~~~~~~~~~
vma, vma->vm_start + virt_offset,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DIV_ROUND_UP(mappable_region.length_bytes, PAGE_SIZE) *
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
PAGE_SIZE);
~~~~~~~~~~
drivers/staging/gasket/gasket_core.c:1437:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
scripts/Makefile.build:317: recipe for target 'drivers/staging/gasket/gasket_core.o' failed
make[1]: *** [drivers/staging/gasket/gasket_core.o] Error 1
Makefile:1691: recipe for target 'drivers/staging/gasket/' failed
make: *** [drivers/staging/gasket/] Error 2
prev parent reply other threads:[~2018-06-29 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 0:24 Simon Que
2018-06-29 2:31 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0802ced7c15f9c750bef76256233ee85897392.camel@perches.com \
--to=joe@perches.com \
--cc=benchan@chromium.org \
--cc=frankhu@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=itspeter@chromium.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sque@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®