From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C0640099A for ; Mon, 24 Aug 2026 15:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787583917; cv=none; b=PDLhAGMMER3d+gbFdsnY4IifAHAw9x0YxUCmNUZHDUFCIPNvNfWMHxPP8FJOIIF/7thPmOohkgCXbJ1K8sibuvR6tK3uY1Ayo2U8JbByEsj7NkjjkYO/umveGfeY1QbEKuz/kJIjZ3gzPzKrkZ+B2KucBX47LHQMKldnq8ztCno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787583917; c=relaxed/simple; bh=sMTiCyj5+9y1S8LPjELQzmaV6VdDm+PrnVA/OmtExmQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aIXe8kHsp5mjhSkJQmz4DIX0rttRnYsO6prQtBGauFw2y3R+RvtSp5/6AdyzhWbjwDQbg+q/fkf0U7kVKd3AIBZ/xPv9vjSFCOD/7IIIVk8Zg9laGYUXU17k8DvSD3NXNDTVXXVOdevCNyHhhtt3enlJ2t/0Kyv2XV05z+tcG90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WQo5YLjb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d+jSYmO1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WQo5YLjb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d+jSYmO1" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OCuoPg4077588 for ; Mon, 24 Aug 2026 15:05:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fl6brSJe0+fFv2NIJ5+xIBCq87sP/RzIUmJGMjRks6w=; b=WQo5YLjbSEP3ewIO FMnI97R9N6YJk9la5QGqIYT9UtMW9cG3IztThXugYL8syL/mcdWFi3KFxSgCdjaF NkLRTtHpkTxdPxOVsJ6wRh5KWnwmV8Q6tYx9g7hU9iun2AHu9FUuupGaxrAofXXD /GF/hUsroSWgFe52OL4A3mT1UaQBcXzXWZxSNqkhyeWWVs7uPu7xcEcl1LB8fmc3 4aiQt2ecuNu7nv0L8n+kJeQy9fyY6CtXUbB90tBVyXtBFiVvCaaMguqrYa1tZWHj EQ7BwG5HtkJkWBkauqMQhxQWuQQ64OzDKqN/1j4IC0f8XWyHBhC2WhixoOCUVi28 DS81vA== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g88jpkfmy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 15:05:14 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-97c957141f3so20633241.2 for ; Mon, 24 Aug 2026 08:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787583913; x=1788188713; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fl6brSJe0+fFv2NIJ5+xIBCq87sP/RzIUmJGMjRks6w=; b=d+jSYmO1wezTJuLbkLV5k/f0PmfcOJkzDNblGiRBnR3sdukkgqH5aiBT9zF19PHMa5 iQfsjPqnZm4bZb8hWxGNIVlMpkPnDBMcDopD3IW6+XrV61eW46H0Xrv4KOex2PbZEQuv tGAxNspgNJGaWE2hTXJY9eTeBnyxEVgOry5BpxBrua7t5rwCg/yag7SbeBJ4kXlmvPz1 6I+gsY8WplClverml168O2xAXXe2n6GRrDbwxyRI87icpQrDWWY3BEqeuDRaWCEvJcbR AOMEb7i39Qid97j/1m4gT8J97BO/iOejDpEe0DdLAjAvqwaKIcJxnOo7ThyZgVaepnTi 2cNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787583913; x=1788188713; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fl6brSJe0+fFv2NIJ5+xIBCq87sP/RzIUmJGMjRks6w=; b=Qg3a+SIg1mc1k+ELRZm8KjNfGBTQt7x8xssM0gZjDuSg0yAQ/YPv8/4tb+WXdK5oNS +YaFS2NJ3p9JJyBE4PI7Zgi+Dkxbtfd3G2YKJG/eb9190jhcPulDlJtunb2QBeGbgFd0 eI/bTlv5AzxnsZ7B/6Z7957NDYCLKi+AwdwhGdxkCbzLwNpuw2Qf8FMaP204xVc9+xbv 0gpOu2gTpWidHiTFE+FsjntCPHa1EAw9NAE2KIvLLhiP5EnGE4HIMvvsb/5XOAW5zXEA NrtLvmzMR0Yt25auT4HiDNcLjPlhUxEk1LKSvLF7ygk0xbTwEkdD3aW2oYatVnXxR7oD z7TQ== X-Forwarded-Encrypted: i=1; AHgh+Rql3CyrpHVzUK4Q093rOCHiou98JMfMikjdRJmUJYlwbzlmh2DDhVfQnCKBPyD+/+zMyvuJ7wsoBPlKWSE=@vger.kernel.org X-Gm-Message-State: AFuF++kNFUlz0r530a7UrxDuai0Inlb1ciCGOdPtp00IP5yTU1U7406z z2N9IF2aSDicpv1eZs36IkltnNnMI5Yz+/hKByGg7Sgi83yEhcuKXlIHtw0Gq6N3ghHQ8DwYC9S 8Q8cmdG1BT127bkmDsSWyaPHcBiRastyXL/BhpashbFSEYMuwwJ5LHFRudwC7KPLERQM= X-Gm-Gg: AR+sD11HrA7aiT2ykeZsSQO13xAbOGR6OPR4Sz6i28U8w1FKfGC2nsf9PMrjKFPFAHr Vj4iOd2WJXT0CTmqK+tSxaFmGWeYr1TNpNIPm8wjidOa8ROrULqVT2hfPQuEqdCcymmmYQladTP 1CsXpoK9pG+SfVZm4+iIppXGT4w98ALNyiXP+TrotuE+7kFdg8ndUcXwuVuHXarQkV23tDh8/6C br3aLmQ87ERwenDfYd62X9U3NpElf14fOeTyf7j9UHVx21/grSaZjm6RqGEvpVMOUPv75xnmzQ5 /yfY9FxG8kF/GS5BDBv3mokmVOz/G1nuD4twDCDLIj2LGeJ5UlA9iFIbWOgLnd4ARKdIGnt1X2d 3hJuzdLH5lX54e+esNtMNZbc9 X-Received: by 2002:a05:6122:849:b0:5c3:b339:7b19 with SMTP id 71dfb90a1353d-5c5ff3f5682mr2692099e0c.1.1787583913322; Mon, 24 Aug 2026 08:05:13 -0700 (PDT) X-Received: by 2002:a05:6122:849:b0:5c3:b339:7b19 with SMTP id 71dfb90a1353d-5c5ff3f5682mr2692045e0c.1.1787583912801; Mon, 24 Aug 2026 08:05:12 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249685ab3csm1349197666b.49.2026.08.24.08.05.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 08:05:12 -0700 (PDT) Message-ID: <4e0d636a-7975-4711-8070-6f71957b754e@oss.qualcomm.com> Date: Mon, 24 Aug 2026 17:05:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] serial: qcom-geni: Use geni_se_set_rate() for source clock configuration To: Praveen Talari , Sudeep Holla , Cristian Marussi , Ulf Hansson , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Mark Brown , Viken Dadhaniya , Andi Shyti Cc: mukesh.savaliya@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org References: <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-0-61171ab1cdce@oss.qualcomm.com> <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-4-61171ab1cdce@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260805-derive_clk_perf_tbl_from_perf_domain_opp_table-v1-4-61171ab1cdce@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDEyNiBTYWx0ZWRfX4WMPSNz9/WwO xoygBQnYqCeS47/MjNVUR0W1asInW+4zdtK4Io6CBhCuOAPoigP6G/HESXlMhr51IegmGgSdbfP Oj6ALysL+sjqDjZqkkWXzUlUvKqCCcd6rNeWuUhwVeW6MpA3tVH3MBWWKqy4kM+AcG5fH1Og85V JON67w/OFvGmZFHAWNCv2lpQ1S1VnIeuIbvRGpFLkHXCwyozZz7p4aykFVnW24ihbG3lblj7DM8 vqqpDxfBn/fUpUYCAMJd/Xb0aF0RPl6Bm6AveF3wFQsRYo82pU5ZRIcVdyMpj8JkwLdvpgf2Fmb h6AhLLqE6Zwm9YtARqHK/c/H8hCSTMGwaLec4tvLFyCj5DQoroV/h+zRPN0UfJVxwZ9NRg77XYP OwpgJzLy5Gc2z6+VDoQNSkTJVTb9bL+zr5wyqjGJN0lk09w4CqvG1wzIpqedLBxeoPONb4X9U7C 3dIeC7E2GGHD/wOeQWQ== X-Proofpoint-GUID: xNBFer36KfmNwdT_8JwwXlm3xbsDv1CI X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDEyNiBTYWx0ZWRfXy0mLKjJaWcx+ gfDx2PU62Orzz0zwyu2bclaTecTGSnSuCODND93B9gNFF97o0D4jbmQhjeFGMaiQ6l81hQuZrbu 6Tg3qdlxBxJ4nHhs/1SHFVMkRq2Os34= X-Authority-Analysis: v=2.4 cv=Xey5Co55 c=1 sm=1 tr=0 ts=6a8c5daa cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=LofuKaiTYX8IWbRp0b0A:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-ORIG-GUID: xNBFer36KfmNwdT_8JwwXlm3xbsDv1CI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_04,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240126 On 8/4/26 9:57 PM, Praveen Talari wrote: > The driver calls dev_pm_opp_set_rate() directly on uport->dev to apply > the computed source clock frequency, and dispatches baud rate handling > through a per-variant dev_data->set_rate() callback that either > recalculates the clock divider (Linux clock managed path) or selects > a performance level via geni_se_set_perf_level() (SA8255P firmware > managed path). [...] > + geni_se_set_rate(&port->se, 0); This ends up calling dev_pm_opp_set_rate(0) [i see this is an existing bug in geni_se_resources_deactivate()], which removes the power vote, but does nothing to the clock (neither set_rate nor disable_unprepare), which will crash the platform Both of these calls (new and existing) should be removed. Clocks will be disabled by geni_se_clks_off() in geni_se_resources_deactivate(). Then, we should do dev_pm_set_opp(se->dev, NULL) *after* they are off to remove any trailing OPP resources (i.e. icc votes defined in the OPP table in our case) Konrad