From: Randy Dunlap <rdunlap@infradead.org>
To: Zhang Jiaming <jiaming@nfschina.com>,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
liqiong@nfschina.com, renyu@nfschina.com
Subject: Re: [PATCH] net: hns: Fix spelling mistake in comments
Date: Sun, 3 Jul 2022 23:07:32 -0700 [thread overview]
Message-ID: <4e13e0c4-dc70-4228-609c-288f8db6ddc3@infradead.org> (raw)
In-Reply-To: <20220704014204.8212-1-jiaming@nfschina.com>
Hi--
On 7/3/22 18:42, Zhang Jiaming wrote:
> There is a typo(waitting) in comments.
> FIx it.
>
> Signed-off-by: Zhang Jiaming <jiaming@nfschina.com>
> ---
> drivers/net/ethernet/hisilicon/hns_mdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
> index 07fdab58001d..c239c407360f 100644
> --- a/drivers/net/ethernet/hisilicon/hns_mdio.c
> +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
> @@ -174,7 +174,7 @@ static int hns_mdio_wait_ready(struct mii_bus *bus)
> u32 cmd_reg_value;
> int i;
>
> - /* waitting for MDIO_COMMAND_REG 's mdio_start==0 */
> + /* waiting for MDIO_COMMAND_REG 's mdio_start==0 */
Also: no space here: MDIO_COMMAND_REG's
> /* after that can do read or write*/
> for (i = 0; i < MDIO_TIMEOUT; i++) {
> cmd_reg_value = MDIO_GET_REG_BIT(mdio_dev,
> @@ -319,7 +319,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
> MDIO_C45_READ, phy_id, devad);
> }
>
> - /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/
> + /* Step 5: waiting for MDIO_COMMAND_REG 's mdio_start==0,*/
Same here.
> /* check for read or write opt is finished */
> ret = hns_mdio_wait_ready(bus);
> if (ret) {
--
~Randy
next prev parent reply other threads:[~2022-07-04 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 1:42 Zhang Jiaming
2022-07-04 6:07 ` Randy Dunlap [this message]
2022-07-04 9:36 ` [PATCH] net: hns: Fix spelling mistakes " Zhang Jiaming
2022-07-04 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e13e0c4-dc70-4228-609c-288f8db6ddc3@infradead.org \
--to=rdunlap@infradead.org \
--cc=edumazet@google.com \
--cc=jiaming@nfschina.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=renyu@nfschina.com \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®