From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19A753074A1 for ; Mon, 4 May 2026 07:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777880522; cv=none; b=Yl7sS7jawjsLpPp0WjbtUXVK7L7o1cESTcRhAQB9LCRzky9TWaUFIC+yICQcGQGEm5bQJpdWOhFChXSw5+appMXCiLDtVRmpmjzG2hy6G0C1LjLhYFhocTPg7Cn9CZzlGo/dwM3kyn0JvsYYssPwo4kgurvujjGUWg1rwcn26hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777880522; c=relaxed/simple; bh=wppOGaRjuNDplImhUtX3yedW8XVD+Rjnv4702GUsXr0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SZyXlKpZ4epAk2UqVWcqF4PPjFuiOyxyDIZyuvrLxbObGiBSSIyR3IWTBfxvmMayj0lNDjAneJt1Ze+iC+fOFluIL2KtPADIXhYNZP3m/lWf6lrLKqP44zD5mLBqZO4/ry7IxH54ztbIQNyzOOiDNeKIb4QypL3+1L/l+VxUlLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b=n3dL+a0A; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b="n3dL+a0A" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4891b0786beso25657075e9.1 for ; Mon, 04 May 2026 00:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall.org; s=google; t=1777880519; x=1778485319; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C3RAkK6cIEAorEjiat0wspxnHljFQkJZ30oFU41kBVI=; b=n3dL+a0AITT7wMJ+2WG2k2aw+20TwJLDw30kWbJF7NXj7OpKpMV4otW1caMBiIs5zv C+TWVXvoZwedO34GZrE6m0bskRY7XbUKTsgWbDkNxa/Qn8kAteEmenwHBbNAl42CZb8b kefAaI8RnJHocsQQTPrMY70OsTM8F4ClUFYp/HYl2SD0c8QUbYSIvfPe0P+413s93caH vFnLnJG/sgH4EroecFQ6VI3ZmNp+UcXSoFX1W5GH37vYqiTQTfBka7Ep1WSVVC4uFgtE 6DUd4s12zZe3WBsnnD4zvZmBdh2r0wSongMF+FqopFaaohKl34ZHrRpjwPjIOOZMWvUn FiMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777880519; x=1778485319; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C3RAkK6cIEAorEjiat0wspxnHljFQkJZ30oFU41kBVI=; b=WE1Aj2tJ04/OHjhMi1ROfL+/ZMYDsR15D0cqWy/2hq++/xFdhxNdGpbb7VNFIB3J5l S0Y+IfvhEvpjpjMdYO6pPsc7VNQCY5XvY2tIZPT5Ibq/kjIdPI3FAJxJT/TB04SFDSah OPMLqbtvUpFb/Z5B94H5YUBxNPA7fAhvBFwB1i94ErgDlwvRXpFNNft95JPPCG+hJ64j LZOWxtGtobucAx3UP3RTnOzdb2BtnARz19J/Pw0yvgq3Pc0uYwSl+Esr/Yg8fwD5AvMG 0V9mhRTRE7tyPhQYrMXITf1loUb1YzHWwI14RbrMjVpv61XNSyzSwPRCYMDcKrK8et+N dcgg== X-Forwarded-Encrypted: i=1; AFNElJ+opZtTAgqVz+3ykhEHmX0DpLQ3at+eSRtvOUjXLTvpSiNakJ0kGGS3UoQJNEeIwryZx1Wk5UryM2yEONw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1eI+UZZDk13NzsxTVgE7EpWmrO3tcW4ORXOoYglB6a6EYEcO0 vOFq2Zc2mcf9ia8ab29iNRsCgJmIQ3ukULzL2xvrcMiIyT6clpRdbTpmCuXd4GOf5aU= X-Gm-Gg: AeBDiet6A0o0MIxEsAp3cMhkXBXRCZOL0+T1+j4yyvTIO9aKlUR4mcQYKcZSw8Ojm5f nYhaMdzrqVPdgI4DZnF89ZCDWXO0r1rjkIzzHKimkBpKmFLE4SgBlGiHlt5U4PD/M6SX/U3SW5j +4R/IFrrufa5a6XHsmWS/H46dI5DLQm2blY/xBWQECoXXJfeid1/Z1IvWNyEIDEJplzoxewCbFt PaDNU9Eb8sXJfePWmHExkV7zoIb+MtjMx6+0pubvUkNSJQssCtbaQ8N75Vj6Re5RSmt1mwplBYf WGuJgVxDsdaIlpJZ3fu8sHbaPuTOPVwcpl3TEHU3cTkR08HL8NqqUC+pkB+fNqw86ZBZJJ3q5lz /VJ529Ek297ItqDmSIs3ucZQiZ7NK8C19K14hD3iVIRCHAgPC6pUgYHYLrL6pb+l21sUI1LNZnM Op+DxauoaVbfQnv8ybkgGyTMJiU74FLOCjf+ZjVNmL84e9B0V+S8s5eDsq317QYv0J X-Received: by 2002:a05:600c:1386:b0:488:9439:881a with SMTP id 5b1f17b1804b1-48a9852f471mr135743855e9.2.1777880519512; Mon, 04 May 2026 00:41:59 -0700 (PDT) Received: from [192.168.0.161] (78-154-15-182.ip.btc-net.bg. [78.154.15.182]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fef8f39sm73312865e9.32.2026.05.04.00.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 00:41:58 -0700 (PDT) Message-ID: <4e172860-1f37-4de9-8520-dcf3d53d5ad7@blackwall.org> Date: Mon, 4 May 2026 10:41:57 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 3/6] bridge: Add selective forwarding of gratuitous neighbor announcements Content-Language: en-US, bg To: Danielle Ratson , netdev@vger.kernel.org Cc: donald.hunter@gmail.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, idosch@nvidia.com, andrew+netdev@lunn.ch, shuah@kernel.org, ast@fiberby.net, liuhangbin@gmail.com, daniel@iogearbox.net, aroulin@nvidia.com, fmaurer@redhat.com, sdf.kernel@gmail.com, sd@queasysnail.net, kees@kernel.org, nickgarlis@gmail.com, amorenoz@redhat.com, alasdair@mcwilliam.dev, johannes.wiesboeck@aisec.fraunhofer.de, petrm@nvidia.com, linux-kernel@vger.kernel.org, bridge@lists.linux.dev, linux-kselftest@vger.kernel.org References: <20260503073532.2138165-1-danieller@nvidia.com> <20260503073532.2138165-4-danieller@nvidia.com> From: Nikolay Aleksandrov In-Reply-To: <20260503073532.2138165-4-danieller@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/05/2026 10:35, Danielle Ratson wrote: > The existing neighbor suppression unconditionally suppresses gratuitous > ARPs and unsolicited Neighbor Advertisements, which prevents fast > mobility of hosts between VTEPs. > > Add the neigh_forward_grat option to allow selective control of gratuitous > neighbor announcements. When neigh_suppress is enabled but > neigh_forward_grat is disabled (default), gratuitous announcements are > suppressed. When neigh_forward_grat is enabled, gratuitous announcements > are forwarded while regular neighbor discovery remains suppressed. > > The implementation provides per-output-port control by: > 1. Adding a 'grat_arp' flag to BR_INPUT_SKB_CB to mark gratuitous ARPs and > unsolicited NAs. > 2. Setting both grat_arp and proxyarp_replied flags in > br_do_proxy_suppress_arp() and br_do_suppress_nd() when gratuitous > packets are detected. > 3. Checking neigh_forward_grat per output port during flooding: > - For gratuitous ARPs/NAs: suppress unless the output port has > neigh_forward_grat enabled. > - For regular ARPs/NDs: maintain existing behavior. > > This allows gratuitous announcements from any input port to be selectively > forwarded based on each output port's individual neigh_forward_grat > setting, enabling gratuitous neighbor announcements to be flooded to the > VXLAN fabric. > > Regular neighbor discovery (ARP requests, NS queries, solicited replies) > remains controlled by neigh_suppress and is unaffected. > > Signed-off-by: Danielle Ratson > Reviewed-by: Ido Schimmel > Reviewed-by: Petr Machata > --- > net/bridge/br_arp_nd_proxy.c | 22 ++++++++++++++++++++++ > net/bridge/br_forward.c | 15 +++++++++++---- > net/bridge/br_private.h | 2 ++ > 3 files changed, 35 insertions(+), 4 deletions(-) > Acked-by: Nikolay Aleksandrov