mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ammar Faizi <ammarfaizi2@openresty.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Willy Tarreau <w@1wt.eu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Kselftest Mailing List <linux-kselftest@vger.kernel.org>,
	LLVM Mailing List <llvm@lists.linux.dev>,
	Yichun Zhang <yichun@openresty.com>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	Shuah Khan <shuah@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	gwml@gnuweeb.org
Subject: Re: [PATCH 3/4] selftests/nolibc: add abs() range test
Date: Mon, 27 Jul 2026 09:01:09 +0700	[thread overview]
Message-ID: <4e22086c-8a60-4965-8d78-a946dc54eaa3@openresty.com> (raw)
In-Reply-To: <6a5f7481-124f-48ad-ab44-577b12d33592@openresty.com>

On 7/27/26 8:32 AM, Ammar Faizi wrote:
> On 7/27/26 3:00 AM, Thomas Weißschuh wrote:
>> We have _NOLIBC_OPTIMIZER_HIDE_VAR() for this.
> 
> Oh, I missed it.
> 
>> Maybe it can be made variadic.

Oh wait, tools/testing/selftests/nolibc/nolibc-test.c is compiled
twice. One for libc, one for nolibc. The test cannot use
_NOLIBC_OPTIMIZER_HIDE_VAR(), it breaks libc:
```
$ make -f Makefile.nolibc run-libc-test
nolibc-test.c: In function ‘test_abs_range’:
nolibc-test.c:1756:9: error: implicit declaration of function ‘_NOLIBC_OPTIMIZER_HIDE_VAR’ [-Wimplicit-function-declaration]
  1756 |         _NOLIBC_OPTIMIZER_HIDE_VAR(ll, l, i);
       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile.nolibc:278: libc-test] Error 1
```

What approach do you prefer?

-- 
Ammar Faizi


  reply	other threads:[~2026-07-27  2:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26 10:13 [PATCH 0/4] nolibc: syscall() and abs() fixes, plus a cleanup Ammar Faizi
2026-07-26 10:13 ` [PATCH 1/4] tools/nolibc: evaluate syscall() arguments before the arch macros Ammar Faizi
2026-07-26 20:16   ` Thomas Weißschuh
2026-07-27  1:21     ` Ammar Faizi
2026-07-27  3:42       ` Willy Tarreau
2026-07-28  6:53         ` Ammar Faizi
2026-07-27  3:30     ` Willy Tarreau
2026-07-27 16:18       ` Thomas Weißschuh
2026-07-28  6:51         ` Ammar Faizi
2026-07-26 10:13 ` [PATCH 2/4] tools/nolibc: stdlib: avoid signed overflow in abs() and friends Ammar Faizi
2026-07-26 14:13   ` David Laight
2026-07-26 16:01     ` Willy Tarreau
2026-07-27  7:32       ` David Laight
2026-07-27 16:15         ` Thomas Weißschuh
2026-07-28  8:46   ` David Laight
2026-07-28 16:31     ` Thomas Weißschuh
2026-07-28 16:37       ` Ammar Faizi
2026-07-26 10:13 ` [PATCH 3/4] selftests/nolibc: add abs() range test Ammar Faizi
2026-07-26 20:00   ` Thomas Weißschuh
2026-07-27  1:32     ` Ammar Faizi
2026-07-27  2:01       ` Ammar Faizi [this message]
2026-07-27 16:13         ` Thomas Weißschuh
2026-07-28  6:14           ` Ammar Faizi
2026-07-26 10:13 ` [PATCH 4/4] tools/nolibc: remove dead __ARCH_WANT_SYS_OLD_SELECT Ammar Faizi
2026-07-26 20:01   ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e22086c-8a60-4965-8d78-a946dc54eaa3@openresty.com \
    --to=ammarfaizi2@openresty.com \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=gwml@gnuweeb.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=shuah@kernel.org \
    --cc=w@1wt.eu \
    --cc=yichun@openresty.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®