From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D96C433DF for ; Fri, 31 Jul 2020 16:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 187AD21744 for ; Fri, 31 Jul 2020 16:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732603AbgGaQft (ORCPT ); Fri, 31 Jul 2020 12:35:49 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:36684 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728898AbgGaQfq (ORCPT ); Fri, 31 Jul 2020 12:35:46 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id E9B06180A7FDA; Fri, 31 Jul 2020 16:35:44 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: dogs56_551834026f85 X-Filterd-Recvd-Size: 2396 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Fri, 31 Jul 2020 16:35:44 +0000 (UTC) Message-ID: <4e30e2df7bec0fedf1a29f7825fbb4c12593eac9.camel@perches.com> Subject: Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+ From: Joe Perches To: "Gustavo A. R. Silva" , Vivien Didelot Cc: linux-kernel@vger.kernel.org Date: Fri, 31 Jul 2020 09:35:42 -0700 In-Reply-To: <20200731163301.GA8004@embeddedor> References: <20200731163301.GA8004@embeddedor> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote: > Increase columns highlighting to 100+ once the 80-column warning has > been deprecated in the Linux kernel[1]. > > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") > > Signed-off-by: Gustavo A. R. Silva > --- > plugin/linuxsty.vim | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim > index 6f7e331..c42ce72 100644 > --- a/plugin/linuxsty.vim > +++ b/plugin/linuxsty.vim > @@ -62,7 +62,7 @@ function s:LinuxFormatting() > setlocal tabstop=8 > setlocal shiftwidth=8 > setlocal softtabstop=8 > - setlocal textwidth=80 > + setlocal textwidth=100 This is not a good change. 80 columns is still _preferred_. It's just checkpatch will not emit a warning for lines longer than 80 columns but will for lines longer than 100 columns. checkpatch will also not emit a warning on file checking at all. > setlocal noexpandtab > > setlocal cindent > @@ -80,7 +80,7 @@ function s:LinuxHighlighting() > highlight default link LinuxError ErrorMsg > > syn match LinuxError / \+\ze\t/ " spaces before tab > - syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more > + syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more > > " Highlight trailing whitespace, unless we're in insert mode and the > " cursor's placed right after the whitespace. This prevents us from having