From: Tomas Henzl <thenzl@redhat.com>
To: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>,
jejb@kernel.org, hch@infradead.org
Cc: linux-scsi@vger.kernel.org, Sathya.Prakash@broadcom.com,
linux-kernel@vger.kernel.org, christopher.owens@broadcom.com,
kiran-kumar.kasturi@broadcom.com, sumit.saxena@broadcom.com
Subject: Re: [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers
Date: Tue, 6 Dec 2016 17:01:56 +0100 [thread overview]
Message-ID: <4e332ea6-1285-2d3c-0632-4f608a6ccd9b@redhat.com> (raw)
In-Reply-To: <1480955261-178967-2-git-send-email-sasikumar.pc@broadcom.com>
On 5.12.2016 17:27, Sasikumar Chandrasekaran wrote:
> This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers
>
> Signed-off-by: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>
> ---
> drivers/scsi/megaraid/megaraid_sas.h | 11 ++++++++++-
> drivers/scsi/megaraid/megaraid_sas_base.c | 20 ++++++++++++++++++-
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 30 ++++++++++++++++++++++-------
> 3 files changed, 52 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h
> index 0d2625b..f24ce88 100644
> --- a/drivers/scsi/megaraid/megaraid_sas.h
> +++ b/drivers/scsi/megaraid/megaraid_sas.h
> @@ -56,6 +56,14 @@
> #define PCI_DEVICE_ID_LSI_INTRUDER_24 0x00cf
> #define PCI_DEVICE_ID_LSI_CUTLASS_52 0x0052
> #define PCI_DEVICE_ID_LSI_CUTLASS_53 0x0053
> +#define PCI_DEVICE_ID_LSI_MECTOR 0x00D4
> +#define PCI_DEVICE_ID_LSI_VENTURA 0x0014
> +#define PCI_DEVICE_ID_LSI_CRUSADER 0x0015
Nack.
This is not good, my test system panics instead of booting.
megaraid_sas 0000:02:0e.0: RDPQ mode : (disabled)
BUG: unable to handle kernel paging request at 0000000000001e78
IP: [<ffffffffa0321321>] megasas_issue_init_mfi+0x171/0x270 [megaraid_sas]
you are already having a device with same device value in your pci_table
(PCI_DEVICE_ID_DELL_PERC5 is also 0x15), so fix the switch in megasas_probe_one.
Cheers,
tomash
(when sending new fixed versions, please add to the changed patches a text explaining
what was changed in which version, like so - www.spinics.net/lists/linux-scsi/msg102122.html)
>
> @@ -5723,6 +5732,15 @@ static int megasas_probe_one(struct pci_dev *pdev,
> instance->pdev = pdev;
>
> switch (instance->pdev->device) {
> + case PCI_DEVICE_ID_LSI_VENTURA:
> + case PCI_DEVICE_ID_LSI_MARLIN:
> + case PCI_DEVICE_ID_LSI_MECTOR:
> + case PCI_DEVICE_ID_LSI_CRUSADER:
> + case PCI_DEVICE_ID_LSI_HARPOON:
> + case PCI_DEVICE_ID_LSI_TOMCAT:
> + case PCI_DEVICE_ID_LSI_VENTURA_4PORT:
> + case PCI_DEVICE_ID_LSI_CRUSADER_4PORT:
> + instance->is_ventura = true;
> case PCI_DEVICE_ID_LSI_FUSION:
> case PCI_DEVICE_ID_LSI_PLASMA:
> case PCI_DEVICE_ID_LSI_INVADER:
next prev parent reply other threads:[~2016-12-06 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 16:27 [PATCH V3 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-06 16:01 ` Tomas Henzl [this message]
2016-12-05 16:27 ` [PATCH V3 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-05 16:27 ` [PATCH V3 11/11] megaraid_sas: driver version upgrade Sasikumar Chandrasekaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e332ea6-1285-2d3c-0632-4f608a6ccd9b@redhat.com \
--to=thenzl@redhat.com \
--cc=Sathya.Prakash@broadcom.com \
--cc=christopher.owens@broadcom.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=kiran-kumar.kasturi@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sasikumar.pc@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®