From: Casey Schaufler <casey@schaufler-ca.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: jmorris@namei.org, serge@hallyn.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smack: fix an compile error in smack_post_notification
Date: Mon, 23 Sep 2019 14:49:22 -0700 [thread overview]
Message-ID: <4e3513ac-3398-5d21-a2b2-3006ba03a690@schaufler-ca.com> (raw)
In-Reply-To: <1569208607-23263-1-git-send-email-zhongjiang@huawei.com>
On 9/22/2019 8:16 PM, zhong jiang wrote:
> I hit the following error when compile the kernel.
What tree/branch are you working with? I don't see this.
>
> security/smack/smack_lsm.c: In function smack_post_notification:
> security/smack/smack_lsm.c:4383:7: error: dereferencing pointer to incomplete type struct watch_notification
> if (n->type == WATCH_TYPE_META)
> ^~
> security/smack/smack_lsm.c:4383:17: error: WATCH_TYPE_META undeclared (first use in this function); did you mean TCA_PIE_BETA?
> if (n->type == WATCH_TYPE_META)
> ^~~~~~~~~~~~~~~
> TCA_PIE_BETA
> security/smack/smack_lsm.c:4383:17: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> security/smack/smack.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index 62529f3..02b05a2 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -21,6 +21,7 @@
> #include <linux/rculist.h>
> #include <linux/lsm_audit.h>
> #include <linux/msg.h>
> +#include <linux/watch_queue.h>
>
> /*
> * Use IPv6 port labeling if IPv6 is enabled and secmarks
prev parent reply other threads:[~2019-09-23 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 3:16 zhong jiang
2019-09-23 5:17 ` kbuild test robot
2019-09-23 21:49 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3513ac-3398-5d21-a2b2-3006ba03a690@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®