From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B8544AB7E for ; Tue, 18 Aug 2026 11:59:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787054399; cv=none; b=dZGmFSefBqdyctYoaojfPf/Dq4VhczfstfmgbhUWsuTOtNYy30hF6g7SdpVsQcHbN+ZPsKMNiQVCC4dJiNdiY8ULklc356o0bkEmI2j48UBeAX9XjYBZqGTT9f85WL6AnZsoHyudqBg+oDD/iWJ6R6bSxR/bbadCK/tTc80kvjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787054399; c=relaxed/simple; bh=4XrU5DOs80iqMiB8KU7Viwwf3z4yaHMHf4dvuHwXlRs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kM2ANWfpec3e9tD0deeG+pPYjeSev+9APMNugNM2QxAAhOP0KmI7YckgoJ5dzVj80Tjo71WPi/Ij4GsOPZlE3f6a9HL+w4hOa0yxTB1Wapxg2lt1WlvCevtBeblLK1y8Jm69bp04t2SiH0kpi2/CdJClwvh4v1sxwZ7Zaf42fyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HiLZefeN; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HiLZefeN" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-4798bea72f9so2884862f8f.1 for ; Tue, 18 Aug 2026 04:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787054396; x=1787659196; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uS9zOAi5LfeCdiC/XsclJmrpHRK7bC0G5EuVG3u99Qk=; b=HiLZefeNtIcSHGiyMMME9aqi0/V0e04QxE/ja4EXcVouytWkKgTypLTNe//85JlwGV Txid3tA+dzCflJRWB2cQD6w9sL4x6hxURuZM55/cRH4g28RfAwxSa2WeXmrbfPdOItr8 8dUpotV/y34+GLch1keE3sZpfrmUNEHth/V0LI8B3t/8wOkcYsK6LTcGsRMNDJ9qPC4e MJzx/UyPzYhVSt9050jbYG+epYkXbXIyh+XoSp9O8l+/PqLaz/QKM9hjPCy50NBSGMUW nfEy8/+Zx/D58g0oxdjvPs5Ar/rY2JqbTX8cdaNuR/9bWkU+5+nt4LPGiZRhYVGbs0pf Ibnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787054396; x=1787659196; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uS9zOAi5LfeCdiC/XsclJmrpHRK7bC0G5EuVG3u99Qk=; b=KsEC0WsE/oCTaEcHQfHhs6mx+YKnB3ypQXgUWDbues3bRJDkdqGiaXorBcsEA8fSlv YazDfzOV2wLHqO9etPU+St3idFbez/uCw+CeLuLfSZkU/uUJMr88Cm+/3XnLDPKGsxVy JsfjujiiN6+YpwuVAji0b0vMhUl9zltmfSTIvNFlTx9duOuQToh/NtYsbpbfvd36cvdG ghG+S8BoZUT0MHD+T6eg8DL+I6TXUdTJDBCcCzwm+f1GVY1R6PEBFNq3KPFPFSu6+Sro l2Rev2RvcGukpDFwCVLzNGRSTRXumGLjrevTRPaHOrta3enVIeF7JLpFEJ1XzxlSVIrB 6CYQ== X-Forwarded-Encrypted: i=1; AHgh+RpiUfxrlef+RvhY9LEjMv/Qnc4zFedfWWBNEeMPOmOOSz6MS2jVFt3oQTBopVeF0/RIhH9TL+OZ71PMLO8=@vger.kernel.org X-Gm-Message-State: AOJu0YwlMSsXszrX8NRQm0ODnceyJRYHZvjhOIMuXrn8xmR7mxMLsNYV nztEedM0pdRWfIU5KpEt0rwU0KNpTJ6McmkyMBARfxSc+Eouj5A5YeolkRPEvkD6yCg= X-Gm-Gg: AR+sD12mNDOnnEY+pmU+991POdpur76AYIqEp3UOwxwfKDF8Wmmb8S6w26WHmyqNXf1 hxHxbeJAyVYCdejxqqLgy0n8sU4mOnPxkVxssmS5be7D/WTUGnWRpS2UZF+SyoEN0p/B0lqCnHD tfp+6G27dc7Wz/mZpYfIf6tXiddPnYp+wTSdd7Q621USWHPc/iHz2nYHgUW6tfVmjspWKOWynfM HWP+KbGvAuVmeR+CmX6oME7xnX9oHefphsP7XkwNffGp/bfa/VjAdeIEAJd3MJnlu9zQxwzwoXv Ixghk34mXxCUcz9C5hF6ajQZa3XmURqy6tQJSOCzZI11dUOFlztWBoKlO1+GuVtlutNKHJFo/AQ pH3keZh85Qrf/rWYHVGcmEPWcLdmD4ruyVf6k1V+b27zlV9rlN+4UJm1tn91Gh7mfgaUfFqvmbz 3CcY4THzuo8lHymT10Xkyf6hXFc1d1N9YGwsF0y39a5LzIIqVBJKItwxVOHmCIvpiHANvYgBZNx jKBgNoaQOgCYWzRUlzRy79I X-Received: by 2002:a05:6000:46d4:b0:481:f33d:6445 with SMTP id ffacd0b85a97d-482a907b955mr9315513f8f.7.1787054395935; Tue, 18 Aug 2026 04:59:55 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:fc6c:f9a2:4a0a:6354? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a7c603sm12401112f8f.21.2026.08.18.04.59.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 04:59:55 -0700 (PDT) Message-ID: <4e351b13-1670-4813-ac98-e44c00703601@suse.com> Date: Tue, 18 Aug 2026 13:59:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] module/kallsyms: Filter out local and mapping symbols during module load To: Tiezhu Yang Cc: Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-modules@vger.kernel.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260812032807.15034-1-yangtiezhu@loongson.cn> <20260812032807.15034-4-yangtiezhu@loongson.cn> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260812032807.15034-4-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/12/26 5:28 AM, Tiezhu Yang wrote: > The compiler toolchains generate local and mapping symbols on certain > architectures like LoongArch for optimizations and relocations. Nit: "local" -> "local label". > > While the symbols are already filtered out during runtime lookups via > find_kallsyms_symbol(), they still leak into /proc/kallsyms for loaded > modules because layout_symtab() and add_kallsyms() do not filter them > during load time. > > Consequently, tracing tools like bpftrace (which do not perform internal > filtering, unlike perf) resolve identical addresses into confusing local > labels instead of actual clear C function names. > > Fix this by integrating the is_local_mapping_symbol() check directly into > the newly introduced is_kept_symbol() helper. This ensures these unneeded > symbols are stripped during module load time, keeping /proc/kallsyms clean > and resulting in accurate call stacks. > > Signed-off-by: Tiezhu Yang Reviewed-by: Petr Pavlu -- Thanks, Petr