From: Florian Fainelli <f.fainelli@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, rppt@kernel.org,
fancer.lancer@gmail.com, guro@fb.com, akpm@linux-foundation.org,
paul@crapouillou.net,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Yanteng Si <siyanteng@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
"open list:BROADCOM BMIPS MIPS ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption
Date: Tue, 2 Mar 2021 17:30:18 -0800 [thread overview]
Message-ID: <4e3640d4-7fc2-96dc-de00-599b3ac80757@gmail.com> (raw)
In-Reply-To: <20210302235411.GA3897@alpha.franken.de>
On 3/2/2021 3:54 PM, Thomas Bogendoerfer wrote:
> On Mon, Mar 01, 2021 at 08:19:38PM -0800, Florian Fainelli wrote:
>> BMIPS is one of the few platforms that do change the exception base.
>> After commit 2dcb39645441 ("memblock: do not start bottom-up allocations
>> with kernel_end") we started seeing BMIPS boards fail to boot with the
>> built-in FDT being corrupted.
>>
>> Before the cited commit, early allocations would be in the [kernel_end,
>> RAM_END] range, but after commit they would be within [RAM_START +
>> PAGE_SIZE, RAM_END].
>>
>> The custom exception base handler that is installed by
>> bmips_ebase_setup() done for BMIPS5000 CPUs ends-up trampling on the
>> memory region allocated by unflatten_and_copy_device_tree() thus
>> corrupting the FDT used by the kernel.
>>
>> To fix this, we need to perform an early reservation of the custom
>> exception that is going to be installed and this needs to happen at
>> plat_mem_setup() time to ensure that unflatten_and_copy_device_tree()
>> finds a space that is suitable, away from reserved memory.
>>
>> Huge thanks to Serget for analysing and proposing a solution to this
>> issue.
>>
>> Fixes: Fixes: 2dcb39645441 ("memblock: do not start bottom-up allocations with kernel_end")
>> Debugged-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>> Reported-by: Kamal Dasu <kdasu.kdev@gmail.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> Thomas,
>>
>> This is intended as a stop-gap solution for 5.12-rc1 and to be picked up
>> by the stable team for 5.11. We should find a safer way to avoid these
>> problems for 5.13 maybe.
>
> let's try to make it in one ago. Hwo about reserving vector space in
> cpu_probe, if it's known there and leave the rest to trap_init() ?
>
> Below patch got a quick test on IP22 (real hardware) and malta (qemu).
> Not sure, if I got all BMIPS parts correct, so please check/test.
Works for me here:
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
> BTW. do we really need to EXPORT_SYMBOL ebase ?
It seems like MIPS KVM support can be built as a module which is why
ebase was exported to modules with
878edf014e29de38c49153aba20273fbc9ae31af ("MIPS: KVM: Restore host EBase
from ebase variable")?
--
Florian
next prev parent reply other threads:[~2021-03-03 11:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 20:12 [PATCH v2 1/2] mm: cma: allocate cma areas bottom-up Roman Gushchin
2020-12-17 20:12 ` [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end Roman Gushchin
2020-12-19 14:52 ` Wonhyuk Yang
2020-12-19 17:05 ` Roman Gushchin
2020-12-20 6:49 ` Mike Rapoport
2021-01-22 4:37 ` Thiago Jung Bauermann
2021-01-24 2:09 ` Andrew Morton
2021-01-24 7:34 ` Mike Rapoport
2021-01-26 0:30 ` Thiago Jung Bauermann
2021-02-08 23:58 ` Thiago Jung Bauermann
2021-02-28 4:18 ` Florian Fainelli
2021-02-28 9:00 ` Mike Rapoport
2021-02-28 18:19 ` Florian Fainelli
2021-02-28 23:08 ` Serge Semin
2021-03-01 3:50 ` Florian Fainelli
2021-03-01 9:22 ` Serge Semin
2021-03-02 4:09 ` Florian Fainelli
2021-03-02 13:26 ` Serge Semin
2021-03-02 4:19 ` [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption Florian Fainelli
2021-03-02 8:09 ` Mike Rapoport
2021-03-02 13:54 ` Serge Semin
2021-03-02 19:04 ` Roman Gushchin
2021-03-02 23:54 ` Thomas Bogendoerfer
2021-03-03 1:30 ` Florian Fainelli [this message]
2021-03-03 9:41 ` Thomas Bogendoerfer
2021-03-03 17:45 ` Maciej W. Rozycki
2021-03-03 18:15 ` Thomas Bogendoerfer
2021-03-03 21:50 ` Maciej W. Rozycki
2021-03-01 9:45 ` [PATCH v2 2/2] memblock: do not start bottom-up allocations with kernel_end Mike Rapoport
2021-03-02 3:55 ` Roman Gushchin
2021-03-02 13:08 ` Serge Semin
2021-03-23 18:19 ` [tip: x86/boot] x86/setup: Consolidate early memory reservations tip-bot2 for Mike Rapoport
2020-12-20 6:48 ` [PATCH v2 1/2] mm: cma: allocate cma areas bottom-up Mike Rapoport
2020-12-21 17:05 ` Roman Gushchin
2020-12-23 4:06 ` Andrew Morton
2020-12-23 16:35 ` Roman Gushchin
2020-12-23 22:10 ` Mike Rapoport
2020-12-28 19:36 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3640d4-7fc2-96dc-de00-599b3ac80757@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=akpm@linux-foundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chenhuacai@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=guro@fb.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rppt@kernel.org \
--cc=siyanteng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome