From: Ayan George <ayan@ayan.net>
To: psusi@cfl.rr.com, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: loop device auto release patch
Date: Thu, 04 Aug 2011 02:13:35 +0000 [thread overview]
Message-ID: <4e3a004f.w3IoBoSiMXE/VS4Z%ayan@ayan.net> (raw)
In-Reply-To: <4E39FCC0.4000800@cfl.rr.com>
Phillip Susi <psusi@cfl.rr.com> wrote:
> On 07/15/2011 03:19 PM, Andrew Morton wrote:
> > The patch appears to do two unrelated things. That's generally frowned
> > upon, but doesn't bother me much if the patch is small.
> >
> > Still, splitting it into two patches (in which the bugfix is staged
> > first) would be advantageous for people who might wish to backport the
> > fix into earlier kernels.
>
> It looks like this got stalled and someone emailed me asking what
> happened to it. I'm not sure that splitting the patch in two makes
> sense. I don't see how it does two unrelated things.
I agree -- I can't think of a meaningful way to split it up. I am
stalled in testing it however.
I watched the values of lo->lo_device and bdev using systemtap and
noticed cases where they could be out of sync which *might* make
this patch invalid. I'd like a little more time to investigate.
-ayan
prev parent reply other threads:[~2011-08-04 2:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E1F3BE0.8040506@ayan.net>
2011-07-15 19:12 ` Phillip Susi
2011-07-15 19:19 ` Andrew Morton
2011-07-15 22:28 ` Ayan George
2011-08-04 1:58 ` Phillip Susi
2011-08-04 2:06 ` Andrew Morton
2011-08-04 2:13 ` Ayan George [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3a004f.w3IoBoSiMXE/VS4Z%ayan@ayan.net \
--to=ayan@ayan.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psusi@cfl.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®