From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF52EC12002 for ; Mon, 19 Jul 2021 07:52:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A10E06024A for ; Mon, 19 Jul 2021 07:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235071AbhGSHzV (ORCPT ); Mon, 19 Jul 2021 03:55:21 -0400 Received: from smtprelay0003.hostedemail.com ([216.40.44.3]:55836 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235086AbhGSHzU (ORCPT ); Mon, 19 Jul 2021 03:55:20 -0400 Received: from omf10.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id A9BE9182CF669; Mon, 19 Jul 2021 07:52:19 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA id 7A474235201; Mon, 19 Jul 2021 07:52:18 +0000 (UTC) Message-ID: <4e42f2580d8b473ac7e25642b039adf73b5efe06.camel@perches.com> Subject: Re: [PATCH v3] checkpatch: add a rule to check general block comment style From: Joe Perches To: Ani Sinha , Lukas Bulwahn Cc: Linux Kernel Mailing List , anirban.sinha@nokia.com, mikelley@microsoft.com, Andy Whitcroft , Dwaipayan Ray Date: Mon, 19 Jul 2021 00:52:17 -0700 In-Reply-To: References: <20210714063422.2164699-1-ani@anisinha.ca> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: z3bsa5p4w1wukmhaczxk57wqwsy56yu9 X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 7A474235201 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+zW0MKnEInLFW/aU2/8WJF+hl9TzGV3m0= X-HE-Tag: 1626681138-267745 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-07-19 at 12:25 +0530, Ani Sinha wrote: > I do not see why we cannot add this rule to checkpatch. If the > reviewer likes the other style of commenting they can always ask for a > correction. Having checkpatch agree with Linus' preferred style of > commenting and the preferred documeted style of commenting (which seems to > be the same) does make everything uniform and agreeable. Too many novice developers take checkpatch output as dicta. It's not. It's just produces suggestions that should _always_ be taken not very seriously. Those suggestions should perhaps be considered, but good taste should always override a brainless script. _Very_ few senior developers really care that much about any particular comment style. These are the same senior developers that would be burdened with unnecessary patches to review from those novice developers that believe checkpatch should always be followed. Do not unnecessarily burden senior developers. They are generally have other priorities.