mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Christoph Hellwig <hch@infradead.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: xni@redhat.com, agk@redhat.com, snitzer@kernel.org,
	mpatocka@redhat.com, song@kernel.org, dm-devel@lists.linux.dev,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH md-6.14 13/13] md/md-bitmap: support to build md-bitmap as kernel module
Date: Tue, 7 Jan 2025 11:43:33 +0800	[thread overview]
Message-ID: <4e436ffb-ea9f-a306-e495-c56b1e09f972@huaweicloud.com> (raw)
In-Reply-To: <Z3v1ss2aMrCI5whs@infradead.org>

Hi,

在 2025/01/06 23:24, Christoph Hellwig 写道:
> On Mon, Jan 06, 2025 at 07:35:33PM +0800, Yu Kuai wrote:
>> So there are total 6 existed helpers that I have to export, however,
>> these are all historical burdens, md_cluster, raid1 slow disk, ...
>> And I'm trying to get rid of them for the new md bitmap I'm working on.
>> If you really don't like *module*, I can change the config to bool. :)
> 
> FYI, I really like your previous cleanups to better encapsulate the
> bitmap code, and I'm also perfectly fine with a Kconfig options for it.

Good to know.

> 
> Also splitting existing code into modules has a tendency to break
> distro initramfs magic frequently even with request_module in place.
> So unless there is a really good reason I'd rather not do it.

Got it, I'll remove the patch 12 and change the bimtap config to bool
in the next version.

Thanks!
Kuai

> 
> .
> 


      reply	other threads:[~2025-01-07  3:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-25 11:15 [PATCH md-6.14 00/13] " Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 01/13] md/md-bitmap: remove the parameter 'init' for bitmap_ops->resize() Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 02/13] md/md-bitmap: merge md_bitmap_group into bitmap_operations Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 03/13] md/md-bitmap: add md_bitmap_registered/enabled() helper Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 04/13] md/md-bitmap: handle the case bitmap is not enabled before start_sync() Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 05/13] md/md-bitmap: handle the case bitmap is not enabled before end_sync() Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 06/13] md/dm-raid: check if bitmap is registered in raid_ctr() Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 07/13] md/raid1: check bitmap before behind write Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 08/13] md/raid1: check before deferencing mddev->bitmap_ops Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 09/13] md/raid10: " Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 10/13] md/raid5: " Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 11/13] md: " Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 12/13] md: export some helpers Yu Kuai
2024-12-25 11:15 ` [PATCH md-6.14 13/13] md/md-bitmap: support to build md-bitmap as kernel module Yu Kuai
2025-01-06 11:16   ` Christoph Hellwig
2025-01-06 11:35     ` Yu Kuai
2025-01-06 15:24       ` Christoph Hellwig
2025-01-07  3:43         ` Yu Kuai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e436ffb-ea9f-a306-e495-c56b1e09f972@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®