From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: renesas: Use hyphen in node names
Date: Fri, 9 Jan 2026 16:22:09 +0100 [thread overview]
Message-ID: <4e49ae45-87d6-469a-8cbf-6b43a1ea498f@oss.qualcomm.com> (raw)
In-Reply-To: <CAMuHMdX17mPy0__1Q=zDbfSTOJFO9jBCx7hFV=fSCRAi=o_sEw@mail.gmail.com>
On 09/01/2026 16:18, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Tue, 23 Dec 2025 at 16:24, Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com> wrote:
>> DTS coding style prefers hyphens instead of underscores in the node
>> names. Change should be safe, because node names are not considered an
>> ABI.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Thanks for your patch!
>
>> arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 4 ++--
>> arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts | 4 ++--
>> arch/arm64/boot/dts/renesas/r8a77980-v3hsk.dts | 4 ++--
>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>> arch/arm64/boot/dts/renesas/ulcb.dtsi | 2 +-
>> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Is there any specific reason you didn't fix the remaining ones?
These are coming from scripted sed, so probably my regex was incomplete.
But in few cases (not sure if here) I did not touch clock node names, if
they do not have clock-output-names, because it might break users.
>
> $ git grep -e '[a-zA-Z0-9-]*_[a-zA-Z0-9-]*@' HEAD --
> arch/arm64/boot/dts/renesas
> arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi:
> versaclock5: versaclock_som@6a {
> arch/arm64/boot/dts/renesas/condor-common.dtsi:
> cert_header_sa3@c0000 {
> arch/arm64/boot/dts/renesas/condor-common.dtsi:
> cert_header_sa6@180000 {
> arch/arm64/boot/dts/renesas/draak.dtsi:
> cert_header_sa6@180000 {
> arch/arm64/boot/dts/renesas/ebisu.dtsi:
> cert_header_sa6@180000 {
> arch/arm64/boot/dts/renesas/hihope-rev4.dtsi: cs2000: clk_multiplier@4f {
>
> No worries, will queue in renesas-devel for v6.20, with those fixed, too.
>
> Gr{oetje,eeting}s,
>
> Geert
>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-01-09 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 15:23 Krzysztof Kozlowski
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: renesas: Use lowercase hex Krzysztof Kozlowski
2026-01-09 15:22 ` Geert Uytterhoeven
2026-01-09 15:18 ` [PATCH 1/2] arm64: dts: renesas: Use hyphen in node names Geert Uytterhoeven
2026-01-09 15:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e49ae45-87d6-469a-8cbf-6b43a1ea498f@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®