From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Peter Yin <peteryin.openbmc@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: Harma: update sgpio line name
Date: Wed, 21 Aug 2024 10:40:06 +0930 [thread overview]
Message-ID: <4e49f0c3a0ec4f1e508cae289f82ddbd02f9c0a6.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240820102904.1756785-3-peteryin.openbmc@gmail.com>
Hi Peter,
On Tue, 2024-08-20 at 18:29 +0800, Peter Yin wrote:
> From: Peter Yin <peter.yin@quantatw.com>
>
> power-card-enable
> uart-switch-button
> power-fault-n
> asic0-card-type-detection0-n
> asic0-card-type-detection1-n
> asic0-card-type-detection2-n
> uart-switch-lsb
> uart-switch-msb
>
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
Can you please your author email consistent with your Signed-off-by
email? Currently this generates a checkpatch warning:
Executing: ./scripts/checkpatch.pl --strict -g HEAD
WARNING: From:/Signed-off-by: email address mismatch: 'From: Peter Yin <peter.yin@quantatw.com>' != 'Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>'
Thanks,
Andrew
> ---
> .../dts/aspeed/aspeed-bmc-facebook-harma.dts | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> index 92068c65eae4..9db95a791128 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> @@ -566,7 +566,7 @@ &gpio0 {
> /*B0-B7*/ "","","","",
> "bmc-spi-mux-select-0","led-identify","","",
> /*C0-C7*/ "reset-cause-platrst","","","","",
> - "cpu0-err-alert","","",
> + "cpu0-err-alert","power-card-enable","",
> /*D0-D7*/ "","","sol-uart-select","","","","","",
> /*E0-E7*/ "","","","","","","","",
> /*F0-F7*/ "","","","","","","","",
> @@ -585,7 +585,9 @@ &gpio0 {
> /*O0-O7*/ "","","","","","","","",
> /*P0-P7*/ "power-button","power-host-control",
> "reset-button","","led-power","","","",
> - /*Q0-Q7*/ "","","","","","power-chassis-control","","",
> + /*Q0-Q7*/
> + "","","","",
> + "","power-chassis-control","","uart-switch-button",
> /*R0-R7*/ "","","","","","","","",
> /*S0-S7*/ "","","","","","","","",
> /*T0-T7*/ "","","","","","","","",
> @@ -685,7 +687,7 @@ &sgpiom0 {
> "FM_BOARD_REV_ID2","",
> "FM_BOARD_REV_ID1","",
> /*H0-H3 line 112-119*/
> - "FM_BOARD_REV_ID0","",
> + "FM_BOARD_REV_ID0","reset-control-cmos-clear",
> "","","","","","",
> /*H4-H7 line 120-127*/
> "","",
> @@ -716,9 +718,15 @@ &sgpiom0 {
> "cpu0-thermtrip-alert","",
> "reset-cause-pcie","",
> /*L4-L7 line 184-191*/
> - "pvdd11-ocp-alert","","","","","","","",
> + "pvdd11-ocp-alert","",
> + "power-fault-n","",
> + "asic0-card-type-detection0-n","",
> + "asic0-card-type-detection1-n","",
> /*M0-M3 line 192-199*/
> - "","","","","","","","",
> + "asic0-card-type-detection2-n","",
> + "uart-switch-lsb","",
> + "uart-switch-msb","",
> + "","",
> /*M4-M7 line 200-207*/
> "","","","","","","","",
> /*N0-N3 line 208-215*/
prev parent reply other threads:[~2024-08-21 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 10:29 [PATCH v1 0/2] Revise Meta(Facebook) Harma BMC(AST2600) Peter Yin
2024-08-20 10:29 ` [PATCH v1 1/2] ARM: dts: aspeed: Harma: add rtc device Peter Yin
2024-08-20 10:29 ` [PATCH v1 2/2] ARM: dts: aspeed: Harma: update sgpio line name Peter Yin
2024-08-21 1:10 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e49f0c3a0ec4f1e508cae289f82ddbd02f9c0a6.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peteryin.openbmc@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®