From: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Daniel Starke <daniel.starke@siemens.com>,
Jiri Slaby <jirislaby@kernel.org>,
Russ Gorby <russ.gorby@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH 5.10 0/3] tty: n_gsm: fix tty registration before control channel open
Date: Tue, 12 Dec 2023 12:25:40 +0000 [thread overview]
Message-ID: <4e524540-3e2c-4f27-afda-1f42465ecf18@infotecs.ru> (raw)
In-Reply-To: <2023121232-magenta-recall-2cec@gregkh>
On 12/12/23 14:44, Greg Kroah-Hartman wrote:
> On Tue, Dec 12, 2023 at 11:17:21AM +0000, Gavrilov Ilia wrote:
>> Syzkaller reports memory leak issue at gsmld_attach_gsm() in
>> 5.10 stable releases. The reproducer injects the memory allocation
>> errors to tty_register_device(); as a result, tty_kref_get() isn't called
>> after this error, which leads to tty_struct leak.
>> The issue has been fixed by the following patches that can be cleanly
>> applied to the 5.10 branch.
>>
>> Found by InfoTeCS on behalf of Linux Verification Center
>> (linuxtesting.org) with Syzkaller
>
> Do you actually have any hardware for this protocol running on the
> 5.10.y kernel? How was this tested? Why was just this specific set of
> patches picked to be backported?
>
No, I don't have any hardware for this protocol. I tested this manually
on virtual machines and using a reproducer (generated by syzkaller).
The first patch fixes the main problem(memory leak). The third patch
fixes the problem with а null pointer dereference. I added this patch
because it has a "fixes" tag that references to the first patch. The
third patch can't be applied cleanly without the second patch.
> thanks,
>
> greg k-h
prev parent reply other threads:[~2023-12-12 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 11:17 Gavrilov Ilia
2023-12-12 11:17 ` [PATCH 5.10 1/3] " Gavrilov Ilia
2023-12-12 11:17 ` [PATCH 5.10 2/3] tty: n_gsm, remove duplicates of parameters Gavrilov Ilia
2023-12-12 11:17 ` [PATCH 5.10 3/3] tty: n_gsm: add sanity check for gsm->receive in gsm_receive_buf() Gavrilov Ilia
2023-12-12 11:44 ` [PATCH 5.10 0/3] tty: n_gsm: fix tty registration before control channel open Greg Kroah-Hartman
2023-12-12 12:25 ` Gavrilov Ilia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e524540-3e2c-4f27-afda-1f42465ecf18@infotecs.ru \
--to=ilia.gavrilov@infotecs.ru \
--cc=daniel.starke@siemens.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=russ.gorby@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®