From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F0A538759C for ; Wed, 8 Jul 2026 10:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783504896; cv=none; b=n5xNvLQbkT9uVO46LEiHRZtDg1whnnBvUAV6CP01DOlrxLMX8FFtP4BiPCCaNv31gX0rE0qo6SIjGtezRSQV4aQKav+Zzl6d+d/pUet75o+BaXC7A4lpcffsNo85ew8DwRS2GLYhw+Vj/PpYkiwv9DdH4l0/KgyAaJEFjJ54dBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783504896; c=relaxed/simple; bh=oKVfH/0Hygcklu+R5xYMT12z1eblv56XDMwOFHZZNzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=og2Jr72dxx7ikhHyracgl/IrPrJZ0kM5SDc13vpabU2YgB0YN4hZUSSGdPqNy/hOI0tIGd8Od/BW2SxUnyxZCaiBr/dPcmSemW62nFv2PZyyljEhUbegfIc66UGpkzotrKguTX14U6aK9wu+IYoi5Foia/WFI0q7wSaFwaTsh34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oltHG4ZG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iSCCQCEB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oltHG4ZG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iSCCQCEB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66889ISr2186462 for ; Wed, 8 Jul 2026 10:01:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XQ9AX7OhkLOaP+j4lLrbeTNcxF7e4kwK6kGQsbCEXA8=; b=oltHG4ZG0U80gfpJ tYRua4KBzGf901wPuYRVh2i5a1FPhwH/fr5a0zAjX3VDEublxoHPSvbZVaHRjjT5 CVNGhLqADIgdvEh+ShfpeXP7RXFgIQ32QbejmmRBpxzEg243jUP69Vl3QIpt/3ue wOlVnwQMI5cMt5cnRPvam1Gpq/+FxAldRghc0cFUCAhGcdwDssjsTTQtE/2Cv2ZD IWjMXV6OPjWh7LeTjXNlTovAKeiijLRzgWQqQQt4W9x5DEJhXHA5z98Sm5mYdGVJ a1ACK+xTymCfENv1pL85ypKsPEXw7JDCXTDpWaCUDQ4ZEwRMav11ZN4OetgL0ZVW +LRCmw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f95fd3w9f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 10:01:33 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84770f89b99so994360b3a.1 for ; Wed, 08 Jul 2026 03:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783504893; x=1784109693; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XQ9AX7OhkLOaP+j4lLrbeTNcxF7e4kwK6kGQsbCEXA8=; b=iSCCQCEBF2iep+w3thlr7rHKWYt30xzMplEk9qjon3uBwp6Ggx7LN9IShcbHOqg5Fi A1AvhZENbeL9oaKGsHRbL9sQDTxP9leUs6tz4dwrmUOYnEG8bTSP13+aLLHM0EyTDENQ wkpdvUmIa+RW3SoHIBpzwf0MBnePNzOqL8Vxic5bsSPIdFfVtO/5+Czcjd9hnUosSVkw ys25jiBE3DxfZGQYr9RnNQGcAPi9AbGoOTwQEQ6SYuA7bRKbuWv/EaokTg/zIsnD0AZ8 l5v24dJ+ah1q00WOOOwjTIO0DZXX2IeR+tptJ8PyVO5UgufJpWbv8PFxCU1dGFkXhhRt eSLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783504893; x=1784109693; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XQ9AX7OhkLOaP+j4lLrbeTNcxF7e4kwK6kGQsbCEXA8=; b=B1LdnjtIDjF0Xt5xwWQUGR3TT4CqP7NNXFpjp1Ae62SqgXx0D3y6rVljf1C95F7wtq XjSBwQQyj5qFlSIeoYZkvHSyyOhf9XvAHknmV8Lll4rRlDEpYTT9ysTNjReNrhf6GGq8 yYSnSlHpMskmO+wF9zH1KtDNq7J92QvdjR4fnskRMKiDyOxb/ZJROUBzbnLYkM+yTNgl xo91pGXHjvRfkfVifa3JrAlCwW4ReTE13YlRHk/pHeaDt8tGtUc952XjpkHe8UXunCUo N5EyWHLKbMIx7Hdyu4z4Bc5nha7Asw94jAg5D9OqT/uz1UMM8PQOPuWAbDu4phl7S74g eIxg== X-Forwarded-Encrypted: i=1; AHgh+RoN7IKoDr2Y4rVvN3AJ04BVstsHEFt3gGYLDUNJE6+f8NooSvAav+7CHX/R2VOSce4hEo9Zm/nsysbo+4o=@vger.kernel.org X-Gm-Message-State: AOJu0YzjYy0/ozIG0RSGQlu6eJ5ZSKGihvW2wzjiqe4Gfx+hopRzrLfH 6cHj3WluIyQLwvCFCCsQ3s0sxIx/CFLuslEDXw0sFmafrxVP0kPBNuyuysr2nY8tlbVbfReY+Gi yZf4cyBFHnXcoW9G43IW5WQvDJtzEIohtWRzY28Yn3ID7UJiL4Z8/oK33z9uq07QcLSpVfc0ca7 c= X-Gm-Gg: AfdE7ckUR1J8+MEZUalzS9dWcBRdRYcmhw1NiHSSNaJGRgzTk2SZ9+W2ZSaei1cfvGj ne4dQsfn2DhPbhbKvYAUZDGEdoVS8XsWGPJ8grI+HQ66rRUmrb5pglhp07gmq5LmFRjBP85eZsB MLbOe6QxeK1tB4UUonHOguThz4GJDHApz3HfkDlHYKqyLK8ybLPS8tQZdyUhlwMN6pXGBKsljoo nGltBZZCtz+lZkqTYySx5nvqgPfe4Uh9EiFJFTW77geXa8vLDRijhtDlQ+/25bCPHslh3lZhGZ/ JbN5bo/rUWg5sbXcpBeL6Qx2SpiaGEEqHfqLGBLqHvPBw0VpvDJycIcN1HeSoh2j0ak6Djv8oRy p+wkgNE8wL8fnyOd0ylqqJk01mnbJdnUQOiaHLQ4= X-Received: by 2002:a05:6a00:2e24:b0:82f:3a1e:5618 with SMTP id d2e1a72fcca58-84842ee9c8emr1865559b3a.22.1783504892624; Wed, 08 Jul 2026 03:01:32 -0700 (PDT) X-Received: by 2002:a05:6a00:2e24:b0:82f:3a1e:5618 with SMTP id d2e1a72fcca58-84842ee9c8emr1865535b3a.22.1783504892128; Wed, 08 Jul 2026 03:01:32 -0700 (PDT) Received: from [10.219.56.198] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6d4e741sm6916358b3a.28.2026.07.08.03.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 03:01:31 -0700 (PDT) Message-ID: <4e5a3d82-b946-4490-885a-ea7061939c32@oss.qualcomm.com> Date: Wed, 8 Jul 2026 15:31:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/6] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU To: Dmitry Baryshkov Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260706-smmu_interconnect_addition-v3-0-afdca0125a65@oss.qualcomm.com> <20260706-smmu_interconnect_addition-v3-3-afdca0125a65@oss.qualcomm.com> <807f145d-88d3-460a-9862-b63fe2a52cf7@oss.qualcomm.com> Content-Language: en-US From: Bibek Kumar Patro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDA5NiBTYWx0ZWRfXzdaTNATpKvam jqgWv2CXoqBf04e2VUHPBzDDjIdkVwVXzxESsqVLpYzPig0pzMfgymy1Dh1XK7DDbJSlfqI5Ghc FLNITDYXJ8J18u7IvTPJOAkemkmT46qsRPpNgwC7t5A4B4OzZBVz0IRe+C/rZ0n+8dZsoNDTtci kBsaOeMg3LNfk0BQp7j4+Y8w9Vg4/YDPCvPMJ8XDNHcaeuafIhss7qT6VKIgOKLvfrMrAQEESlI EDMu6VYmFgowgbXo2IWs4aso0NTmWp7lfAS1SyuixYfV+ebXAuY5rdqazu6enWP+BP556CcVtyM nQdVAQh10DTppR6IgQq0VPfshgVaCEo0CQPJZ4sdKA3009fVlCo542bAp262/q7QkYfiVE2rOjq SpTKYJn5HZ1Fo2jRRhOZUwuwYD//Bhz1bgbz/wUUjR+6Aa2mMyKr9mbAPkDYLkcRT6a04GTsu3Q fucvAFwbmfzXlDMLpsw== X-Authority-Analysis: v=2.4 cv=VZLH+lp9 c=1 sm=1 tr=0 ts=6a4e1ffd cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Gb3r-SE-3tiIfwJ9XNYA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: K4oD8mmqeokUohGhN4PhSIvl2c2ekFDV X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDA5NiBTYWx0ZWRfXwuLv9JaONMvZ Xfwr2NTYJLww3YnJ0kbHqZSEGHwbnpMjhyQjhXwRSikgKdyEE0SG4+1c3heZdQhd0c14bwmrWed BhY+R7xku9qH1TkjXjpqkEn3PWLK0DM= X-Proofpoint-GUID: K4oD8mmqeokUohGhN4PhSIvl2c2ekFDV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080096 On 7/7/2026 10:14 PM, Dmitry Baryshkov wrote: > On Tue, Jul 07, 2026 at 06:37:24PM +0530, Bibek Kumar Patro wrote: >> >> >> On 7/6/2026 11:12 PM, Dmitry Baryshkov wrote: >>> On Mon, Jul 06, 2026 at 10:26:36PM +0530, Bibek Kumar Patro wrote: >>>> On Kodiak platforms, the Adreno SMMU requires a bandwidth vote on >>>> the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers >>>> are accessible. Without this vote, the SMMU may become unreachable, >>>> leading to intermittent probe failures and runtime issues. >>>> >>>> Add the required interconnect to ensure reliable register access. >>>> >>>> Signed-off-by: Bibek Kumar Patro >>>> --- >>>> arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> index 90e50c245c0c..721526f023dd 100644 >>>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> @@ -3389,6 +3389,8 @@ adreno_smmu: iommu@3da0000 { >>>> power-domains = <&gpucc GPU_CC_CX_GDSC>; >>>> dma-coherent; >>>> + interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS >>>> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >>> >>> Why is it ALWAYS? Would it be better to declare it as ACTIVE_ONLY and >> >> Added QCOM_ICC_TAG_ALWAYS, to hold the vote in SLEEP bucket as well >> preventing gem_noc going to sleep when icc_set_bw is being called. > > _why_? > Now when i think of where we implemented the hooks, ALWAYS is not needed. We should keep it ACTIVE_ONLY since we are already voting it back in resume pah. I'll fix it in next revision. >> >>> then drop the extra suspend/resume play? >> >> Not sure if I understood it correctly. >> Did you mean the extra suspend/resume play in arm_smmu_runtime_suspend >> or in arm_smmu_device_shutdown() path? > > runtime_suspend/resume. I might be incorrect here, but I think it is > exactly what you need. > Yes, I think we should go with the ACTIVE_ONLY flag and we would need this voting in suspend resume path (For the same reason mentioned in commit description and cover letter of the series). ALWAYS would avoid the need for this handling, it would keep the vote active unnecessarily, but still that would have been nondeterministic. Thanks & regards, Bibek >> >> Thanks & regards, >> Bibek >> >>> >>>> }; >>>> gfx_0_tbu: tbu@3dd9000 { >>>> >>>> -- >>>> 2.34.1 >>>> >>> >> >