From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 149B8C76186 for ; Thu, 25 Jul 2019 01:18:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D651421855 for ; Thu, 25 Jul 2019 01:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728954AbfGYBSX (ORCPT ); Wed, 24 Jul 2019 21:18:23 -0400 Received: from smtprelay0206.hostedemail.com ([216.40.44.206]:35341 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726300AbfGYBSX (ORCPT ); Wed, 24 Jul 2019 21:18:23 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 5FF5818026238; Thu, 25 Jul 2019 01:18:21 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: rain11_48b2601630360 X-Filterd-Recvd-Size: 2496 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Thu, 25 Jul 2019 01:18:19 +0000 (UTC) Message-ID: <4e5bc8d61436024a30a8fb6a1516e29e23a75ede.camel@perches.com> Subject: Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro From: Joe Perches To: Andrew Jeffery , Andrew Morton , Joel Stanley Cc: David Airlie , Daniel Vetter , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 24 Jul 2019 18:18:18 -0700 In-Reply-To: <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> References: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > Arguments are supposed to be ordered high then low. > > > > > > Signed-off-by: Joe Perches > > > --- > > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > index a10358bb61ec..095ea03e5833 100644 > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > > /* CTRL2 */ > > > #define CRT_CTRL_DAC_EN BIT(0) > > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) > > > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > > > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) > > Reviewed-by: Andrew Jeffery This hardly needs a review, it needs to be applied. There's a nominal git tree for aspeed here: T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git But who's going to do apply this?