mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@altera.com>,
	linux-kernel@vger.kernel.org,
	Ang Tien Sung <tiensung.ang@altera.com>
Subject: Re: [PATCH v2 1/1] firmware: stratix10-svc: fix bug in saving controller data
Date: Thu, 30 Oct 2025 06:48:16 -0500	[thread overview]
Message-ID: <4e60eee9-5afb-4c97-8c05-96ab39da62b1@kernel.org> (raw)
In-Reply-To: <b28ba544224536391e3e7e2c1aac9c31b5b01216.1761740742.git.khairul.anuar.romli@altera.com>



On 10/29/25 07:31, Khairul Anuar Romli wrote:
> Fix the incorrect usage of platform_set_drvdata and dev_set_drvdata. They
> both are of the same data and overrides each other. This resulted in the
> rmmod of the svc driver to fail and throw a kernel panic for kthread_stop
> and fifo free.
> 
> Fixes: bf0e5bf68a20 ("firmware: stratix10-svc: extend svc to support new RSU features")
> cc: stable@vger.kernel.org # 6.6+

Please read the stable kernel rules documentation for future submissions:

stable-kernel-rules.rst


> Signed-off-by: Ang Tien Sung <tiensung.ang@altera.com>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> ---
> Changes in v2:
> 	- Add CC that was missed in the v1 and original patch from 2023
> ---
>   drivers/firmware/stratix10-svc.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 

This patch does not apply cleanly on v6.18-rc1. Please rebase and resubmit.

Thanks,
Dinh

  reply	other threads:[~2025-10-30 11:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1761740742.git.khairul.anuar.romli@altera.com>
2025-10-29 12:31 ` Khairul Anuar Romli
2025-10-30 11:48   ` Dinh Nguyen [this message]
2025-10-31  0:13     ` [PATCH] Some subject line Khairul Anuar Romli
2025-10-31 12:07       ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e60eee9-5afb-4c97-8c05-96ab39da62b1@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=khairul.anuar.romli@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiensung.ang@altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®