mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <daniel.lezcano@linaro.org>, <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning
Date: Thu, 9 Jan 2020 12:29:32 +0000	[thread overview]
Message-ID: <4e71d1f3-f28a-1c34-3869-bc24b7caad32@microchip.com> (raw)
In-Reply-To: <362407a3-036a-c38d-1dc4-2730d616592b@linaro.org>



On 09.01.2020 13:59, Daniel Lezcano wrote:
> On 06/01/2020 10:58, Claudiu Beznea wrote:
>> Fix sparse warning.
> 
> Mind to give the warning?

Sorry, is this one: "warning: Using plain integer as NULL pointer".

Would you like me to send v2 updating it with the warning?

Thank you,
Claudiu Beznea

> 
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>  drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
>> index 27a389a7e078..bd63d3484838 100644
>> --- a/drivers/clocksource/timer-microchip-pit64b.c
>> +++ b/drivers/clocksource/timer-microchip-pit64b.c
>> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
>>       if (!pclk_rate)
>>               return -EINVAL;
>>
>> +     timer->mode = 0;
>> +
>>       /* Try using GCLK. */
>>       gclk_round = clk_round_rate(timer->gclk, max_rate);
>>       if (gclk_round < 0)
>> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
>>                                           bool clkevt)
>>  {
>>       u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
>> -     struct mchp_pit64b_timer timer = { 0 };
>> +     struct mchp_pit64b_timer timer;
>>       unsigned long clk_rate;
>>       u32 irq = 0;
>>       int ret;
>>
> 
> 
> --
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 
> 

  reply	other threads:[~2020-01-09 12:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06  9:58 Claudiu Beznea
2020-01-09 11:59 ` Daniel Lezcano
2020-01-09 12:29   ` Claudiu.Beznea [this message]
2020-01-09 12:40     ` Daniel Lezcano
2020-01-09 12:52       ` Claudiu.Beznea
2020-01-16 21:30 ` [tip: timers/core] clocksource/drivers/timer-microchip-pit64b: Fix " tip-bot2 for Claudiu Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e71d1f3-f28a-1c34-3869-bc24b7caad32@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®